Date: Tue, 1 Jan 2008 11:09:30 +0100
From: Sam Ravnborg <sam@ravnborg.org>
To: WANG Cong <xiyou.wangcong@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, linux-kbuild@vger.kernel.org,
       Andrew Morton <akpm@osdl.org>
Subject: Re: [Patch 0/8] Remove 'TOPDIR' from Makefiles
Message-ID: <20080101100930.GA28913@uranus.ravnborg.org>
References: <20080101071311.GA2496@hacking>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080101071311.GA2496@hacking>
User-Agent: Mutt/1.4.2.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 673
Lines: 20

On Tue, Jan 01, 2008 at 03:13:11PM +0800, WANG Cong wrote:
> 
> TOPDIR is obsolete, use srctree or objtree instead.

Glad to see this being done - long overdue.

Most of your patches (if not all) replaces TOPDIR
with objtree but usage of objtree is only
correct when dealing with output files.
Note that objtree != srctree only for O=... builds.

And a few cases should be dealt with differently.
See individual comments.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/