Received-SPF: pass (google.com: domain of linux-kernel+bounces-78970-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: "Ruhl, Michael J" <michael.j.ruhl@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC: "linux@armlinux.org.uk" <linux@armlinux.org.uk>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] clkdev: Update clkdev id usage to allow for longer
 names
Thread-Topic: [PATCH v2] clkdev: Update clkdev id usage to allow for longer
 names
Thread-Index: AQHaZnZVyb+ntBY6PE6Aidjrz3mClbEYMnAAgAAJ6SA=
Date: Fri, 23 Feb 2024 18:22:13 +0000
Message-ID: <DS0PR11MB64248E0C15C0B86A1CCF945BC1552@DS0PR11MB6424.namprd11.prod.outlook.com>
References: <20240223163516.796606-1-michael.j.ruhl@intel.com>
 <ZdjZCrpP52Hfbs6L@smile.fi.intel.com>
In-Reply-To: <ZdjZCrpP52Hfbs6L@smile.fi.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ugtz+XV0Iv+G+L5YYRWsFIZs45dMzqpcDEEngR0cRbFKSHcFTFzj8qZR3PFK?=
 =?us-ascii?Q?X3Zcpze2U5EUY9CsEHHXbgexVhwP1KO2uSC18mSwjg3JgY1gvUAivm8EYr0g?=
 =?us-ascii?Q?J+4VPWQ0hPez5RM5JPEAQHQISIvI8UgSzwKZV0CnB8uPIre+N7MaNUayZT0E?=
 =?us-ascii?Q?vf6Yqfval5PaVpaMehRdfZ33ZIxAArjMb+dCraLGxv6sgizk2ns2Ttmn1swc?=
 =?us-ascii?Q?w4z1qluNfEPnVfTN866uU4CthmHFSPITfzgnCwSsEbafLevrU+dC0l9aP+9g?=
 =?us-ascii?Q?bZj5dCVEV7lcdduG5M+BgvlBcIm5HOr13mT24i6X4vHQVKE4g7HChcTCixJi?=
 =?us-ascii?Q?9O+1QDRntUDYXZO7k1tR63EAjndT4BRScXMU1vdJConKLHuwToy0uZXEoDj+?=
 =?us-ascii?Q?p++n84djEa3d6uRzcMp+UYgg/IGKnLl0/njDhLQ43W+A3yvKI4Mj6RAPJti/?=
 =?us-ascii?Q?ALxFa9X/5USHJG4szropMkbNmzDsN4GIV/tObjXRqCtBksaRHDpjiQxMV9QY?=
 =?us-ascii?Q?+pBrko/NKwnlGKCUNNhdKYqIz9HyNFZj8nFCSyiZSaFRr740QaUqgd2FUNEy?=
 =?us-ascii?Q?PDxGdxfC5/fE3c+vvxkoJWbs/VeUlG8hnVDr50fEEf30LmmVCPyS5a2Ctk1M?=
 =?us-ascii?Q?flPL3Lc2/T6ZNyCJS/wo7opgFV+XiodA94QMBrvMIRWp8PS6YpScK0KxvaYq?=
 =?us-ascii?Q?shgDQbPbQFapQyyT2x7h7SRAjlBYxCpQZdnTCL9onTDhTpBYixTZjw+dQZEo?=
 =?us-ascii?Q?IBI0ZcLAhPGX5eyI2K3oSFWU0IrxevdkvKI3V/Ij9jh9LqJmWfhBUknebieE?=
 =?us-ascii?Q?rEq6EszenQX2g89Bu0Q3KT7qiD7eY1DJ7AYvQNMYNLaavywZxlXAgYj9SgX8?=
 =?us-ascii?Q?VUgG1cNQvzlRKpGSc4aSUvkZ7N5iGzpqN5ZXwniNRtnCF6DBN8+bW+Veis6d?=
 =?us-ascii?Q?eVIW7cuv5x8INKUHtQOjHMsKwASt6hseKfp+9p6w7j8+xblZ+KVBgycDsayF?=
 =?us-ascii?Q?3liLDBMNNAjQKC+pCZSlsEHAKdmM8WiW7+eLW2ASml6w+70VWio6OSSUpxBT?=
 =?us-ascii?Q?1Ze6mHJpLkBOIp5hJj4MrAv8Z2RQCMK8eEwL6kOkrAiYugP3nRWmosIc302K?=
 =?us-ascii?Q?vjsxRBOQ1pks3pGU8W5E1Zzqd9E1Tfg50vx0n0pDVmWa0NnzjgUHFzCtmwfD?=
 =?us-ascii?Q?yW0Aw7c5bnLVmvffYatdVmGEDl2bn+54UK1U6gF9RTVl2MdgqLdscRHEGZZ8?=
 =?us-ascii?Q?FMbrg119tzfYvirHqq38Rf6vCAIqGJ/JNpJ6TKa2IdOiYrfz/+Fsfhbc46/1?=
 =?us-ascii?Q?d5NisjJ33i5uK8rly/ys4aE/A6a0m8xLAIS1HpA+cuc2rjXh1csctz/KCAfn?=
 =?us-ascii?Q?UnfZT6zbNH0cVuOI4wEkdsWUuMHnOifMOs/hSXd5s5QqInQgvlNbA1GVHYiS?=
 =?us-ascii?Q?14z2thGKPrz5Dg0c7m/OIFGi0+X5uWXjFJzTjo/l2yYa7paJOjnK7wZiz+Np?=
 =?us-ascii?Q?Gs+vKWfT2jNhstLVUuM43XLiQy0iVAbYChc5cUIMHtrnnnlxrzo+zI9IaCvP?=
 =?us-ascii?Q?8zBh1/TFRx1I82kA4ZayDENl4CeL+7cDQM/iwuAt?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB6424.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 23ecfc97-8707-4ceb-7b90-08dc349c5ba5
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Feb 2024 18:22:13.6736
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: l0VGA14YH9BywewEUBYndjerRVnysBcIBuQwawXG9ViS5REd0cAteljwj5bhmVMaIOGye+oU8yZ+jU+mWhRp+tRHmrX0IO+Rmq6YEOlwV+o=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB8086
X-OriginatorOrg: intel.com

>-----Original Message-----
>From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>Sent: Friday, February 23, 2024 12:43 PM
>To: Ruhl, Michael J <michael.j.ruhl@intel.com>
>Cc: linux@armlinux.org.uk; linux-arm-kernel@lists.infradead.org; linux-
>kernel@vger.kernel.org
>Subject: Re: [PATCH v2] clkdev: Update clkdev id usage to allow for longer
>names
>
>On Fri, Feb 23, 2024 at 11:35:16AM -0500, Michael J. Ruhl wrote:
>> clkdev DEV ID information is limited to an array of 20 bytes
>> (MAX_DEV_ID).  It is possible that the ID could be longer than
>> that.  If so, the lookup will fail because the "real ID" will
>> not match the copied value.
>>
>> For instance, generating a device name for the I2C Designware
>> module using the PCI ID can result in a name of:
>>
>> i2c_designware.39424
>>
>> clkdev_create() will store:
>>
>> i2c_designware.3942
>>
>> The stored name is one off and will not match correctly during probe.
>>
>> Increase the size of the ID to allow for a longer name.
>
>> v2: Removed CON_ID update and added example to commit
>
>Usually we put changelog out of the commit messages...

Yeah, usually put it in the cover letter.  I will remove. I see your script=
 automatically
does a cover page...will use that format int the future.

>> Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
>> ---
>
>...somewhere here.

Ok.    Will keep for future reference.

>Also just noticed that you forgot CCF maintainers to be included.
>I'm suggesting to use my script [1] which harvests more or less
>adequate list of people and mailing lists to Cc email to.
>
>[1]: https://github.com/andy-shev/home-bin-
>tools/blob/master/ge2maintainer.sh

Using your script I got:

To: "Michael J. Ruhl" <michael.j.ruhl@intel.com>,
        linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Cc: Russell King <linux@armlinux.org.uk>

My list (using get_maintainers.pl) is:

linux@armlinux.org.uk
linux-arm-kernel@lists.infradead.org
linux-kernel@vger.kernel.org

They appear to be the same....

I don't have the plain text part on Russel's email (linxu@armlinux.org.uk).=
. Is that what is missing?

Not sure what CCF is?

M

>
>--
>With Best Regards,
>Andy Shevchenko
>