Received-SPF: pass (google.com: domain of linux-kernel+bounces-78966-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 23 Feb 2024 18:17:37 +0000
From: Conor Dooley <conor@kernel.org>
To: Lee Jones <lee@kernel.org>
Cc: Conor Dooley <conor.dooley@microchip.com>, Pavel Machek <pavel@ucw.cz>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Sven Schwermer <sven.schwermer@disruptive-technologies.com>,
	Christian Marangi <ansuelsmth@gmail.com>,
	linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: leds: pwm-multicolour: re-allow active-low
Message-ID: <20240223-register-snowbound-b837c8b1cc25@spud>
References: <20240213-verse-clinic-e6de06e1f18d@spud>
 <20240223154304.GE1666215@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="zXyJuKI1vC8uXvAV"
Content-Disposition: inline
In-Reply-To: <20240223154304.GE1666215@google.com>


--zXyJuKI1vC8uXvAV
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 23, 2024 at 03:43:04PM +0000, Lee Jones wrote:
> On Tue, 13 Feb 2024, Conor Dooley wrote:
>=20
> > From: Conor Dooley <conor.dooley@microchip.com>
> >=20
> > active-low was lifted to the common schema for leds, but it went
> > unnoticed that the leds-multicolour binding had "additionalProperties:
> > false" where the other users had "unevaluatedProperties: false", thereby
> > disallowing active-low for multicolour leds. Explicitly permit it again.
> >=20
> > Fixes: c94d1783136e ("dt-bindings: net: phy: Make LED active-low proper=
ty common")
> > Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> > ---
> >=20
> > I'm just assuming this is intentionally restrictive, if its not, we
> > could easily just change this to uneval: false.
> >=20
> > CC: Pavel Machek <pavel@ucw.cz>
> > CC: Lee Jones <lee@kernel.org>
> > CC: Rob Herring <robh@kernel.org>
> > CC: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> > CC: Conor Dooley <conor+dt@kernel.org>
> > CC: Sven Schwermer <sven.schwermer@disruptive-technologies.com>
> > CC: Christian Marangi <ansuelsmth@gmail.com>
> > CC: linux-leds@vger.kernel.org
> > CC: devicetree@vger.kernel.org
> > CC: linux-kernel@vger.kernel.org
> > ---
> >  Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> >=20
> > diff --git a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor=
=2Eyaml b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml
> > index 5edfbe347341..a31a202afe5c 100644
> > --- a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml
> > +++ b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml
> > @@ -41,6 +41,8 @@ properties:
> > =20
> >            pwm-names: true
> > =20
> > +          active-low: true
> > +
> >            color: true
> > =20
> >          required:
> > --=20
> > 2.43.0
>=20
> Neither checkpatch.pl or Git appear to be happy with this:

18:15:26 conor /stuff/linux$ shazam 20240213-verse-clinic-e6de06e1f18d@spud
Grabbing thread from lore.kernel.org/all/20240213-verse-clinic-e6de06e1f18d=
@spud/t.mbox.gz
Checking for newer revisions
Grabbing search results from lore.kernel.org
Analyzing 3 messages in the thread
Looking for additional code-review trailers on lore.kernel.org
Checking attestation on all messages, may take a moment...
Retrieving CI status, may take a moment...
---
  =E2=9C=93 [PATCH] dt-bindings: leds: pwm-multicolour: re-allow active-low
    + Acked-by: Rob Herring <robh@kernel.org> (=E2=9C=93 DKIM/kernel.org)
  ---
  =E2=9C=93 Signed: openpgp/conor.dooley@microchip.com (From: conor@kernel.=
org)
  =E2=9C=93 Signed: DKIM/kernel.org
---
Total patches: 1
---
Applying: dt-bindings: leds: pwm-multicolour: re-allow active-low
18:15:39 conor /stuff/linux$ git show HEAD~1
commit 2d5c7b7eb345249cb34d42cbc2b97b4c57ea944e (tag: next-20240220, korg-n=
ext/master)

What do you use to apply patches? b4 seems to have no trouble.

Cheers,
Conor.

--zXyJuKI1vC8uXvAV
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZdjhQQAKCRB4tDGHoIJi
0m2dAP9AxmqLHjwfdwCzutyhWXrCxueWGcdbJvAVyVbFBdMTWAD+JzrGU15t7FOg
7SIlNUetEH7NFFcptya5JRzVPaw5ugY=
=HW3e
-----END PGP SIGNATURE-----

--zXyJuKI1vC8uXvAV--