Received-SPF: pass (google.com: domain of linux-kernel+bounces-78986-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 23 Feb 2024 18:34:39 +0000
From: Conor Dooley <conor@kernel.org>
To: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, linux-iio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: light: vishay,veml6075: make
 vdd-supply required
Message-ID: <20240223-niece-shakily-7e18b90f30e7@spud>
References: <20240223-veml6075_vdd-v1-1-ac76509b1998@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="Hgz/JpkIdG8P36dD"
Content-Disposition: inline
In-Reply-To: <20240223-veml6075_vdd-v1-1-ac76509b1998@gmail.com>


--Hgz/JpkIdG8P36dD
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 23, 2024 at 02:01:33PM +0100, Javier Carrasco wrote:
> The VEML6075 requires a single supply to operate. The property already
> exists in the bindings and it is used in the example, but it is still
> not on the list of required properties.
>=20
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
> ---
> The driver and bindings for the VEML6075 UV sensor were merged in the
> merge window for v6.8 i.e. they have not been released yet beyond rc.
>=20
> Applying this patch as a fix now would avoid an ABI break like the
> recently discussed here:
>=20
> https://lore.kernel.org/linux-iio/8409a5bc71b995e3b738b817a074cfb131c3b2b=
5.camel@gmail.com/
>=20
> On the other hand, from the same discussion it can be concluded that the
> major risk would be a potential warning with dtbs_check, in case this
> patch is applied during the next merge window.

I don't care if it introduces a dtbs_check problem, we can fix those.
The device clearly needs power and at least for linux it being missing
gets handled perfectly fine. I think it's pretty reasonable to do this.

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

>=20
> The VEML6075 driver already handles the power supply with
> devm_regulator_get_enable().
> ---
>  Documentation/devicetree/bindings/iio/light/vishay,veml6075.yaml | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/Documentation/devicetree/bindings/iio/light/vishay,veml6075.=
yaml b/Documentation/devicetree/bindings/iio/light/vishay,veml6075.yaml
> index abee04cd126e..91c318746bf3 100644
> --- a/Documentation/devicetree/bindings/iio/light/vishay,veml6075.yaml
> +++ b/Documentation/devicetree/bindings/iio/light/vishay,veml6075.yaml
> @@ -21,6 +21,7 @@ properties:
>  required:
>    - compatible
>    - reg
> +  - vdd-supply
> =20
>  additionalProperties: false
> =20
>=20
> ---
> base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d
> change-id: 20240223-veml6075_vdd-e2220158ffda
>=20
> Best regards,
> --=20
> Javier Carrasco <javier.carrasco.cruz@gmail.com>
>=20

--Hgz/JpkIdG8P36dD
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZdjlPwAKCRB4tDGHoIJi
0tYTAQC1+0IEYywpMoCMXpgH+lW/sykjfmPF82FwRnlmLuEcYgEAwShTG/cWRfqw
evhM0yVbHRI14c70ha4vcyKGg8SStQM=
=S2Pw
-----END PGP SIGNATURE-----

--Hgz/JpkIdG8P36dD--