Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754093AbYAAKad (ORCPT ); Tue, 1 Jan 2008 05:30:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752029AbYAAKa0 (ORCPT ); Tue, 1 Jan 2008 05:30:26 -0500 Received: from pasmtpb.tele.dk ([80.160.77.98]:58226 "EHLO pasmtpB.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751048AbYAAKaZ (ORCPT ); Tue, 1 Jan 2008 05:30:25 -0500 Date: Tue, 1 Jan 2008 11:30:26 +0100 From: Sam Ravnborg To: WANG Cong Cc: Tim Shimmin , LKML , linux-kbuild@vger.kernel.org, Andrew Morton , viro@zeniv.linux.org.uk Subject: Re: [Patch 7/8] FS: Remove 'TOPDIR' from Makefiles Message-ID: <20080101103026.GG28913@uranus.ravnborg.org> References: <20080101071311.GA2496@hacking> <20080101074105.GH2496@hacking> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080101074105.GH2496@hacking> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1477 Lines: 40 On Tue, Jan 01, 2008 at 03:41:05PM +0800, WANG Cong wrote: > > TOPDIR is obsolete, use objtree instead. > This patch removes TOPDIR from all fs/ Makefiles. > > Cc: Alexander Viro > Cc: Tim Shimmin > Cc: Sam Ravnborg > Signed-off-by: WANG Cong > > --- > > diff --git a/fs/smbfs/Makefile b/fs/smbfs/Makefile > index 6673ee8..9b5e92b 100644 > --- a/fs/smbfs/Makefile > +++ b/fs/smbfs/Makefile > @@ -34,5 +34,5 @@ proto: > @echo >> proto2.h "struct sock;" > @echo >> proto2.h "struct statfs;" > @echo >> proto2.h "" > - cproto -E "gcc -E" -e -v -I $(TOPDIR)/include -DMAKING_PROTO -D__KERNEL__ $(SRC) >> proto2.h > + cproto -E "gcc -E" -e -v -I $(objtree)/include -DMAKING_PROTO -D__KERNEL__ $(SRC) >> proto2.h > mv proto2.h proto.h > diff --git a/fs/xfs/Makefile b/fs/xfs/Makefile > index 49e3e7e..d1d3d49 100644 > --- a/fs/xfs/Makefile > +++ b/fs/xfs/Makefile > @@ -1 +1 @@ > -include $(TOPDIR)/fs/xfs/Makefile-linux-$(VERSION).$(PATCHLEVEL) > +include $(objtree)/fs/xfs/Makefile-linux-$(VERSION).$(PATCHLEVEL) The whole "Maintainer rules" part of this file should be deleted. I cannot see how it can be used anyway. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/