Received-SPF: pass (google.com: domain of linux-kernel+bounces-79022-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Rahul Rameshbabu <rrameshbabu@nvidia.com>
To: Saeed Mahameed <saeed@kernel.org>,
	Leon Romanovsky <leon@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Richard Cochran <richardcochran@gmail.com>,
	Tariq Toukan <tariqt@nvidia.com>,
	Gal Pressman <gal@nvidia.com>,
	Vadim Fedorenko <vadim.fedorenko@linux.dev>,
	Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Przemek Kitszel <przemyslaw.kitszel@intel.com>,
	Ahmed Zaki <ahmed.zaki@intel.com>,
	Alexander Lobakin <aleksander.lobakin@intel.com>,
	Hangbin Liu <liuhangbin@gmail.com>,
	Paul Greenwalt <paul.greenwalt@intel.com>,
	Justin Stitt <justinstitt@google.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	Maxime Chevallier <maxime.chevallier@bootlin.com>,
	Kory Maincent <kory.maincent@bootlin.com>,
	Wojciech Drewek <wojciech.drewek@intel.com>,
	Vladimir Oltean <vladimir.oltean@nxp.com>,
	Jiri Pirko <jiri@resnulli.us>,
	Jacob Keller <jacob.e.keller@intel.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Jose Abreu <joabreu@synopsys.com>,
	Dragos Tatulea <dtatulea@nvidia.com>
Cc: netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org,
	Rahul Rameshbabu <rrameshbabu@nvidia.com>,
	Saeed Mahameed <saeedm@nvidia.com>
Subject: [PATCH RFC net-next v1 2/6] net/mlx5e: Introduce lost_cqe statistic counter for PTP Tx port timestamping CQ
Date: Fri, 23 Feb 2024 11:24:46 -0800
Message-ID: <20240223192658.45893-3-rrameshbabu@nvidia.com>
In-Reply-To: <20240223192658.45893-1-rrameshbabu@nvidia.com>
References: <20240223192658.45893-1-rrameshbabu@nvidia.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?n0ysmiqtDacUArw2aFFE+McfQ1OgVK5XM1tqebK4eIm3VEcZw/cVonuX+DX3?=
 =?us-ascii?Q?1alb+HYHL+/P9lyXdb1k0t7OJ0Fh1idDrs5TGBcYHtqmVa481STuIHsO22QX?=
 =?us-ascii?Q?15URWEs/5SKnmQRH/TUjaV2JuVqd1xN/5CukouCC//oau6dEKY3nCBAIZRWh?=
 =?us-ascii?Q?4Fujt4fE4L3GuxHgC57mRC6sIa6Ma9QzcyBZ1qniNUVxg/BxeEX7wPLX8A7R?=
 =?us-ascii?Q?IrzfAZfNrisHVvZFHuhYkWdANtKuEVuvwwRBVI96Yrn1PegLNa9TeXaReaEI?=
 =?us-ascii?Q?seRNm3f9de2GMzjbLcOdAX7wBeQexILNyic0b7m5EHdauIUtYxOIy7kA76wl?=
 =?us-ascii?Q?AO9QZUQFIUT7up74SJi3HX9AEGAkbhIO9BshQsHoz4Ehs6iMlT8G1NvQbZ77?=
 =?us-ascii?Q?E7FOUPIIVbGfJwf/EZ+OsIma7XeNfWvuQicE4HUzUFGtLnCEpx24k/pkV/O9?=
 =?us-ascii?Q?/p1dSWbyuK2xCGFLKO09Zxn0gfRcgKXRqzMLmwAMapx9733QjLTfNC55QNGW?=
 =?us-ascii?Q?dr/nSqIItEf8nL7z4mLNU3htyb9wU1LY0IyItgnWMI1wPMlJvihouw9cTPVJ?=
 =?us-ascii?Q?QEtjedHn9dvHahZvTwTRkDDTbYgYAgU5Pv8LjieDvViEmo2UqM+6GV0HMrj7?=
 =?us-ascii?Q?dAuE3x9Zst/dM/fw7E/RlONCmoxUw8psug3xnik0n3N/jVZm4VXFnVWdBspX?=
 =?us-ascii?Q?43uFLF4PRBGbmc+uVgRYvqpbUWGehtpFNIIhIivt1j4o+xvodreFRSoRVljY?=
 =?us-ascii?Q?rntx4rg7EC/05fov8NScchtQcEa1/N3/7ccA2hPwNSuOPaifDXq2wkfz/Vol?=
 =?us-ascii?Q?iwP961eeUYh9+IbIy8UBxIiCjP01tY4+irA8hinFqIfJr4KS60BJKE5gX1k0?=
 =?us-ascii?Q?mR0fqxfimo+Bwe/a4eeE3FRXUh+2mQ1L8aTnviu8m3yXbJ8EjzvzWz2bbHbC?=
 =?us-ascii?Q?7vmOqSAC3I7aSAwLMiEXFp2Y6FDPfoQasSXyixz0rLUG4YCHHqknHAvTKN+p?=
 =?us-ascii?Q?lvXEy6bY030RyQ8iUXfDATGGwS1H9N1Kummn/1wJ++LlKlaX8/f6UKUMrMGe?=
 =?us-ascii?Q?WJKHjYkxxJwhhhhVfEwofaSbB9PU5FG0+jfd79Cz5dOb6LwQDF3Lhu7u+kw7?=
 =?us-ascii?Q?qWCu0jXGt+OPrYXB968meMiXh7Osm3WwxUh05CU02O+DhasCHa+Y9z8mBQYl?=
 =?us-ascii?Q?ztSyUWm4BXrFYT2V5iIpcyh23mu7huUWnwnf669kbyrhYd9btCjgp5KzUPCe?=
 =?us-ascii?Q?888x4YnPH6Odg5BUcMdM2/abWjgtDhgCw56mvNVVORySWlK1J/CTbU1iezsY?=
 =?us-ascii?Q?aF6ARRj72Y3ImrIX2grFAzufzWt7Ba3CiUysPoT01lA8T1/lx/XEDUld223F?=
 =?us-ascii?Q?36GNF+A3wzN/pNHkcgibwgW34buDImnHjt+gYqiULqTSB2h2XEAhguoT+ZRI?=
 =?us-ascii?Q?RfDhv5owOvH8liNSNKxIfYc7I4ud+WyvEdus9xeVhm2W+4eO3nG0yWc/+I8Z?=
 =?us-ascii?Q?vr4AnevQmGt6HGBnrHl7Q67Md2kqWS8xFman1dCXC7522cKtO4fR0SljjtLl?=
 =?us-ascii?Q?BjZuF6vuJnYGZgqjVXutt4F6+gGvDcc/7zgkeyFS94dOo/hRCs64LrhuFh0s?=
 =?us-ascii?Q?Rw=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 005d94bf-537b-48ab-7fbd-08dc34a57319
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2743.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2024 19:27:18.6723
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: w5D8LlTMd6iFLaf9faTXN/hya2FAkKbZUQ4M/RpO8EcpXl7z6ZYBRyKhPmmDf/0zy6H4+u8NSNuu6vsUCN6Tfg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5226

Track the number of times a CQE was expected to not be delivered on PTP Tx
port timestamping CQ. A CQE is expected to not be delivered if a certain
amount of time passes since the corresponding CQE containing the DMA
timestamp information has arrived. Increment the late_cqe counter when such
a CQE does manage to be delivered to the CQ.

Signed-off-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Reviewed-by: Dragos Tatulea <dtatulea@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
---
 .../device_drivers/ethernet/mellanox/mlx5/counters.rst      | 6 ++++++
 drivers/net/ethernet/mellanox/mlx5/core/en/ptp.c            | 1 +
 drivers/net/ethernet/mellanox/mlx5/core/en_stats.c          | 1 +
 drivers/net/ethernet/mellanox/mlx5/core/en_stats.h          | 1 +
 4 files changed, 9 insertions(+)

diff --git a/Documentation/networking/device_drivers/ethernet/mellanox/mlx5/counters.rst b/Documentation/networking/device_drivers/ethernet/mellanox/mlx5/counters.rst
index f69ee1ebee01..5464cd9e2694 100644
--- a/Documentation/networking/device_drivers/ethernet/mellanox/mlx5/counters.rst
+++ b/Documentation/networking/device_drivers/ethernet/mellanox/mlx5/counters.rst
@@ -702,6 +702,12 @@ the software port.
        the device typically ensures not posting the CQE.
      - Error
 
+   * - `ptp_cq[i]_lost_cqe`
+     - Number of times a CQE is expected to not be delivered on the PTP
+       timestamping CQE by the device due to a time delta elapsing. If such a
+       CQE is somehow delivered, `ptp_cq[i]_late_cqe` is incremented.
+     - Error
+
 .. [#ring_global] The corresponding ring and global counters do not share the
                   same name (i.e. do not follow the common naming scheme).
 
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/ptp.c b/drivers/net/ethernet/mellanox/mlx5/core/en/ptp.c
index fd4ef6431142..1dd4bf7f7dbe 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en/ptp.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en/ptp.c
@@ -169,6 +169,7 @@ static void mlx5e_ptpsq_mark_ts_cqes_undelivered(struct mlx5e_ptpsq *ptpsq,
 		WARN_ON_ONCE(!pos->inuse);
 		pos->inuse = false;
 		list_del(&pos->entry);
+		ptpsq->cq_stats->lost_cqe++;
 	}
 	spin_unlock(&cqe_list->tracker_list_lock);
 }
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
index 4b96ad657145..7e63d7c88894 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
@@ -2158,6 +2158,7 @@ static const struct counter_desc ptp_cq_stats_desc[] = {
 	{ MLX5E_DECLARE_PTP_CQ_STAT(struct mlx5e_ptp_cq_stats, abort) },
 	{ MLX5E_DECLARE_PTP_CQ_STAT(struct mlx5e_ptp_cq_stats, abort_abs_diff_ns) },
 	{ MLX5E_DECLARE_PTP_CQ_STAT(struct mlx5e_ptp_cq_stats, late_cqe) },
+	{ MLX5E_DECLARE_PTP_CQ_STAT(struct mlx5e_ptp_cq_stats, lost_cqe) },
 };
 
 static const struct counter_desc ptp_rq_stats_desc[] = {
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.h b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.h
index 12b3607afecd..03f6265d3ed5 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.h
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.h
@@ -461,6 +461,7 @@ struct mlx5e_ptp_cq_stats {
 	u64 abort;
 	u64 abort_abs_diff_ns;
 	u64 late_cqe;
+	u64 lost_cqe;
 };
 
 struct mlx5e_rep_stats {
-- 
2.42.0