Received-SPF: pass (google.com: domain of linux-kernel+bounces-79026-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Rahul Rameshbabu <rrameshbabu@nvidia.com>
To: Saeed Mahameed <saeed@kernel.org>,
	Leon Romanovsky <leon@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Richard Cochran <richardcochran@gmail.com>,
	Tariq Toukan <tariqt@nvidia.com>,
	Gal Pressman <gal@nvidia.com>,
	Vadim Fedorenko <vadim.fedorenko@linux.dev>,
	Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Przemek Kitszel <przemyslaw.kitszel@intel.com>,
	Ahmed Zaki <ahmed.zaki@intel.com>,
	Alexander Lobakin <aleksander.lobakin@intel.com>,
	Hangbin Liu <liuhangbin@gmail.com>,
	Paul Greenwalt <paul.greenwalt@intel.com>,
	Justin Stitt <justinstitt@google.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	Maxime Chevallier <maxime.chevallier@bootlin.com>,
	Kory Maincent <kory.maincent@bootlin.com>,
	Wojciech Drewek <wojciech.drewek@intel.com>,
	Vladimir Oltean <vladimir.oltean@nxp.com>,
	Jiri Pirko <jiri@resnulli.us>,
	Jacob Keller <jacob.e.keller@intel.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Jose Abreu <joabreu@synopsys.com>,
	Dragos Tatulea <dtatulea@nvidia.com>
Cc: netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org,
	Rahul Rameshbabu <rrameshbabu@nvidia.com>
Subject: [PATCH RFC net-next v1 4/6] net/mlx5e: Implement ethtool hardware timestamping statistics
Date: Fri, 23 Feb 2024 11:24:48 -0800
Message-ID: <20240223192658.45893-5-rrameshbabu@nvidia.com>
In-Reply-To: <20240223192658.45893-1-rrameshbabu@nvidia.com>
References: <20240223192658.45893-1-rrameshbabu@nvidia.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?31xSnhBdjgpB8+qsLJcHXZ40pZnHSJ2Sv9Pe1vPERiUu4k+fp27hEXqS0FwT?=
 =?us-ascii?Q?qvfVGO9JeRWR7fCKrjKIj1uHnzdVKGKYXv+uqNBiQ8+I18dzLW3ebWx7PyUO?=
 =?us-ascii?Q?C6JsJ5qKXZSqhlVGd9FKylQcyuLot8Bqp421IlT3H6ExkGJRhdCxRLGx+u1v?=
 =?us-ascii?Q?7RJZsq7ikNhXx2Npc8rtdCx7PyrhS7gJpiE2RW7Y2YVgdtwJiNW16tDAM7q3?=
 =?us-ascii?Q?hHgq/pLQd9pvHSlhqiOafcXoDguVn3fJwpjJFWrBL32Eu5wM6qKkCvQ4pLCP?=
 =?us-ascii?Q?MvTRehgN9+294BvGySpx6B8Pk9wJnyTCS4u2mqi6vZeGhgB2/qNxJYSEN15Z?=
 =?us-ascii?Q?u26sI+SLErwNzZytbtx2LeDP+vszzP6CnlnvwMZBK60F/RuhNb8xE9evKM69?=
 =?us-ascii?Q?Vho/XeBDZUdL0TR6pG/hIJeZepGbt3B6SbYZcgzWBEcem0ksYl2rLL6iy/MI?=
 =?us-ascii?Q?1gQuLlMhpNTUvUMzrE42hgd1HSxnmMyw/TPQ75mSnYGHd32IZXBxTf2ybV86?=
 =?us-ascii?Q?vG9X1f/UeRV3GEgoQxA23MG2x242LV17G8meK1humSpALL32YOrUhQL80mGn?=
 =?us-ascii?Q?hbjMIIRKUkocnkTc5/B/+9+OFZ/+o/PfgaubqhNzFH1GvIgO6odAQ00grOxv?=
 =?us-ascii?Q?uz9m4b+KkTC+Tq2EQI2hwVnO9svRQlp0bancvqWzUAG8pGlov+a5OmirW5t0?=
 =?us-ascii?Q?YDOxxbrE9nQaqZh36cUhEAOKr1nndV9ODDGkRRPJzU2WFkchkGsCPGXF4ZsA?=
 =?us-ascii?Q?DKa1tkoxwXh5i+shnB7p23HQcXfpkRvGWr+E9A6sO8S4q2WYDPQgAXwf+Qp7?=
 =?us-ascii?Q?SAfelR1fVzg/dWk83qfid+epbmPwu4eV7EAnHp0uze4wz+MHlDFqgpol0UuH?=
 =?us-ascii?Q?fvKXbq6nUlOezmOkxbhrY2uhXoYMItlc9GzPOneiCqnxxN7XCGi8iLSrY3EX?=
 =?us-ascii?Q?MHkBPDP0coS0OUWUthtIGL7EoSni+USvvLeIJLaY2eHyP1t2ts2gviHM0sBW?=
 =?us-ascii?Q?G+cvXIXq1TmtmtHq/FVnR9G8usgWeUTKkinM7goTbiJd6zjdiqeguUyOpj2G?=
 =?us-ascii?Q?ZHYHETb3hU3B6/mznryl7z9WD1EtWttQoVcnMOXW2+oGaJkEXBXKh4gX+zkI?=
 =?us-ascii?Q?i9ItQEr0hK145V+H/8/6L8W3mrYkN7/rD4vWbAoszGI+r80NY7wgLC3NRvtC?=
 =?us-ascii?Q?O2yiT5oV7us4FKUJvski3M3OyTMqaX/o0MNsfZcGe6zqYsF1TShYKJDCilEz?=
 =?us-ascii?Q?ehZDryiMaV0Y1yIH39QNln7FcphQ7hRSPVhekIFNSM93inTDTt3/05arQqpZ?=
 =?us-ascii?Q?kLSIqA+T1sE8Ip/L1WMv9zjLfH8+po8rYDSdRy9XhaLp3B13/mWPAypI34ti?=
 =?us-ascii?Q?Gc9Tl2lJqOXL9ENs0j0jL/lOOAWKamvjNuDaSlsh8f/qlEmSklh+fBHEo5sI?=
 =?us-ascii?Q?KxRP6hGND4JJlCVjrECX4DZ9ozWFlJdFBjzZmGw+zD1BU/4G2K8T2G6M3+xw?=
 =?us-ascii?Q?FpOEMrpUBqSYArBX0Qyaq+kX/vuL8f2u5BFeZvsLhw0O2aGLay7J8U5QDmq+?=
 =?us-ascii?Q?QcZAFDnXksZ2O5kfXTp9f7YwTN4cpjLbabY+ZnzDoVwsQVutDs8sJvT+eqfH?=
 =?us-ascii?Q?1Q=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 20fcb873-fedd-43cc-ec32-08dc34a574d0
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2743.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2024 19:27:21.5497
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BSgxeBfujNAzSnpmzD4q+Zbn5hEELeTosjR1v/Av9tD7azuLW8OHSiVm9f8WPQuoTIGpXF7LF7wCqA8GjwCWDQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6831

Feed driver statistics counters related to hardware timestamping to
standardized ethtool hardware timestamping statistics group.

Signed-off-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Reviewed-by: Dragos Tatulea <dtatulea@nvidia.com>
---
 .../ethernet/mellanox/mlx5/core/en_ethtool.c  |  9 +++
 .../ethernet/mellanox/mlx5/core/en_stats.c    | 68 +++++++++++++++++++
 .../ethernet/mellanox/mlx5/core/en_stats.h    |  2 +
 3 files changed, 79 insertions(+)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c
index cc51ce16df14..d3b77054c30a 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c
@@ -2381,6 +2381,14 @@ static void mlx5e_get_rmon_stats(struct net_device *netdev,
 	mlx5e_stats_rmon_get(priv, rmon_stats, ranges);
 }
 
+static void mlx5e_get_ts_stats(struct net_device *netdev,
+			       struct ethtool_ts_stats *ts_stats)
+{
+	struct mlx5e_priv *priv = netdev_priv(netdev);
+
+	mlx5e_stats_ts_get(priv, ts_stats);
+}
+
 const struct ethtool_ops mlx5e_ethtool_ops = {
 	.cap_rss_ctx_supported	= true,
 	.supported_coalesce_params = ETHTOOL_COALESCE_USECS |
@@ -2430,5 +2438,6 @@ const struct ethtool_ops mlx5e_ethtool_ops = {
 	.get_eth_mac_stats = mlx5e_get_eth_mac_stats,
 	.get_eth_ctrl_stats = mlx5e_get_eth_ctrl_stats,
 	.get_rmon_stats    = mlx5e_get_rmon_stats,
+	.get_ts_stats      = mlx5e_get_ts_stats,
 	.get_link_ext_stats = mlx5e_get_link_ext_stats
 };
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
index bc31196d348a..836198445726 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
@@ -1155,6 +1155,74 @@ void mlx5e_stats_rmon_get(struct mlx5e_priv *priv,
 	*ranges = mlx5e_rmon_ranges;
 }
 
+void mlx5e_stats_ts_get(struct mlx5e_priv *priv,
+			struct ethtool_ts_stats *ts_stats)
+{
+	enum ethtool_ts_stats_layer layer;
+	struct mlx5e_ptp *ptp;
+	bool tx_ptp_opened;
+	int i, j;
+
+	mutex_lock(&priv->state_lock);
+
+	tx_ptp_opened = priv->tx_ptp_opened;
+
+	/* NOTE: this needs to be changed whenever ethtool timestamping
+	 * layer selection is implemented.
+	 */
+	if (ts_stats->layer == ETHTOOL_TS_STATS_LAYER_ACTIVE)
+		layer = tx_ptp_opened ? ETHTOOL_TS_STATS_LAYER_PHY :
+					ETHTOOL_TS_STATS_LAYER_DMA;
+	else
+		layer = ts_stats->layer;
+
+	switch (layer) {
+	case ETHTOOL_TS_STATS_LAYER_PHY:
+		if (!tx_ptp_opened)
+			return;
+
+		ptp = priv->channels.ptp;
+
+		ts_stats->pkts = 0;
+		ts_stats->err = 0;
+		ts_stats->late = 0;
+		ts_stats->lost = 0;
+
+		/* Aggregate stats across all TCs */
+		for (i = 0; i < ptp->num_tc; i++) {
+			struct mlx5e_ptp_cq_stats *stats = ptp->ptpsq[i].cq_stats;
+
+			ts_stats->pkts += stats->cqe;
+			ts_stats->err += stats->abort + stats->err_cqe;
+			ts_stats->late += stats->late_cqe;
+			ts_stats->lost += stats->lost_cqe;
+		}
+		break;
+	case ETHTOOL_TS_STATS_LAYER_DMA:
+		/* DMA layer will always successfully timestamp packets. Other
+		 * counters do not make sense for this layer.
+		 */
+		ts_stats->pkts = 0;
+
+		/* Aggregate stats across all SQs */
+		mutex_lock(&priv->state_lock);
+		for (j = 0; j < priv->channels.num; j++) {
+			struct mlx5e_channel *c = priv->channels.c[j];
+
+			for (i = 0; i < c->num_tc; i++) {
+				struct mlx5e_sq_stats *stats = c->sq[i].stats;
+
+				ts_stats->pkts += stats->timestamps;
+			}
+		}
+		break;
+	default:
+		break;
+	}
+
+	mutex_unlock(&priv->state_lock);
+}
+
 #define PPORT_PHY_STATISTICAL_OFF(c) \
 	MLX5_BYTE_OFF(ppcnt_reg, \
 		      counter_set.phys_layer_statistical_cntrs.c##_high)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.h b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.h
index 3c634c5fd420..7b3e6cf1229a 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.h
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.h
@@ -126,6 +126,8 @@ void mlx5e_stats_eth_ctrl_get(struct mlx5e_priv *priv,
 void mlx5e_stats_rmon_get(struct mlx5e_priv *priv,
 			  struct ethtool_rmon_stats *rmon,
 			  const struct ethtool_rmon_hist_range **ranges);
+void mlx5e_stats_ts_get(struct mlx5e_priv *priv,
+			struct ethtool_ts_stats *ts_stats);
 void mlx5e_get_link_ext_stats(struct net_device *dev,
 			      struct ethtool_link_ext_stats *stats);
 
-- 
2.42.0