Received-SPF: pass (google.com: domain of linux-kernel+bounces-79041-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <2c07415c-78fa-460b-8aa5-9a40536ce339@amd.com>
Date: Fri, 23 Feb 2024 13:39:05 -0600
User-Agent: Mozilla Thunderbird
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH 4/4] selftests/resctrl: Skip the tests if iMC/UMC counters
 are unavailable
Content-Language: en-US
To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc: fenghua.yu@intel.com, Reinette Chatre <reinette.chatre@intel.com>,
 shuah@kernel.org, LKML <linux-kernel@vger.kernel.org>,
 linux-kselftest@vger.kernel.org,
 =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= <maciej.wieczor-retman@intel.com>,
 peternewman@google.com, eranian@google.com
References: <cover.1708637563.git.babu.moger@amd.com>
 <f5c74072d96b57b10a66c01381139de453187327.1708637563.git.babu.moger@amd.com>
 <a13f6e21-9929-a16d-bda1-533eaed8f875@linux.intel.com>
From: "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <a13f6e21-9929-a16d-bda1-533eaed8f875@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bFNqeHdQWnZPK0YvT3F4TTJSb0E2MHlvb1dITjFEZVV6TDRENDZlbS9DaUIx?=
 =?utf-8?B?aVJramtmd09rMDhhTlJtZlNZRzdZdXJyZlZmTnNTd0JHclAzd3cxSy9EQW81?=
 =?utf-8?B?VUNzcmUzdlo5WmVxNFFGblpNREdUdlpEdGkzdWgrbkdWZCt2bFhPQStFUVJw?=
 =?utf-8?B?cGFKRlVJakF3aURQTWR1ZUNLMGU1RDlyWlZ6Ly9IZ0t2YnVmVmRLOVFQNWM0?=
 =?utf-8?B?bnFuOERPQWU0YzFobEQrUDJESTFyRTN0S2NYd0NXQlkxNUpkUk9laFozQVZo?=
 =?utf-8?B?N1lsMHpwNEhwWCtCRG5uVXNIenN0UU5lQkdqYjA5NktYOHV1NE1kUytBaFNk?=
 =?utf-8?B?NVFVckpTclB0djk4eEJHV01qK0o0aDQ2VTdiallTeldDUi9IdkU2TGNDcklY?=
 =?utf-8?B?RGtrM3RCd1NzSEN1Tkc0ZzRvQVpRUmxWdm1sS2RyVE5qbytoK3JwbGhkSWsx?=
 =?utf-8?B?bVhPZjFyeFg4SkVOUHpXengyUStRZEJvOC9FY2xiWDJIUmluTDltVTVtNE9D?=
 =?utf-8?B?aE80dFNjS05tUWdZL3lPUGIrOXpGRU52cStybVdFODdVV3ZWSi8wcFJ5bEdh?=
 =?utf-8?B?T2lJMmwwUUo3N25YRUZsc2ROUFFPdm03aXY4Vzc4amtoWWRITzhLUDV6SlEv?=
 =?utf-8?B?OXkzdmRaSDFWcEd1VGNLaEZ0MGJldmhPSjY2SFlzbFovU3BaU3pFaXcxbkhi?=
 =?utf-8?B?ZEQrRWYxazAyZnlEVm5Qa2ZNeWxoYVY1TE5ObGVyV1VPdWQ4TTI5MDNrdXUx?=
 =?utf-8?B?QVphN282eGtqaCtwQWhsUlJWM2NnWlVkMEgzd0NLTTBiVzRCSFhrMFZqaUtv?=
 =?utf-8?B?R3hDMVBoVHFmRWZ0Y2lLNUd4YXIwME9NWkxqZUdTSzlCbS9qcDZmTm84YzdW?=
 =?utf-8?B?YlFJSUhEaUM3VHlmKy9sa3o2RzY4Mis1TG55WFExRWZDanlMUkVPZVRuWlZP?=
 =?utf-8?B?eEdxSkRCdm9QT2xyS1NVUzlmY1RkM0pnSlB0aTUwN2ZyckYvSUJJcXlDTmpX?=
 =?utf-8?B?RmsrdmpkdGpSMHBLa1h0NTBoblJWaGNFRnBKc0k5TlZUbXV3OHhNTEsvT2Zw?=
 =?utf-8?B?U09wSXl5Ymc3RWI5S1dSVUxLWHNyYUt4RDFFTWVYaDE3NUl5MW91Zk8zeWk0?=
 =?utf-8?B?anRnTkxObk1oQ3o5Nmc2Q05vNTZOU01DZ1poVUh2cXR1RzlwTVE4czNKTUZz?=
 =?utf-8?B?ZVI5WWgzcUFHN2VWSE1XRVpGMGJ4N1hzYTNnMjhDYlE0QlJhTS9KbHBDdC9j?=
 =?utf-8?B?TnpLd1BvZVBPK2c4bUIyUWZLalgwYzVPTGgwekxLVkcycE9VMW9heXVudTd0?=
 =?utf-8?B?M1NpRnVaQUF0MmpBLzJneDlBby9kWlhKZldHaHNyKzNNNGpVZUFDRkRvSDl2?=
 =?utf-8?B?dm5JWTNGNGlvRHJyUU9GTGo5cTQwR1RKOG5JVzJWS0JPM2xicGZjTG5KTXQz?=
 =?utf-8?B?YTFUYmZtbWZUY2VCT3JHeVBDbURtZGdGV1d1dlJMTDYwTXNkY29VTm5aMUhy?=
 =?utf-8?B?cXZ4cjcyQmY1MTdUNFpqMmlOb2VFdnBUYUlhdy96WVNtRXhGWmsrTTVJVTI0?=
 =?utf-8?B?OG11WVpaZmNXcnZTaDdKeDQ5UEVuWVdZdnBpY0JXZjIwRlJKYitzWitGSUZW?=
 =?utf-8?B?Vmk2OUY0VzFsRjRtZGl2a3Uwa2JPYmF6eTBpamk4aG9tV3N6cThHU0NmVDJO?=
 =?utf-8?B?Mk1BcnFrOG01T2pyNmVGMGdsT0ZOcC9vL05Db3N0TWRRdHp1RDVFRHZSUEZh?=
 =?utf-8?B?bzVrRVM2VEV4VjhrSStScGhhaFlCSS9xc2hlanN1VnFMcTJ4MUVqNDhhbW5P?=
 =?utf-8?B?VmgxRlljWFhDeUMyOVJOMDByMXR0cUFDOW5DV0VNK2RPOW1ZQkpYbHhFWkxF?=
 =?utf-8?B?L21GZkUxalgvbUU5V00xZklFY0JkUy81ZUJaNmpOMXVGMmlTaXpqOG5aWUVL?=
 =?utf-8?B?WUFtYVpxMzdUYU1rUUJrS3VEUldKeGRTNFM0Q2xXL0J4Rk54dkdrMSs5VG1Z?=
 =?utf-8?B?bi8rMHh4SGxtajV4MjEyZW9BeERvbTJpczdjOEVRaDN4Z2xqaGJMNUtEU2Fv?=
 =?utf-8?B?RTlwaW1obEtNdzFOODZnNUlMbWZBTCtkaVBXQkdmUU9KeGoyQVF0UXNYb1pm?=
 =?utf-8?Q?41TI=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4395304b-ebd9-4c71-0532-08dc34a71a30
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2024 19:39:08.4859
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GrZI+qFMSFQDliXcccvg/sG4DxihbJYH2Lqy60ep4weeEeHzOcbG65E1y+CDyRQG
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6315

Hi Ilpo,

On 2/23/24 04:56, Ilpo Järvinen wrote:
> On Thu, 22 Feb 2024, Babu Moger wrote:
> 
>> Older systems do not support UMC (Unified Memory Controller) perf counters.
>> Skip the tests if the system does not support UMC counters.
>>
>> Signed-off-by: Babu Moger <babu.moger@amd.com>
>> ---
>>  tools/testing/selftests/resctrl/resctrl.h       |  1 +
>>  tools/testing/selftests/resctrl/resctrl_tests.c | 10 ++++++++++
>>  tools/testing/selftests/resctrl/resctrl_val.c   |  4 ++--
>>  3 files changed, 13 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/testing/selftests/resctrl/resctrl.h b/tools/testing/selftests/resctrl/resctrl.h
>> index a33f414f6019..5c2556af0649 100644
>> --- a/tools/testing/selftests/resctrl/resctrl.h
>> +++ b/tools/testing/selftests/resctrl/resctrl.h
>> @@ -116,5 +116,6 @@ int show_cache_info(unsigned long sum_llc_val, int no_of_bits,
>>  		    size_t cache_span, unsigned long max_diff,
>>  		    unsigned long max_diff_percent, unsigned long num_of_runs,
>>  		    bool platform, bool cmt);
>> +int get_number_of_mem_ctrls(void);
>>  
>>  #endif /* RESCTRL_H */
>> diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testing/selftests/resctrl/resctrl_tests.c
>> index 231233b8d354..5423882529ec 100644
>> --- a/tools/testing/selftests/resctrl/resctrl_tests.c
>> +++ b/tools/testing/selftests/resctrl/resctrl_tests.c
>> @@ -98,6 +98,11 @@ static void run_mbm_test(const char * const *benchmark_cmd, int cpu_no)
>>  
>>  	ksft_print_msg("Starting MBM BW change ...\n");
>>  
>> +	if (get_number_of_mem_ctrls() < 0) {
>> +		ksft_test_result_skip("Unable find iMC/UMC counters!\n");
>> +		return;
>> +	}
>> +
>>  	if (test_prepare()) {
>>  		ksft_exit_fail_msg("Abnormal failure when preparing for the test\n");
>>  		return;
>> @@ -124,6 +129,11 @@ static void run_mba_test(const char * const *benchmark_cmd, int cpu_no)
>>  
>>  	ksft_print_msg("Starting MBA Schemata change ...\n");
>>  
>> +	if (get_number_of_mem_ctrls() < 0) {
>> +		ksft_test_result_skip("Unable find iMC/UMC counters!\n");
>> +		return;
>> +	}
>> +
>>  	if (test_prepare()) {
>>  		ksft_exit_fail_msg("Abnormal failure when preparing for the test\n");
>>  		return;
> 
> This also needs rebasing and adaptation to the generic test framework.

Looks like I need to wait for your patches to merge first.
Thanks
Babu Moger