Received-SPF: pass (google.com: domain of linux-kernel+bounces-79070-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <9055ee27-0860-4701-9ae9-801c25cf2aef@intel.com>
Date: Fri, 23 Feb 2024 12:00:40 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 1/2] x86/resctrl: Rename pseudo_lock_event.h to trace.h
Content-Language: en-US
To: Haifeng Xu <haifeng.xu@shopee.com>
CC: <fenghua.yu@intel.com>, <babu.moger@amd.com>, <peternewman@google.com>,
	<x86@kernel.org>, <linux-kernel@vger.kernel.org>
References: <20240221092101.90740-1-haifeng.xu@shopee.com>
 <20240221092101.90740-2-haifeng.xu@shopee.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240221092101.90740-2-haifeng.xu@shopee.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z0NvQjFLT1FrVEQwS3RNRC9tVEJTLzFnaEFMKzVTWm1yQzAxeTZYRXNFTk9C?=
 =?utf-8?B?UEprUEdEbTZFTmEzWmNRa3JiQXY4aTVmVXhSUFI4SlNWM2UzMk4xSWtmaTZ3?=
 =?utf-8?B?YWU4ZVdOSXdrWU5KTWI4Y3BZV1Y1NkJsdkYyRnVHbUU1VEdNRG1Pa0tDWmhS?=
 =?utf-8?B?OENsUVZWQkxmdmJVM1gwekc3LzFGcTdIZjFvTThPNmcyd1h6NWNwUVRaQ0VY?=
 =?utf-8?B?VWZpV29yL3h1RFoyTmdleFVrclZPRlBhMGRkV0t2alYxVHpkeHA1QytxdVJJ?=
 =?utf-8?B?WTFUajFuMXVlRUxpT0VVeHVMeTJOK24zMXlSRGlvTzd4Q0wzc0dwcVNOVmg1?=
 =?utf-8?B?MWVNNUYvbllhVFNuY0NQTUp6N0Jvem92YmgyRlFUTGpQb25IdnF3TmNqZjRh?=
 =?utf-8?B?YzEybVBpWEtEQTRHUlFjWS9JaXJObm0rd2xjWVoxcHRZbHBicVFGaDJOWW5x?=
 =?utf-8?B?N0ZGZGtMdXZ3UC9mdkc5T3A2WktFemVCZkRhUVZCeS9MOFBZZ2lzWTRKV2pK?=
 =?utf-8?B?TU1EZGdEdlhjTHp3cHVIUThmcjNIM0JXZ1RmS2ZHZFpHNU1qcHNKTzdNalFS?=
 =?utf-8?B?TTRMZ05pOXAzeGhLQUs2bnJhRTc5VVd0V1NIWUgxWTFXQy8rck41U1hQU3JT?=
 =?utf-8?B?S0V1MUlwWkYvQk92WFRQd2hZVlVpZkRRNkp3MXJWMGU0ZjFrcVdQWWNaaVBN?=
 =?utf-8?B?c1N5Vm9tTEtiTUJmdVp0MDdkbEMrTE5STXFrRWhCKzE5b0RyQjRmTU83UUFY?=
 =?utf-8?B?N2pidktrbmlsOEpuM2wrdWtneG1QUXFTdEhORVc0VEtWUU1VcHdsZkNDRU5L?=
 =?utf-8?B?UFl0UlR6c08wZGJPUWlTbnV4YVgvMU44OHZwZ1UvdlFsNWQrSWRvQlNQMGht?=
 =?utf-8?B?dmNaMlJMclB1OU12OEpaYldpN3RtalRINVFlWEZZQWNyQ0Ivckc2TXhDbDY1?=
 =?utf-8?B?K091c0VhcmQzNDNhR1g0a2lCYlJRQTdLaSs3UStVTDdCOXBaTUxhaGlEMGx1?=
 =?utf-8?B?bzlTMllqT2lJbTlodWQwU1FleEl0YUZyazJaV05HRTV3UUlOd0xxYWJJcE81?=
 =?utf-8?B?ME1rOTVmNGhqc3ZlaVVlTVA1RG9HMDdpMkVxQUp4cnRSWWJrQXF2YUM1WDc3?=
 =?utf-8?B?ZFB2QW51WnpmSGhyeXRTZ1VmRUU1MWdOcDVtNExjWllKWWlnK1BCZ1ZCNEdx?=
 =?utf-8?B?ME0yWmtxSjBNNzYwdmhQS2V0NytXdXpWbEl6UWlZMUMrdG5kM3BFaXoxcmdR?=
 =?utf-8?B?eVNYMy9VRGdJM3dtek1TQXlaS01xVHNNemFXSUxzMDZ2b2FtTGZid3lEQXly?=
 =?utf-8?B?d1RSK1ZlSE1TOWZQbEpzU0JOc0hNYStlR2xnSkdNQmRiNDRMSHp3UkhySHUy?=
 =?utf-8?B?clJSeXdBYmhscWUyV2tjUVVYZXJ1K1M0bDBFQWhSdlRLM0tyRVFLY3JCQUxu?=
 =?utf-8?B?VmJsRFVoR1N0Rmc3M3psRU0yNWcvZUxMR0FDaUczcmIyVy9rbk4xaE11SGVp?=
 =?utf-8?B?MzZNVTNtMGQ0TjR5c3c3blVZbmZkdHFGbXN6R3BTdnFkMlFtcFVOT0NxbXFS?=
 =?utf-8?B?Y2ZwQU5wMzFvcytOVjJPb0xrVXRtZEZQc0s1UHcrTnpaVmRPNTFLMmZUd3JH?=
 =?utf-8?B?ay9TdmUzNUMrMVM2UUF3Vkk5cHEzNFl0bkdMcmhpQjV6RXJEaEFlWm8zZ0xq?=
 =?utf-8?B?Uy9jaWg2OVV0Uk9HK3pEVTZjU29aZ0VUdmZzajNkR0VnVFJ0ZmtXMi91VlU3?=
 =?utf-8?B?b1pZRnNEdisyNE1sLzBHT2RoRGpacllDVUY5Ym1qN1BPOHBWaFR4aVUvcy9s?=
 =?utf-8?B?VnZhN1NLeGVKUXN1ODd2SHIreXBobVRFeHU3ME5NRTBzTXB3MEZqaHBqT3A4?=
 =?utf-8?B?OUhMUkFlOEpaQjVndENIemlMSktEbkF2K2VrVDBBelkySHEvSjcyekh1RHkx?=
 =?utf-8?B?VlBmdHMzT2RNUkhVVnJSZlRSMlhValhJN0I4ZW8wZFV1SWQ4S0ZCUjRRcERF?=
 =?utf-8?B?SFB2bXBlOGoyMS80b2lGMU9SbFJSSkt0enBGbUNMS2tVT1dabE1IbDZTeURw?=
 =?utf-8?B?R0lQNS9COEJzOHlyOWRTZkpwak5DbnNkL0dRUnkrL0crenlwYjZCUkVxbk5S?=
 =?utf-8?B?SHI5MDZLN3ZXcEw2eDBSdDN1U25lU2hvMXN1QUV0b0lTU1owUWdsSHF0MEJn?=
 =?utf-8?B?a2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0628b9af-c569-4b27-8e36-08dc34aa1dfb
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2024 20:00:43.4864
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: w+wok9pQuRC2Od29yqzRYY1Va7tpsx/CVGz3ClwGuEe7DPCOuejJ7d9sd1jZQM1SYlZBsknsr6tfu/uSql67nAOoJIigCaAa6mHMClQJyPM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5456
X-OriginatorOrg: intel.com

Hi Haifeng,

On 2/21/2024 1:21 AM, Haifeng Xu wrote:
> Now only pseudo-lock part uses tracepoints to do event tracking, but
> other parts of resctrl may need new tracepoints. It is unnecessary to
> create separate header files and define CREATE_TRACE_POINTS in different
> c files which fragments the resctrl tracing.
> 
> Therefore, the new tracepoints should be placed in the same header file,
> and the header file needs a more generic name.

Please do stick with imperative mood [1]. For example, something like:
"Give the resctrl tracepoint header file a generic name to support
 its use for tracepoints that are not specific to pseudo-locking."

(Please feel free to improve.)

Reinette

[1] https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#changelog