Received-SPF: pass (google.com: domain of linux-kernel+bounces-79151-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 23 Feb 2024 21:56:56 +0100
From: Pavel Machek <pavel@ucw.cz>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Duje =?utf-8?Q?Mihanovi=C4=87?= <duje.mihanovic@skole.hr>,
	linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
	Lee Jones <lee@kernel.org>
Subject: Re: [PATCH v2 1/1] leds: expresswire: Don't use "proxy" headers
Message-ID: <ZdkGmE2HFxXpIonR@duo.ucw.cz>
References: <20240223203010.881065-1-andriy.shevchenko@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="2lTx/hEuWHPoqeWW"
Content-Disposition: inline
In-Reply-To: <20240223203010.881065-1-andriy.shevchenko@linux.intel.com>


--2lTx/hEuWHPoqeWW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> Update header inclusions to follow IWYU (Include What You Use)
> principle.
>=20
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> v2: added one more missing header
>  drivers/leds/leds-expresswire.c  | 4 ++++
>  include/linux/leds-expresswire.h | 4 +++-
>  2 files changed, 7 insertions(+), 1 deletion(-)
>=20

> diff --git a/include/linux/leds-expresswire.h b/include/linux/leds-expres=
swire.h
> index 3c61902ccac8..a422921f4159 100644
> --- a/include/linux/leds-expresswire.h
> +++ b/include/linux/leds-expresswire.h
> @@ -8,7 +8,9 @@
>  #ifndef _LEDS_EXPRESSWIRE_H
>  #define _LEDS_EXPRESSWIRE_H
> =20
> -#include <linux/gpio/consumer.h>
> +#include <linux/types.h>
> +
> +struct gpio_desc;

If include tweak means you need to declare struct, is it ian
improvement?

BR,
								Pavel
--=20
People of Russia, stop Putin before his war on Ukraine escalates.

--2lTx/hEuWHPoqeWW
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCZdkGmAAKCRAw5/Bqldv6
8kAvAJ0UQUgcqts8MRgtY+0Rml1psMSvWQCgnUAbxDekDN5xR7B5siUnzJgeMIU=
=ENYA
-----END PGP SIGNATURE-----

--2lTx/hEuWHPoqeWW--