Received-SPF: pass (google.com: domain of linux-kernel+bounces-79158-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <4c94d725-a903-4979-bcc6-9353e0869cd7@intel.com>
Date: Fri, 23 Feb 2024 13:00:10 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH RFC net-next v1 0/6] ethtool HW timestamping statistics
To: Rahul Rameshbabu <rrameshbabu@nvidia.com>, Saeed Mahameed
	<saeed@kernel.org>, Leon Romanovsky <leon@kernel.org>, "David S. Miller"
	<davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski
	<kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Jonathan Corbet
	<corbet@lwn.net>, Richard Cochran <richardcochran@gmail.com>, Tariq Toukan
	<tariqt@nvidia.com>, Gal Pressman <gal@nvidia.com>, Vadim Fedorenko
	<vadim.fedorenko@linux.dev>, Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit
	<hkallweit1@gmail.com>, Przemek Kitszel <przemyslaw.kitszel@intel.com>, Ahmed
 Zaki <ahmed.zaki@intel.com>, Alexander Lobakin
	<aleksander.lobakin@intel.com>, Hangbin Liu <liuhangbin@gmail.com>, "Paul
 Greenwalt" <paul.greenwalt@intel.com>, Justin Stitt <justinstitt@google.com>,
	Randy Dunlap <rdunlap@infradead.org>, Maxime Chevallier
	<maxime.chevallier@bootlin.com>, Kory Maincent <kory.maincent@bootlin.com>,
	Wojciech Drewek <wojciech.drewek@intel.com>, Vladimir Oltean
	<vladimir.oltean@nxp.com>, Jiri Pirko <jiri@resnulli.us>, Alexandre Torgue
	<alexandre.torgue@foss.st.com>, Jose Abreu <joabreu@synopsys.com>, "Dragos
 Tatulea" <dtatulea@nvidia.com>
CC: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-doc@vger.kernel.org>
References: <20240223192658.45893-1-rrameshbabu@nvidia.com>
Content-Language: en-US
From: Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20240223192658.45893-1-rrameshbabu@nvidia.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Mkw3dG9hZUUwUmRJRXhXeHBEaHY5M25EdldJb3BSQXI0K2dFWDBNcHFlTmhS?=
 =?utf-8?B?T0tLSU1tVTJiamtPajV1eFZNTGZqZ0J4ZVdzdC8yRVBpcXZoOWdOS0lTMlpG?=
 =?utf-8?B?d1R5TnRuUkIyWHV0WXB3blNjM3h6eDZ3UVdYdzZVb3FnekdIT0lpMnZyME55?=
 =?utf-8?B?ZDNTMzJkRkthK3ZhWE1vcWNYdk1kdm4wSmMySUIxR0RPTGlXYnBWZjhZUG8r?=
 =?utf-8?B?ZXkrMVU3QlNHNVhURXptNFFFZmdjdjFxODB1Qkt5cXRhRk9pRzVaUDdOdGcw?=
 =?utf-8?B?YlE4M3FjdzdrTTM1R3R0SkVSZmNUaTV2dEN2UzhsL3JoNUtkWVhyY3FqV1VY?=
 =?utf-8?B?WVNZQjVHeis0ZFo2SGJJRVhDaXBjcGtjd3dxZ2lSZ2YydDhZa0FwR3djZjEz?=
 =?utf-8?B?Z3orNkdLNDQ4NlRYK1ZIMVBnQTBibkVTeDZtaEtoUm1pTUswMm5hTkpJbzlH?=
 =?utf-8?B?ZVFPT0Z5bWxoTzdFT0F5R3JLZEJ5bS9Rbmw0VTZrNUsvSkI1Y0ZCQmhTMG9B?=
 =?utf-8?B?NzRuRzJ6eGplK0lCYnFkM2x1NmNaNEJoU3FFMWNVN3B6bUhCbFJKK1JJalpu?=
 =?utf-8?B?UEZXRWpUaUNmc3NheVFIVHpXSVBSSmF3cFlBNFlITktBbHNMWlEzTXc0UlZv?=
 =?utf-8?B?cVR4UzhiaDdhTVdQQm1GckNSNjVseUtlL09sWXp5ajRzbXo0cnh6NVoyWE5k?=
 =?utf-8?B?aGE4TGt2bmRtQUVYWnRtTk1sWnhlbHFMQXc1UU0ybm9Ra3d6WmtWMC9sNzQ0?=
 =?utf-8?B?cEFiZ2NmNFdUeWhBelFWTTBUbUZ0RVoramRraVlLaEs0eDdHYlNNWlFoMEdh?=
 =?utf-8?B?MTY5TW5VeWwxWUFrTWFMOHZ5OEYzN3B4eHNFQ2x2QnFPTHRtYkZBYXVObGVa?=
 =?utf-8?B?aEx0QUQ1U2xjV1l4TVZHUHVIMjd6aDc4MEc3MGMvaldTQ1lFSm1ORU5LQlBV?=
 =?utf-8?B?QU0raVl6dTBpemRlaWlCc0FOcTViM3pIVlFnS2hQN1pwd0krVHhtRWs0dFlT?=
 =?utf-8?B?UGtCYmZJTFFHNXJxRENGeU53TWlPRGZNVW43UktCS0JObi9QWGFzVDBHWXkw?=
 =?utf-8?B?dkRXa2k5Y1p0M3dWZW5pV1RkNWRhWE5ESkNvdHVmKzgvc1J2N09DMjdZUXhL?=
 =?utf-8?B?MnNsM3FyYU9tOERyTGpPQ29HbEJDakJCeFBHeEZlQU9iQ1g4ZzQ0NVNWWFd5?=
 =?utf-8?B?QlFqSmZ5NENPanZ0WjRvcGFNWG9xUWZQTHc0UVloSmFtU3IvdVo0T0RYWDJv?=
 =?utf-8?B?Sk5yNWkvQlBvNkxzbm9WM0RTeDVqYm1NVXd5ZGh6NDk5czQ0VWExUUN2bG9Z?=
 =?utf-8?B?UUVuNjRMOVN5UTIyYkVYbjRmVnZsa2VZenIzdHFJWU5yUW1CK3hLNzlXWjdR?=
 =?utf-8?B?bFFOcm9QMTdoZVBWT0xjaFNjRURHdkVrVFZ3SnJXMXJqdEI5bGtqMHdVa1Y0?=
 =?utf-8?B?Q3pqSWtBZkpLcnhCZHBuQ1AyekNLakdiaThtZk9od1d3TjQvcDRWbkxLVkRo?=
 =?utf-8?B?dGdDRkxGZC9FK1R3VlpjdDk0UWVsQm5qVUZmTStNYWhxSjdPeWtNVVhLR1k2?=
 =?utf-8?B?aFdaU1V5aHZsRitxOWtPdXlMdlpsejB3WkJEL2NpcGJ5WjEzdCtMdUlMNWJK?=
 =?utf-8?B?aFp6OCt5a3VHL1FodGNTRTREN1VWUURNbkZxRjE2QVROc1Y4K0IrUGc5Vkpr?=
 =?utf-8?B?ejRiOEtQOFI5R3V0YklMWG5UU1VoRVBuNXN1cmJiTmJSeEtsSTR3STBvTE0w?=
 =?utf-8?B?SkVCNUFZemd6d1Rvdit4d1BtOGJ6Z01jYTVuWkY1bDVHTDVjekhnVnkwOUFa?=
 =?utf-8?B?WG5WajFIbVd3Z0FVM2I5MnYycDQza3daOTlNMktWdURrM3pQTGk3OHl0QTJo?=
 =?utf-8?B?RGs0ejROUFRyKzN5aGxnZ2FXMWdwZmpZc3hGZVZrUllVWlNURldjTG5iRGR0?=
 =?utf-8?B?TnBvT2V5RDNMZjZQM1pHbDVKSHh0NmZXclVubHNja2M5Mms3b29zbnpWSVEx?=
 =?utf-8?B?aVkzNlVPaTl6RVdlWnVNWmpyTFRQcWVZSi9zNTJNMmdHS2R5UkgweUd6S0lY?=
 =?utf-8?B?N1BIRGR1UUdwbWNkelBTYWZyazE0Mm1qOStkZE5KeUpFdXRvdzdYWStHZzk4?=
 =?utf-8?B?alErNTAwWWZicmNlTThEMjB2UWN6NkFsYnhaTGl6R3ZLTUZTaDBXdzV2bXl6?=
 =?utf-8?B?dGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7d771c86-2f9a-4301-c016-08dc34b26e7f
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2024 21:00:14.3547
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1livH4CdwJ4gx8oDPUON8i+8EZye6+veGSu6aDAQwgV+yctpIeP8KevKORzDQQa8fOQ4xvTNycP1XDD0BfaH3AHdoa0xJ0Fb723Tn+oKSxo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6753
X-OriginatorOrg: intel.com


On 2/23/2024 11:24 AM, Rahul Rameshbabu wrote:
> The goal of this patch series is to introduce a common set of ethtool statistics
> for hardware timestamping that a driver implementer can hook into. The
> statistics counters added are based on what I believe are common
> patterns/behaviors found across various hardware timestamping implementations
> seen in the kernel tree today. The mlx5 family of devices is used as the PoC for
> this patch series. Other vendors are more than welcome to chim in on this
> series.
> 
> Statistics can be queried from either the DMA or PHY layers. I think this
> concept of layer-based statistics selection and the general timestamping layer
> selection work Kory Maincent is working on can be converged together [1].
> 
> [1] https://lore.kernel.org/netdev/20240216-feature_ptp_netnext-v8-0-510f42f444fb@bootlin.com/
> 

Makes sense! I like this direction, I had meant to work on this for the
Intel parts, but got sidetracked by other tasks. I look forward to
seeing what you've done here.