Received-SPF: pass (google.com: domain of linux-kernel+bounces-79180-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <6e0a725f-3bd8-4e14-afda-860f1e4c1dc5@intel.com>
Date: Fri, 23 Feb 2024 13:08:34 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH RFC net-next v1 5/6] tools: ynl: ethtool.py: Make tool
 invokable from any CWD
Content-Language: en-US
To: Rahul Rameshbabu <rrameshbabu@nvidia.com>, Saeed Mahameed
	<saeed@kernel.org>, Leon Romanovsky <leon@kernel.org>, "David S. Miller"
	<davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski
	<kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Jonathan Corbet
	<corbet@lwn.net>, Richard Cochran <richardcochran@gmail.com>, Tariq Toukan
	<tariqt@nvidia.com>, Gal Pressman <gal@nvidia.com>, Vadim Fedorenko
	<vadim.fedorenko@linux.dev>, Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit
	<hkallweit1@gmail.com>, Przemek Kitszel <przemyslaw.kitszel@intel.com>, Ahmed
 Zaki <ahmed.zaki@intel.com>, Alexander Lobakin
	<aleksander.lobakin@intel.com>, Hangbin Liu <liuhangbin@gmail.com>, "Paul
 Greenwalt" <paul.greenwalt@intel.com>, Justin Stitt <justinstitt@google.com>,
	Randy Dunlap <rdunlap@infradead.org>, Maxime Chevallier
	<maxime.chevallier@bootlin.com>, Kory Maincent <kory.maincent@bootlin.com>,
	Wojciech Drewek <wojciech.drewek@intel.com>, Vladimir Oltean
	<vladimir.oltean@nxp.com>, Jiri Pirko <jiri@resnulli.us>, Alexandre Torgue
	<alexandre.torgue@foss.st.com>, Jose Abreu <joabreu@synopsys.com>, "Dragos
 Tatulea" <dtatulea@nvidia.com>
CC: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-doc@vger.kernel.org>
References: <20240223192658.45893-1-rrameshbabu@nvidia.com>
 <20240223192658.45893-6-rrameshbabu@nvidia.com>
From: Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20240223192658.45893-6-rrameshbabu@nvidia.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dlF5Q25xOUZjN24zY1JqelNSOUZUM1lvUFBVSnBCMTdNYTcycTlhc0VrdmlR?=
 =?utf-8?B?NVp1bXM0Q0RzUkl6d3U0RDF3ZmRKelNNYzBNdU53Vk5JOFhOaWlDd3ZDQzVE?=
 =?utf-8?B?ZVNFcGlWT3lDSHFDN29obzlyWE5jc2dNWXJNUldYWkJmcENYd2M4dW9rdm84?=
 =?utf-8?B?bUtQZzBDb2RVb0ltcUdEbnRrdmxXeDY2MlovMTh4UDFxYS9WcmI1a3dMNVRa?=
 =?utf-8?B?MW1IWkZpWEo5THhOQ0V4R3BLM2d5S21tZDVTRCtuTFQxM25nRVN6WnlHQmMy?=
 =?utf-8?B?bzZhRGNxZWdWSVkzL0hwbmkycW9WRStYMzMxZkVUZTlXTll3ajhDTlZKam1o?=
 =?utf-8?B?czdWajJrZ3locHlzY3M3c1M0b2ZWRC90WmV4YnFheUFpTjcyWDNCRG14alB4?=
 =?utf-8?B?Y3lDSjc4Sk1pVGErMi9zYlJzcEw4dTM2U3R0bTNaL0NWRUkwWk53K0FjbUJ4?=
 =?utf-8?B?Z3RlazZDaFQyWTZJM3gzTTNsaVBkTDRZeVpQRG0wZkU1aCtJT3pUdlpnRDBp?=
 =?utf-8?B?Z3N4Yk9sNnZZb1dnd0tpNE5IZkFDZktEV3RaTG1Cek1ma2d3RXVERzFtQitm?=
 =?utf-8?B?Ti9OTlRZcVB5cjBPRjg2VEJJMzdLVThsbmhTbzErUC9HekFVMGRZZVdTc24x?=
 =?utf-8?B?ZjRXWWN3YTdRaUErYWUyQ0F1WG41eUJzdFIxSU5wVDdEU3A4WUJOOVdHamd0?=
 =?utf-8?B?b2RVaGdGMHRLQm9jTVBKTWk1V2pvanZtRWlKWElrTFVqOUV2ZWczdEovS25N?=
 =?utf-8?B?OXpKclVwVmJXdlF0REdMQ0NsRTBmeUVTOGtiNVBTaEJlTktTc0JNQVpHT1lB?=
 =?utf-8?B?NmlzNnNZanNSUnNDWUlvWmE1d1ptSDdOc0RSb3B2TDBhTURoMkRUZ1NXZlZU?=
 =?utf-8?B?RDR1RkFIdkNqNkxGWXliRXFjVmVkd0Y1elJ0NW9XdlNoTThLTUFoNkpEZVE5?=
 =?utf-8?B?dG1nanpuYm9TcVNLOVFnK05mYm9xYko3MGhJemNMbzFFcFhDRzFWdjVJUXMz?=
 =?utf-8?B?TTRLemJsWWx3Z3FjTHpEYk5iNjlORTk1aExFSkoyQlMrcHVQZnVqUS8rNjhI?=
 =?utf-8?B?eVFweGt0OXV4YndYTUJYeVdPSWdjQm9oZWFicmVOMUgvRDZJMEVMT1FUYy9L?=
 =?utf-8?B?YjhFVEoyMDAvVGU0NitVWXRIZi9LNEZETjd5SkE5RjhkMitvYlFyaFZvaHVm?=
 =?utf-8?B?YnB0UTZkSXJBZFpRWjNWRnIvdnh4YTdWTWVUTDRSZlZuSytiayswdWdvNzdL?=
 =?utf-8?B?K3JPNHlLWC9nVzJYNURnQkRvVEhMQnk5b3VmaXZVREZMZkpaaSt4cS9UYmJv?=
 =?utf-8?B?cHVUaHZtR1JYMUpOQWllM2JLTXBlRHM4bWMrMjhnNnQ3WEhqbktGOVVMckxD?=
 =?utf-8?B?YmVTK2dNME9YelgwRERZZi9LL1ZKeXFyanVwZ2pxeUxyZnduYkp1bjRXa0Vx?=
 =?utf-8?B?SkdXaFRQcDNkZXAwd083WXJwS2V4RC9JeFdWTTJqcDRyakFrS2tWaFVnMWpV?=
 =?utf-8?B?Yys4bXVQS2kzU3FrcnhMeFZKUUl3SkkrMkhZZU9EWGVDblBBWUdueGtSQlBs?=
 =?utf-8?B?aVk3NSswb3YzbWpVaG5pR0ZuRVNoU2thMlBCVEVlbVB0dUhrMW40WUxaWjcw?=
 =?utf-8?B?L1FiSUNlY3dLbDhsYzlKUjNDQjhCT1JYRG1VKzd6ZDkzNzk0MXRZaWQzSEhU?=
 =?utf-8?B?aUhWNHVzcHcwTjlWMVhxUE1PK2d3dXI1MUZ5QnllUjk1NWVvRTdlT09rcndM?=
 =?utf-8?B?L0ZwZDc5ZW00cXpHeVlxTjZXdDdVci9vNVY5WEZQbUluNWxGVDArUk1KcmFr?=
 =?utf-8?B?WmkwamNmeTBhb0xBV3AwSmFpa2s0ZFE5MWlQRnVCWmdCam4xTXJzcXU4SGtS?=
 =?utf-8?B?QURCb3Faa1k4YXlZUjFyQTI2Rk9mL09JTHZJNFpTVnRrMzUweE9qR2NRMFhk?=
 =?utf-8?B?WGI2RFo3Nm1CcGxQR1dLVHlsL01rbGkxY214TWtWUlpTMnRWSlIyQVVwUnpa?=
 =?utf-8?B?YmNmNTBBR1pDVzBScVZwVW9Weis4cTA2aEF5MzRVWWpKNWs3dkVjdEtGblgw?=
 =?utf-8?B?MkhLbVR5dzJWZ2NnOXZ1N1VWOWZob0tUZzl2eGVleWhHVkxmMytxOWwvY2tp?=
 =?utf-8?B?cUxMeWhZQnVnQUdiWDg1clIwWUFob2FQZ0VPaFlVU3VKeWV1Tm5Xc3ZscEJz?=
 =?utf-8?B?eWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 451c90bf-0ee7-48a4-fe4e-08dc34b39a99
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2024 21:08:37.8174
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3OjcYAveRmts+3ql+cPy1tjatbkOD2PEubD+ixhydgRD0illOzEpxyCHQo4SlU9Us45uhrQJlZO9uWrENA19Bx+DtVz/178yOtUhbrqbbcg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5100
X-OriginatorOrg: intel.com


On 2/23/2024 11:24 AM, Rahul Rameshbabu wrote:
> ethtool.py depends on yml files in a specific location of the linux kernel
> tree. Using relative lookup for those files means that ethtool.py would
> need to be run under tools/net/ynl/. Lookup needed yml files without
> depending on the current working directory that ethtool.py is invoked from.
> 
> Signed-off-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
> Reviewed-by: Dragos Tatulea <dtatulea@nvidia.com>
> ---
>  tools/net/ynl/ethtool.py | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/net/ynl/ethtool.py b/tools/net/ynl/ethtool.py
> index 6c9f7e31250c..44ba3ba58ed9 100755
> --- a/tools/net/ynl/ethtool.py
> +++ b/tools/net/ynl/ethtool.py
> @@ -6,6 +6,7 @@ import json
>  import pprint
>  import sys
>  import re
> +import os
>  
>  from lib import YnlFamily
>  
> @@ -152,8 +153,11 @@ def main():
>      global args
>      args = parser.parse_args()
>  
> -    spec = '../../../Documentation/netlink/specs/ethtool.yaml'
> -    schema = '../../../Documentation/netlink/genetlink-legacy.yaml'
> +    script_abs_dir = os.path.dirname(os.path.abspath(sys.argv[0]))
> +    spec = os.path.join(script_abs_dir,
> +                        '../../../Documentation/netlink/specs/ethtool.yaml')
> +    schema = os.path.join(script_abs_dir,
> +                          '../../../Documentation/netlink/genetlink-legacy.yaml')
>  

This seems like a worthwhile improvement to make the tool more usable.

Thanks,
Jake

>      ynl = YnlFamily(spec, schema)
>