Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp100741rbb; Fri, 23 Feb 2024 13:14:49 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUQ37rIk8ckSZF2OTgCsm/gbkuPbUt3HVAFxM5zpzJIADkHXCoSTO95i54nqkN7tMyRWW1/asVwVJNkZkWKwKnnVgWwhOQc4bhIbg9HvA== X-Google-Smtp-Source: AGHT+IEypIvbn0JbPP+hSvZcEZ4Ncb+TLddxtxhzEElvqA66uL/cTulJq54kaa7QsBFSaLSrtY/X X-Received: by 2002:a17:906:b2d3:b0:a3f:db30:8998 with SMTP id cf19-20020a170906b2d300b00a3fdb308998mr589935ejb.44.1708722889839; Fri, 23 Feb 2024 13:14:49 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708722889; cv=pass; d=google.com; s=arc-20160816; b=rqxOH+UFd3j+6VjfsQl9Tp4LH9WKaKPepfgobeXKYV1CtBsLnibjEOHD9+ahO20a/2 OpJxnA9Q513cRkSFd8bbomzLPhpFDuK4972tE/R4ZymD0qKJjyJ9uPUPFr0jc1sugRKx BOgcDFH2V2D+BSNydoyVmRXAyPg9K1L2TqZBe2c7PzemXgwHxmvCfdx8JKTHzUT/FCv6 O5qRZRimRqlIiTnMIcs81BLo6W2Js6TI50F+4+1Oqzz35rNE/W2eC6OIJQsfiAbzPACq VclFAG0bZlkdqR/BqSZW5ulJPEmJn7NkOGcUnPvhALfP/a8pieyeF1edReq7eX1S0vjn xkjw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=q8HrodCRp+L9Bf4I0p/HDaMA1Nr8mB/ynOuRfQ7KKVo=; fh=T1QCSfA/D/u8DAYI8HISSA3sH9e1jS4LRSECNC2BiW4=; b=uzW7PVFAsfasFRwnzOfIqjl/QizmXgY10siw4ari0H+HpaQewANEGmUxRWENHZqX5D 3ubSLpTIXYm9HY1AJjchJduv2OBJP0MLXkWuNqM+XrAzjxB++ktWimcQvqt5BYW/gYI0 Ae0mVE2icSGRZKqoTb8ZS4u94MbEddlemtGiHEm/GDBC8royKEXqz0GW5CTBwJTG4jtl mP729uwQUoiPoyBMPy9qSc+EbEpI8QnjmgvBDMMOhdC8dR48oCnUVVB97D95QXl0h40s d+42p68al5opX55TLP8QTLWYjCrTQP36asW0g24gMYU4ls/WwYoLFGTFijsfjhQeAz9r EI1Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Gx27df/w"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-79185-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79185-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id hr13-20020a1709073f8d00b00a3e5f4e8053si5738331ejc.674.2024.02.23.13.14.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 13:14:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-79185-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Gx27df/w"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-79185-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79185-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 898001F26369 for ; Fri, 23 Feb 2024 21:14:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CDED7149388; Fri, 23 Feb 2024 21:14:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Gx27df/w" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F39431448DE; Fri, 23 Feb 2024 21:14:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708722882; cv=none; b=qmYjKijV+1NGFg5sv5DvWooicxPjuPjyayQ0h6wf4mwKvui17lXjNdcFTNANE7Xv50htYCjJbgIHPchWsFqeS5Nnw/vw/shFLi7NiaswU0TePPxxYSZcurJDjDxVA0zMPF70N1GOozNLqC3IqV5IGkHTE3dmgCkhAoaOmpR9DkE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708722882; c=relaxed/simple; bh=yl3CZeQj3q+MbODgHmMHwet9xKy0k4nfEARp/YeN2cs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=e2gy79U3b/CtwReM8Q9an/pQpvVtGn3Lsg899ihPJIrMIUyIhM0Yhe2cyEmOq9/XDF8FKdqwhtTjLW6/of4J9o5mT2J0tU1DiHR7LbLcpdpbaNJdT/okZPGYdveGKBTsQn9/oQT5NUxFCXH6ducSdQLrUqU4c2Z7OsEWZqeWVJQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Gx27df/w; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id EFFFEC433F1; Fri, 23 Feb 2024 21:14:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708722881; bh=yl3CZeQj3q+MbODgHmMHwet9xKy0k4nfEARp/YeN2cs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Gx27df/wdNJMr8+1CuZZ+3TaPkaZVRZX1o3fo9UZJNOXzo55Zj/MwVpoDNj4qydMt yn6/WzHu0ZLTrOzllX1C9D5qukIg7QlPp/oN4H3kfJajOfiVhuSMOeypsxxT9RZcm9 EZ3TNnMDrI/yu8KM8729XCHFGblfKl/ICHkc8LmpgBQvvEncAkn6ajDqHwGcDInvbH aO+GI34pX7KMAJxHNZcG5bl1hWOlwpMCGxhHRYsMxRu+XLj8PGUw5GMxwSFtCS8vve UY5XvC/8+posYtErQlydXsAa1JJg+OcN7dFuim7Q/I080httJhRD8Kf16u8oP4I8af 2S578ThexXzVA== From: Namhyung Kim To: Adrian Hunter , Kan Liang , linux-perf-users@vger.kernel.org, Peter Zijlstra , Ian Rogers , Alexander Shishkin , linux-kernel@vger.kernel.org, K Prateek Nayak , Kajol Jain , Arnaldo Carvalho de Melo , Ingo Molnar , Kaige Ye , Mark Rutland , John Garry , Jiri Olsa Cc: Stephane Eranian Subject: Re: [PATCH v3 1/3] perf stat: Pass fewer metric arguments Date: Fri, 23 Feb 2024 13:14:38 -0800 Message-ID: <170872283702.3880577.15255792223602721084.b4-ty@kernel.org> X-Mailer: git-send-email 2.44.0.rc1.240.g4c46232300-goog In-Reply-To: <20240221070754.4163916-1-irogers@google.com> References: <20240221070754.4163916-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Tue, 20 Feb 2024 23:07:52 -0800, Ian Rogers wrote: > Pass metric_expr and evsel rather than specific variables from the > struct, thereby reducing the number of arguments. This will enable > later fixes. > > To reduce the size of the diff, local variables are added to match the > previous parameter names. This isn't done in the case of "name" as > evsel->name is more intention revealing. A whitespace issue is also > addressed. > > [...] Applied to perf-tools-next, thanks! [1/3] perf stat: Pass fewer metric arguments commit: eee41e6b287e2adfefbe3b6fc80c66097c076f89 [2/3] perf metrics: Compute unmerged uncore metrics individually commit: a59fb796a36bb6c2b7e6e256a9e5f9ba18109937 [3/3] perf stat: Fix metric-only aggregation index commit: bafd4e75c1ac5a9da0aec5c7c52c7a72613a0cf3 Best regards, -- Namhyung Kim