Received-SPF: pass (google.com: domain of linux-kernel+bounces-79191-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <8caed6ce-808a-4d25-823a-fc4d6b56268d@intel.com>
Date: Fri, 23 Feb 2024 13:18:32 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 3/3] selftests/resctrl: Move cleanups out of individual
 tests
Content-Language: en-US
To: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>, Fenghua Yu
	<fenghua.yu@intel.com>, Shuah Khan <shuah@kernel.org>
CC: <ilpo.jarvinen@linux.intel.com>, <linux-kernel@vger.kernel.org>,
	<linux-kselftest@vger.kernel.org>
References: <cover.1708599491.git.maciej.wieczor-retman@intel.com>
 <bc4a4fec20420fb792612be024473f31f40d7bca.1708599491.git.maciej.wieczor-retman@intel.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <bc4a4fec20420fb792612be024473f31f40d7bca.1708599491.git.maciej.wieczor-retman@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QlhvcHoxaFNERnBqbUl0V2NSUGcrdmt1bW9QLy9PQnJ3eFhFUHhkd0VHZTZY?=
 =?utf-8?B?WFdUZGlQMENkOXo1UVZHbUcwbGxNSXR4ejFieDBwZjltOW80S0M4TXhWbVJG?=
 =?utf-8?B?MmttV1hDemtKZUVHaTBzR1NpbTFQdE1vLzNiMGhCeGJIWXBHQjVEQnpZRWZU?=
 =?utf-8?B?LzhHQVRUcHBtUTY1NzFvK3Q0N25iYTd4WFNSMVMxWjgwdnAwY2RLd1RNMXYw?=
 =?utf-8?B?VzhXcjBBWmRMOSthdUdhbTQxR0RqMjlIVlJ0d2NkUGg4NEhKNEJuNVJESmlq?=
 =?utf-8?B?TWNla2YyOSs1MDc2a1ROTHNpUjl0eEhYMDV6a2piMEE5MGlzVzVtSlRwaFhS?=
 =?utf-8?B?SWtkVU5VeGl0bGUzcmVQVnI1Z280ekprVW5WdVd5c3lHaVRQWjZYNnNFRTI1?=
 =?utf-8?B?eTh1ZTc2eU1KMXBYNVBORFFCa2dobWFDbnJCUjVPaFY5MGF5VU1wQk5iOTJ2?=
 =?utf-8?B?dnBHenVCWjQrTVJMa3B4bDNjZ1QxM1duQXgwei9FQXZaTFlHdm1KOGRQUXQv?=
 =?utf-8?B?OHl5RUZhNHRGQi9RMWZHVnpueHNrdmFjbGVkWHFTT1I4VE00bHl4Z3JUWXpl?=
 =?utf-8?B?VjdndzlLbDhRb3M5a1pJUUFsZ1M3ZUx0Y24yazl0YzVSWEY3TG9xNTRxSktI?=
 =?utf-8?B?YWpKSTRtVkVYVk5naFBCVGpiRkhXbEU5a0ViVUhUdFc1c3R5ZU5HUWVIRXlh?=
 =?utf-8?B?MHlrZjhjWmF1NmRyaEdlZDlxeVV3RTB2Q1VXcWtiTUYyeEg3ejVmY0JQdW9S?=
 =?utf-8?B?elk4RWVEMW9lYmNZVVNsbWtpRmdneHlDQ3dETGdtWjhiMGk5WTQ5MzV0YXc3?=
 =?utf-8?B?WTBxS1lQMUM2OVd1VnpsWndUK0xrNzRkSWVtWnBIc1RjTXQ3RnlpZXN0M0VN?=
 =?utf-8?B?NmVEU2RSN3ZCdGFYN2pacmdFQjM4akV1bVhYTHNKSWE1THZtT1F1YVBBdlJB?=
 =?utf-8?B?citMY2lXS1M2YkQrbGRIU1YrcjJHK2FwSnhES0lGVDh0d3U5M3BOVkFYek5z?=
 =?utf-8?B?aCt1aXlNZVVzSWpiTllodUxCRGJYT0w0SVB4aW8wMnNBcjhOMVB0NXhxOS9l?=
 =?utf-8?B?REhSVjQ4a2c1aStPODlqWU5FRk9leEdkREFhMHZOVTZDTmFXN0h2NTlqZlBm?=
 =?utf-8?B?d21Ocnp5bXgzc0IrNWg1QnpXREMybEtwTVEyOWp4Z1dYNm5oS05OdytkanBv?=
 =?utf-8?B?aGE1OUhCNDYrZEFRQ0hDL0xZWkE5TlovK0FHWnp6QlF4YkszK3lVS1p4M3dt?=
 =?utf-8?B?WjU1b05kUURiMzMzUVJmZkg2OE05M1h1QlM3c09JR0tBZ1R5RlZvSGRZWitN?=
 =?utf-8?B?TklqQkRGckMrK0svQnV5R2l1MEZMNEMxc1NnOHRnekRGMVpkcTBEdllwV25Q?=
 =?utf-8?B?TWZUNVo3QXpld2dDYjY1MklPQkt2bUU4Vk1iR3pTSTErbmZmR1dTRHFRdEky?=
 =?utf-8?B?dG4xTy8rbEt0cHYzWU83K0VZZjl2ZUJlNDF1QVFlR3VDRWpiWkk2MFZlOVhh?=
 =?utf-8?B?RkNrSjIreEU0RERySkdCdU5CNUJJOFZGNnRrODN3YnFHUHZmV2dnam40SVR1?=
 =?utf-8?B?RGM0c1dQSlVJRUdZR2YxME1OdXl0dUx0OEVFTUNqVDNnYkdqZFZGVUwzSjBn?=
 =?utf-8?B?WElROW1PSmt4N2xyTnFmRDhWTkNhR3dGT1VOU1ZZTUNlcnlhOGhaMTRLdS9s?=
 =?utf-8?B?MmZTQ0FmS3NTMTJ1dkFaVWZPV2FsVmZyUk8wVWVDNXlvbFROc3cwOTdrU1pF?=
 =?utf-8?B?V0RiVFRRRmgvS0E1b3BLUXdzUnVpMGlmR2xkVXhSbXJ6UW1ScGdNR1U3dFBY?=
 =?utf-8?B?VmVVUGZqcFo0ckxnajFTQ0NmZmNuOGZPN203YjBScjF3dGx0UlVtalJuL2NR?=
 =?utf-8?B?dmZsbG0rMUw4THRLTGtpRDNEMmtteEN0ZmREWWlJUVZmeFI2alUwTG9OU1NP?=
 =?utf-8?B?ZVhTekhpT2JYclYzTjBhWFNTdXNaeFFEd0FCcVM5c1ZBenplLzBJUGkwbis4?=
 =?utf-8?B?blJJZ0Z3YzRKZm53dThyc1pqK1RtcXFiSmF0TU9ERitYbEt5K01BQU1ndWhX?=
 =?utf-8?B?MkgyRDM4dy80akRmaUR5dFlLQnUzUWVsZy9WMGFkdFNUUjRjQnRYa1diQ0ZI?=
 =?utf-8?B?NExiZGtzR2lKSk5FbDRGZlE5Nk9Jcm9IZDhwREI3WmlvOUR0dkdUYWc2WU1S?=
 =?utf-8?B?RHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bde7b39a-b9e1-48fb-3d89-08dc34b4fd9b
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2024 21:18:33.4267
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DNIs6HL96BOztniCbFfIPz+q2TV1fLMcDPFDskaluwtZoaFUEXnDXj/9qDpL9ksp7caVapswGpqkV9BWw8egyNctjKFgKMB7/eZSe8iqcZs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7510
X-OriginatorOrg: intel.com

Hi Maciej,

On 2/22/2024 4:07 AM, Maciej Wieczor-Retman wrote:
> diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testing/selftests/resctrl/resctrl_tests.c
> index 161f5365b4f0..bae08d1221ec 100644
> --- a/tools/testing/selftests/resctrl/resctrl_tests.c
> +++ b/tools/testing/selftests/resctrl/resctrl_tests.c
> @@ -134,6 +134,8 @@ static void run_single_test(const struct resctrl_test *test, const struct user_p
>  	}
>  
>  	ret = test->run_test(test, uparams);
> +	if (test->cleanup)
> +		test->cleanup();
>  	ksft_test_result(!ret, "%s: test\n", test->name);
>  
>  cleanup:

I think this can be potentially confusing to do cleanup here and
then follow it with a test_cleanup(). Could this test specific
cleanup perhaps be called from the general test_cleanup() instead?

Reinette