Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp113808rbb; Fri, 23 Feb 2024 13:51:41 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWs2AMY4RK4/CDBKdQlRFcGH10sKMTYF8KxZ6FFd4qiiZeRCyB7AmsD2mBUsd8i0jJVSOH/67peUYCRu345FUvW0UKh7hURF2eVqxGtLg== X-Google-Smtp-Source: AGHT+IEnB/cuhgFY8GtZqndaMXSAEobnjrxqxRH0vrssud9wPQXOBF8NQbK9maF5bhIuPAWv9Bzc X-Received: by 2002:a05:6870:c990:b0:21e:d482:ccad with SMTP id hi16-20020a056870c99000b0021ed482ccadmr1247091oab.59.1708725101035; Fri, 23 Feb 2024 13:51:41 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708725101; cv=pass; d=google.com; s=arc-20160816; b=Rp/EUIlEo/BHrjnzFQeL1aTn3rAnIBpPat/+d6LWp2Gxo+KNtb0beeW0ehawaHtMyp 4a9TFgpjw8CJ984Rf0XQfXCOTQGxj7qk0BED3U85VWYn21OsvBZb/Hn7qL9k00s63/xj sPM/NR8rqjM210LDq6rNmOwuQmMR2/tQPP74MD+L+c7uFBeUtzQeVTUYeebidPgkLvYF +CwR3cRTyPpsdcu9hNnE7m5i6KDJnBaeWlWn3iTvALRK1yqx0eirCK6x40OXt3QkqFik KpOTnjvq9lwOX3JWXVi9YqAhfu+kn4kv0JPMEUkesX6OfJaPtojeYXh3jaBDz+5entwG Y1lQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=jUtHteZepb4z50jTNHYGGTGy3lyvRj0SCUA4OkqA8eU=; fh=1YeMLi/KrNVI1y+F43NeHCZ4aG4pNIJ27klTWY92+a4=; b=Ma+Dxa+7sBV4ffSHM3QscloEx44jJ6wPKajx7MWYUhdPKp3T5w5lLgm0AWzkfmnrdo YQRIFz8bYLLGhOSUdMmXVcq7O3umQ+MQ88Y8MDyfOnbExSUF+zRTUjd/DDtGnruReWa3 OYzAoymCKD26Uyk+YQtsxNHwq4PJfdhmvG9wKsiqC5ZaBpDxbDy+ktRbItiuw/bGhHUp UqyMI8W8dgiPrIZZtEMAi/hvIhZ6fmv1IBpdmRzfrUTTG2zga5ipgp6406KJZCHw/9dj Swr/k003AqDe6VEJO8WuN2lqTmDRng69zbXscFtOk/S72tEMXFCESZcofvv8zxN4pGbG a1oQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=H+lI+Rj8; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-79230-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79230-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id m1-20020a05620a290100b00787b8407bedsi1624902qkp.62.2024.02.23.13.51.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 13:51:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-79230-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=H+lI+Rj8; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-79230-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79230-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id C1CC51C21A22 for ; Fri, 23 Feb 2024 21:51:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C5AF714CABD; Fri, 23 Feb 2024 21:51:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="H+lI+Rj8" Received: from out-171.mta1.migadu.com (out-171.mta1.migadu.com [95.215.58.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B7BF1493A6 for ; Fri, 23 Feb 2024 21:51:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708725090; cv=none; b=nTqXsalLiEzBlVKzJ15i5KoT/QpsgRG1e4jzsMemop3aWFt86K7yy2SIk9XhAt1iRpZtZh3nVOx02p2Xr+egWV3J7fkW3zsl5XrwqXQXJ9v9UwRO40hJ34R72IKF5F952TZl4ONpUpPq723B0p/W0FLGPrvkjd1rt2HXD9ZmPaw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708725090; c=relaxed/simple; bh=93F5H5ukZQOVSdrcrxmihCLMlpqa5YQe5yss4A+ZmBE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LNIxrDq68hH5UVbtxm85HtVnpo/L3ZlPx3j9iuB/HVTfi6ZHaNdhhk4GN6z/gopRp/nTSu/1PB52ew5OoWpd7VyLcVoxfDDyO+/eLlSJCmlmuPtnWqz2CnQZJAE5dcNYj1A9gUq4NxUHOqP5T8zl3Nj/zSjJjvKyI2MxVHM4l4o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=H+lI+Rj8; arc=none smtp.client-ip=95.215.58.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1708725085; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jUtHteZepb4z50jTNHYGGTGy3lyvRj0SCUA4OkqA8eU=; b=H+lI+Rj8l5nTGp5sBTzGuzdI5khJ9NsvrJ3HNWZCOgT40yuj3u48TDv3nLLpO2T8PtfRp/ YQZBCLCcnw3Pnx5Pqvq7c0TEDoBv1IPwSEDUGIz5MhmRHrQ1Yb9dgp9qA5DNgz/i/+QCeL QNq6wIZM3TtiE5phWqnapfnpWDCsG9g= From: Oliver Upton To: Oliver Upton , kvm@vger.kernel.org Cc: Nicholas Piggin , kvmarm@lists.linux.dev, aneesh.kumar@kernel.org, Sean Christopherson , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Michael Ellerman , Marc Zyngier , Paolo Bonzini , Sebastian Ene , naveen.n.rao@linux.ibm.com, Christophe Leroy Subject: Re: [PATCH] KVM: Get rid of return value from kvm_arch_create_vm_debugfs() Date: Fri, 23 Feb 2024 21:51:12 +0000 Message-ID: <170872506304.206263.3199862434632781431.b4-ty@linux.dev> In-Reply-To: <20240216155941.2029458-1-oliver.upton@linux.dev> References: <20240216155941.2029458-1-oliver.upton@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT On Fri, 16 Feb 2024 15:59:41 +0000, Oliver Upton wrote: > The general expectation with debugfs is that any initialization failure > is nonfatal. Nevertheless, kvm_arch_create_vm_debugfs() allows > implementations to return an error and kvm_create_vm_debugfs() allows > that to fail VM creation. > > Change to a void return to discourage architectures from making debugfs > failures fatal for the VM. Seems like everyone already had the right > idea, as all implementations already return 0 unconditionally. > > [...] Applied to kvmarm/next, thanks! [1/1] KVM: Get rid of return value from kvm_arch_create_vm_debugfs() https://git.kernel.org/kvmarm/kvmarm/c/284851ee5cae -- Best, Oliver