Received-SPF: pass (google.com: domain of linux-kernel+bounces-79272-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <9f814712-7189-424b-9af2-67f565dc35f2@intel.com>
Date: Fri, 23 Feb 2024 14:39:37 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 3/4] selftests/resctrl: Add support for MBM and MBA tests
 on AMD
Content-Language: en-US
To: <babu.moger@amd.com>, =?UTF-8?Q?Ilpo_J=C3=A4rvinen?=
	<ilpo.jarvinen@linux.intel.com>
CC: <fenghua.yu@intel.com>, <shuah@kernel.org>, LKML
	<linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
	=?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= <maciej.wieczor-retman@intel.com>,
	<peternewman@google.com>, <eranian@google.com>
References: <cover.1708637563.git.babu.moger@amd.com>
 <cc22790173de9978a6485baca5bc96a8ad8e05a4.1708637563.git.babu.moger@amd.com>
 <6f611a0a-f2ef-1017-07c0-5d805abb80d4@linux.intel.com>
 <efab7efe-d043-448e-bc7e-4a756b4f3367@amd.com>
 <fd71d5f7-08b8-4042-b94a-e81cc68c975b@amd.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <fd71d5f7-08b8-4042-b94a-e81cc68c975b@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SWYvS29KOHlHMFhxMnZqQ1JnWGxrRTFDczV3S2lDeGtKN01ZdnNHMU1EMStS?=
 =?utf-8?B?ZFdQSG50djc5ZlVIU2JXWUtXSUNzTFA4eFBrY2x1ODhoMUJsWWdWVW5OVWRs?=
 =?utf-8?B?bFNONVFpcGt4S09Jc2l0UEs1TUJ0aTZIbHBseVpLOFB5TGFhbDdhZFE2enk3?=
 =?utf-8?B?WXZSSGx0WkF1T1R4dVJETUFrd1d1ZXJNOXAveVZhVm9IKyt6dDZIUTliYldT?=
 =?utf-8?B?TzJLNHdzbXVUbG9POXI1NlJJZk9JRGxCdWxUcXFEaGRKZWNkTHh6RVpQcmwr?=
 =?utf-8?B?bVh2UzBXaUEzQ1AwdUNGcjZsemFOVEJqWXkxSFhHZXlHR2pYR2tBWmd4TkRN?=
 =?utf-8?B?NnZQUXNEZjlPcGpYN3hOdEhUdmorSzAweXJVM0lEeEFJSHk0bGkva3prcUxI?=
 =?utf-8?B?dmt0bVJyQ24zK1F3cC9SeUI1UHVaai9Td1BuQzFSNTZyY0JPNDd3QlFvcnVI?=
 =?utf-8?B?cE1jMWlHS2ZhVmNzaFd5OVNFdk1CSUI3cC9zWHVXbFlKWWdqYm5iajlLcmR6?=
 =?utf-8?B?akNTdEJONFltVXNQSHVTUEVnNW1MVzhSZjZ1M3h3Y0hDQ0c0enErUXlRV2tl?=
 =?utf-8?B?ei8rQ1VodFhSalo4aE9JODloVmMxam9KclE1bjdVSWtSejJGelpvdUdZeDV4?=
 =?utf-8?B?bmloL1k5b0tPWVdUQjNncThJTFBTeHpSSmNUeHpCZ3lkOWpvazFRZ0V3RE1t?=
 =?utf-8?B?RUVJM2kzb2lsZTY2VU5SbTI2REZqYmwydDg4anJqcnkwTUpZUFpLejlaMUhC?=
 =?utf-8?B?RldzNDBrWmEySitNL2hoQ3ZjV25yL0dlNm5VL0FGd2huZkJpc2EvakltYVdq?=
 =?utf-8?B?MXozWC9RNWdkdDlXWk1vT2xBL1JHUXNNUWNzczMwcDY2WEJrM2FpV1ZFbnh1?=
 =?utf-8?B?amYzRWFwNEdTbWNDa0pEZkI1Ynd4N1ArTkU3SWtiQ0NSaE1oS2FvcFZVL0lH?=
 =?utf-8?B?ak1IdEF6eUhjWENDc3FyZ3NFWUgzdGtQREJGMUIxcmNqNFg5d3FUZHJWTS9p?=
 =?utf-8?B?WkgyWG9pWjVVZkZpRzVPWEFkUjllWjMwbVArYUc2T3pFdTlkYXRYbGoyVzkv?=
 =?utf-8?B?bTM2RTZqdFRtbTdkNUd5UjdlSUk0MkNJc3VDS1ROb1dwT1Fxdjl3SnBxOElk?=
 =?utf-8?B?UGFUZ25SOXRvYmhzV0tVaytIUXNxSElEVjJGSUcwQkxuNVNMQUlvTUN2by9z?=
 =?utf-8?B?WjU3eElKejN5SnBKOWhjTHd1RjZpcjJtSVhyOWpNMDU3NUpGNHRaV204OUxP?=
 =?utf-8?B?Z0RGZUdDN1dyY05uZUtVRXNUK2FucjZVS1dJc0t4NWF2UDBCQXJJRm4wMmww?=
 =?utf-8?B?dVV1eDM2cEtVUUJVNHBVNE40dkh0U1hZYkZxVHZIQVlFU2QrYVVjZnZmZnJr?=
 =?utf-8?B?NWIvZEFvRkw3Qm5iM0ZQOUtNOFI4N3kvZ2o3MnBPa0x5RVc0VTVTd2ZoOXdV?=
 =?utf-8?B?dC8rVkY2ekF0UTN1MFZEKzQxakV6bzdtZSsxRG43WEZsRnJpeUFIQjRZUUpY?=
 =?utf-8?B?UEppQVBRdG9LcG9HUnM5NlJkcFZKSmUyT3FZOHRaeEloeEZGMy91Q3dGbkVl?=
 =?utf-8?B?b1JCTEVQY0JVSHBCeDI4bmNoSE5ESUh2bnROVEROK2NIbVk4TUdXSlo2NHJq?=
 =?utf-8?B?UHJmd09BYVAwWHZRQ0pvVDJsUDNRNG51KzY0ZW9COVB4WklGQ2xPZTNLeTA1?=
 =?utf-8?B?RGJ0NzVNVlVJcGt2U1NKT1QwVS9XREtjRTRHYU15Ukx0aHZKeGRQUXVKZkFW?=
 =?utf-8?B?VjZ0WUdIQm9mVll2WHFvdHpuSXZLaExWNkVmV0pWMXp3cVQyZ3huVDZBck51?=
 =?utf-8?B?ZHBMbjBPQ0x2N0R1UlpzQnA1WmE1SmFHSVVvTXVqMU9saGNiWXZsVWd1QnFC?=
 =?utf-8?B?RUNmNFhCa3JpL3Q2QjVhZzAyYm5FbHdxQVZjL1d1QVdwQitOTXdUSUdKOHNU?=
 =?utf-8?B?a0QwRUFtTmxkWHdLcDNnd2FCSEhqUklwbGxLNVMzeGlVTDBFMHNZTit3Y2kr?=
 =?utf-8?B?eTFDcStoK1I1RUducUVzVXRZUFBOTXFLcEo0U2h5TFVFakdYNFJnbDZTZjRY?=
 =?utf-8?B?Q1lvdm04UGJSam4xN0N1N1RVUjMxNWlodytxV2hoYU51alFFM2x5YisxQUdG?=
 =?utf-8?B?L0ZRL1htai9yQWVPUERNVWhOTWtVR1ZxVmtURytwTlVzdFRsRVhjaVB5bFpj?=
 =?utf-8?B?QXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d34a011c-c472-407b-f302-08dc34c052ce
X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7566.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2024 22:39:40.9403
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SeP7KUsKZzvBxfJsBKTwoDYkzr4eEA9v+whkBfiYstxmQr2IQQKn3VeKHqn8O3f8TJlrAOyUEwW9I5Eoq1PqA22tzROxlztNW6fldnBGg9E=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5808
X-OriginatorOrg: intel.com

Hi Babu,

On 2/23/2024 11:47 AM, Moger, Babu wrote:
> On 2/23/24 13:30, Moger, Babu wrote:
>> On 2/23/24 04:53, Ilpo Järvinen wrote:
>>> On Thu, 22 Feb 2024, Babu Moger wrote:
>>>> @@ -131,8 +130,7 @@ static void run_mba_test(const char * const *benchmark_cmd, int cpu_no)
>>>>  	}
>>>>  
>>>>  	if (!validate_resctrl_feature_request("MB", NULL) ||
>>>> -	    !validate_resctrl_feature_request("L3_MON", "mbm_local_bytes") ||
>>>> -	    (get_vendor() != ARCH_INTEL)) {
>>>> +	    !validate_resctrl_feature_request("L3_MON", "mbm_local_bytes")) {
>>>>  		ksft_test_result_skip("Hardware does not support MBA or MBA is disabled\n");
>>>>  		goto cleanup;
>>>>  	}
>>>
>>> These need to be rebased as this code moved into per test files with the 
>>> generic test framework. The .vendor_specific field is the new way to make 
>>> tests limited to particular vendors.
>>
>> Hmm. I picked the latest code from tip/master. Where is the latest code
>> now? Is it yet to be submitted?
>>
>> I can wait for your code to merge first.
> 
> Oh. ok. Here it is
> https://lore.kernel.org/lkml/cover.1708072203.git.maciej.wieczor-retman@intel.com/
> 
> I will rebase it on top of this next revision.

The resctrl selftest changes are routed through the kselftest repo. Shuah just picked
up this series you noticed but it is based on the framework changes from Ilpo that
is already merged. I recommend that you base your next series on the "next" branch
of the kselftest repo [1].

Reinette

[1] git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git