Received-SPF: pass (google.com: domain of linux-kernel+bounces-79277-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
References: <20240223192658.45893-1-rrameshbabu@nvidia.com>
 <20240223192658.45893-6-rrameshbabu@nvidia.com>
 <6e0a725f-3bd8-4e14-afda-860f1e4c1dc5@intel.com>
User-agent: mu4e 1.10.8; emacs 28.2
From: Rahul Rameshbabu <rrameshbabu@nvidia.com>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: Saeed Mahameed <saeed@kernel.org>, Leon Romanovsky <leon@kernel.org>,
 "David S. Miller" <davem@davemloft.net>, Eric Dumazet
 <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni
 <pabeni@redhat.com>, Jonathan Corbet <corbet@lwn.net>, Richard Cochran
 <richardcochran@gmail.com>, Tariq Toukan <tariqt@nvidia.com>, Gal Pressman
 <gal@nvidia.com>, Vadim Fedorenko <vadim.fedorenko@linux.dev>, Andrew Lunn
 <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>, Przemek Kitszel
 <przemyslaw.kitszel@intel.com>, Ahmed  Zaki <ahmed.zaki@intel.com>,
 Alexander Lobakin <aleksander.lobakin@intel.com>, Hangbin Liu
 <liuhangbin@gmail.com>, Paul  Greenwalt <paul.greenwalt@intel.com>, Justin
 Stitt <justinstitt@google.com>, Randy Dunlap <rdunlap@infradead.org>,
 Maxime Chevallier <maxime.chevallier@bootlin.com>, Kory Maincent
 <kory.maincent@bootlin.com>, Wojciech Drewek <wojciech.drewek@intel.com>,
 Vladimir Oltean <vladimir.oltean@nxp.com>, Jiri Pirko <jiri@resnulli.us>,
 Alexandre Torgue <alexandre.torgue@foss.st.com>, Jose Abreu
 <joabreu@synopsys.com>, Dragos  Tatulea <dtatulea@nvidia.com>,
 netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-doc@vger.kernel.org
Subject: Re: [PATCH RFC net-next v1 5/6] tools: ynl: ethtool.py: Make tool
 invokable from any CWD
Date: Fri, 23 Feb 2024 14:39:07 -0800
In-reply-to: <6e0a725f-3bd8-4e14-afda-860f1e4c1dc5@intel.com>
Message-ID: <87y1bavm50.fsf@nvidia.com>
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?WB9Y+/BFhuYlwblQgGOTZ5xfc+8jFpkqWcv/oQbndYVoEh8CJE8pFd8vmCv/?=
 =?us-ascii?Q?maFWxpJPR9TupRX7QJjY2uvRkB+tQGhJjftkMc+LiyJzXYRY+oM3XcDKe2cb?=
 =?us-ascii?Q?DrfGK0b/4MMw0x58UyDkGL8OOa+pCqkluZG8ToTPmHex9FLIRKpwEVMA0rIT?=
 =?us-ascii?Q?62hTjoz8lyOJFOQkMaMylgZunUP6tKu+OovYufj7z1j+la835hGrZcTXSA57?=
 =?us-ascii?Q?EJZMSKhkzW88ZuIycImJr23cNrpnQejvugqp2xsPWXJJtQhDRSWtrYO9BIav?=
 =?us-ascii?Q?4Wlkgd6AmR9NI+XknzO3utR0Mz+1gOdLf0xH+oM7zkNZs4Bgq/cq3m5t8lew?=
 =?us-ascii?Q?7tgO0EyF37TJCK8zH8lBzL82KNey/kP+2dgWdNuREwohuj8uqDrXflk/LvGz?=
 =?us-ascii?Q?zwOgczrZjXJTDe0MYUbV0RwVyVmgIAc59GKXB5HcMdBaP/MMP+4hfDyhlVtH?=
 =?us-ascii?Q?9/OHb2B98bQwar2dCILgAlYjiq3nGnhbeadXqZOGSguB2wcJnX9kY00ZCoDi?=
 =?us-ascii?Q?rAfmEu6W7U0+eDMjrn2bhMPTKhGAMI48N9LQFBwSyMfCx8jnJwT3mShcNVtu?=
 =?us-ascii?Q?uDMY2GI4dyE0O9VUfposE+VW9A0NXg/Lg0xmirlfhEIEn7ZMNbraVSJtdIEm?=
 =?us-ascii?Q?JU6utLH3JNRZk9RlVd3rrJ3V6eRKxPHdOvL2+TS6lHXs7PVHyaRR5UEKQ2rv?=
 =?us-ascii?Q?NNeW7gqiHh0qeGPTxZsXA+bl2iuQaDLX9oIS9F1MH6lAAVG431+b+nSrNCD0?=
 =?us-ascii?Q?rJVqupvIw+yojrFh3Ad8L1D1BiUVUK6keUgQYqdFwtqVuBPh72oXoVT0BZAj?=
 =?us-ascii?Q?D9FoBFABmpz3VE2XD2987ODQxOic/nSFQS5aH548w11+68b2dxXR/MRiumkx?=
 =?us-ascii?Q?vHrKislAO7jD60pvOsoXwcpmlNSy/ASA50oPJuJBnL6ZY8i1y1oNo5DadJKS?=
 =?us-ascii?Q?QG0Bazq/gTWNM8sUvbgizUW1YUUECZetjNE0CIyGqt3etDXEyb8+RJnQmUW1?=
 =?us-ascii?Q?o5Cho2mBYBLhiWSLpX3yUgZBn3dzpOaBWS1TQeql1jc9PU6Y4IOHtExT7uer?=
 =?us-ascii?Q?pKu6LcsfZdWJnQopEVmbUX4sQT3+yrZDTHhLd5bgwvCNdB/5kktaSRH+/Dda?=
 =?us-ascii?Q?874s29RN4lydrtSdMQJap8Te8qmSE60w9yEW+ta/7Lo/Vm+9sY6OP80kV1VU?=
 =?us-ascii?Q?XmBv8zGuer/5M0NLuy35VDwnOR3mrgLUKyRhociBU4DPqj9lbChwp29lxGZT?=
 =?us-ascii?Q?JeFmCmbcW025kCLUC6bA1IL3Hhy3l/lKmxb+dy8w82ZFp21VjZ5jlRFp6eWE?=
 =?us-ascii?Q?Et0E8xAa/EtYKZ/aUMGO8nODtwpgz93W/4y+jHMA1pVLWfRZaKuWWqicoJzz?=
 =?us-ascii?Q?n614cNGihXBBajHKGR458LO3EKjS7/WeVA3bUM4mT0qkF0IueZmohoBHqs/y?=
 =?us-ascii?Q?AziWuLE9LQX1Vg+ErLqFAO7CbMA/IFW18M2Rlop+U/z5UixotKlRGcnsMCfy?=
 =?us-ascii?Q?v4uPRUP+GV1q3l+t+2z7JUFluMhT+SyI1N4qkr5A9Z+8XpAWNJunEcr2k7g5?=
 =?us-ascii?Q?goWPpVwOnjq8tEiqACqMnzRlsnylkLNkunHhmI2Jo+GUfz9KUCz+ZYJ1/nnJ?=
 =?us-ascii?Q?Jw=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 124c3f4d-259e-4e04-8907-08dc34c09f12
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2743.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2024 22:41:48.8967
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hWcI/UU7JlXx5nhzQT/NQAWssDf7PUPDzWOOBKDPROXCCBZkJbJVn605rmlDcsAx6vwkHIoyu+DU5XATvHmlHg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6010

On Fri, 23 Feb, 2024 13:08:34 -0800 Jacob Keller <jacob.e.keller@intel.com> wrote:
> On 2/23/2024 11:24 AM, Rahul Rameshbabu wrote:
>> ethtool.py depends on yml files in a specific location of the linux kernel
>> tree. Using relative lookup for those files means that ethtool.py would
>> need to be run under tools/net/ynl/. Lookup needed yml files without
>> depending on the current working directory that ethtool.py is invoked from.
>> 
>> Signed-off-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
>> Reviewed-by: Dragos Tatulea <dtatulea@nvidia.com>
>> ---
>>  tools/net/ynl/ethtool.py | 8 ++++++--
>>  1 file changed, 6 insertions(+), 2 deletions(-)
>> 
>> diff --git a/tools/net/ynl/ethtool.py b/tools/net/ynl/ethtool.py
>> index 6c9f7e31250c..44ba3ba58ed9 100755
>> --- a/tools/net/ynl/ethtool.py
>> +++ b/tools/net/ynl/ethtool.py
>> @@ -6,6 +6,7 @@ import json
>>  import pprint
>>  import sys
>>  import re
>> +import os
>>  
>>  from lib import YnlFamily
>>  
>> @@ -152,8 +153,11 @@ def main():
>>      global args
>>      args = parser.parse_args()
>>  
>> -    spec = '../../../Documentation/netlink/specs/ethtool.yaml'
>> -    schema = '../../../Documentation/netlink/genetlink-legacy.yaml'
>> +    script_abs_dir = os.path.dirname(os.path.abspath(sys.argv[0]))
>> +    spec = os.path.join(script_abs_dir,
>> +                        '../../../Documentation/netlink/specs/ethtool.yaml')
>> +    schema = os.path.join(script_abs_dir,
>> +                          '../../../Documentation/netlink/genetlink-legacy.yaml')
>>  
>
> This seems like a worthwhile improvement to make the tool more usable.
>

Unfortunately, even though in the next patch after this one where I add
the ts stats group as a comment, the tool seems to fail at rendering the
actual counters of the stats group, so I had to use the ethtool tree to
test. I should look into that, so that way other contributors such as
Intel can simply use this script to test that they hooked into the
ethtool ts stats interface correctly.

--
Thanks,

Rahul Rameshbabu