Received-SPF: pass (google.com: domain of linux-kernel+bounces-79281-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
References: <20240223192658.45893-1-rrameshbabu@nvidia.com>
 <4c94d725-a903-4979-bcc6-9353e0869cd7@intel.com>
User-agent: mu4e 1.10.8; emacs 28.2
From: Rahul Rameshbabu <rrameshbabu@nvidia.com>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: Saeed Mahameed <saeed@kernel.org>, Leon Romanovsky <leon@kernel.org>,
 "David S. Miller" <davem@davemloft.net>, Eric Dumazet
 <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni
 <pabeni@redhat.com>, Jonathan Corbet <corbet@lwn.net>, Richard Cochran
 <richardcochran@gmail.com>, Tariq Toukan <tariqt@nvidia.com>, Gal Pressman
 <gal@nvidia.com>, Vadim Fedorenko <vadim.fedorenko@linux.dev>, Andrew Lunn
 <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>, Przemek Kitszel
 <przemyslaw.kitszel@intel.com>, Ahmed  Zaki <ahmed.zaki@intel.com>,
 Alexander Lobakin <aleksander.lobakin@intel.com>, Hangbin Liu
 <liuhangbin@gmail.com>, Paul  Greenwalt <paul.greenwalt@intel.com>, Justin
 Stitt <justinstitt@google.com>, Randy Dunlap <rdunlap@infradead.org>,
 Maxime Chevallier <maxime.chevallier@bootlin.com>, Kory Maincent
 <kory.maincent@bootlin.com>, Wojciech Drewek <wojciech.drewek@intel.com>,
 Vladimir Oltean <vladimir.oltean@nxp.com>, Jiri Pirko <jiri@resnulli.us>,
 Alexandre Torgue <alexandre.torgue@foss.st.com>, Jose Abreu
 <joabreu@synopsys.com>, Dragos  Tatulea <dtatulea@nvidia.com>,
 netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-doc@vger.kernel.org
Subject: Re: [PATCH RFC net-next v1 0/6] ethtool HW timestamping statistics
Date: Fri, 23 Feb 2024 14:47:37 -0800
In-reply-to: <4c94d725-a903-4979-bcc6-9353e0869cd7@intel.com>
Message-ID: <87ttlyvltg.fsf@nvidia.com>
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?TH+Bz4uu/VnlIFnr+nGjtqK9j9XDShNxga9Xka3ozg2teE0MeC+epyTJzj2i?=
 =?us-ascii?Q?ev/jNz1zW2410bkiWp5tr2gQ2dad0q7R50pOX4Q4yDI7dXiZQBZyxvtZyTNG?=
 =?us-ascii?Q?V8hg2+LiwdmKGJfUKBMgMYUK12yBYz2A4LVdBPHj1JgEaN2ZW5dwkhhMvVKY?=
 =?us-ascii?Q?fhEjW7XxvXQBCAiGtDq3RdJDn7m74fQK664yeJfCni3ipJHYPYSiZpuM+Lk5?=
 =?us-ascii?Q?Nzpo+5+6vzChe0NG0ps9SOPcn4+ydklx+aSRLEoPip8A9QE4wjf80HKYpQZz?=
 =?us-ascii?Q?3JMp4mB8qyoOclMz3tVK1EHrcdwjz7JSch1/Xwjc5qtWAXJczoLxzW5tl+Ga?=
 =?us-ascii?Q?RY2/dpPJjRqStjg3My6VKJwHaZekhz1ZaQlYU0w1yhCNJUFeGEcUznEs5uRT?=
 =?us-ascii?Q?sirwuOqOMv0/Vs13ZiloiZKt5MxvzmD49sgbWuwGWFggmt8eO4OMnRo2Vk2U?=
 =?us-ascii?Q?+K4qsO64ZB8xc9xVWzY9dq2A0V47AbxiBrC892jUngsdump1TWr5IzEDq5g9?=
 =?us-ascii?Q?gs6j74oIOFf1p4tsLlpFTsglxcQm75bRa3fzRSdr0Rq451YrbROs+UfB6eF2?=
 =?us-ascii?Q?aRZraBdHfPf89266PLZP4hqBXcwJPslP7wQJz1EPrCDXfhHvMbA0nVpUKtyv?=
 =?us-ascii?Q?OKYsH2X+KcS33fnM+h3orDAx0tXw46JaNth/ZqizKkMMpDqZCP2uZLiNIrkk?=
 =?us-ascii?Q?yuOrDGF3n4JLrOnsbl5F6MW320yauER62WYJ1biPat92ElPhzQMTqM8rJHYV?=
 =?us-ascii?Q?O9ueP4Q8Qq5uHPIlFDvMCEFnj/pb/byjBqAD28FFAMFe0nm0VsY/W+ixYOVe?=
 =?us-ascii?Q?RGja74TmqnOl4uKeGjpd421T71/H88zHMg2O6/FgcAEcMx/i97SxsAo9V3ip?=
 =?us-ascii?Q?5qBv6uJeVBdxta70urHKk5jm0c6iW6Ivl4auItOk2xlt33iwbqD/PVuekkyh?=
 =?us-ascii?Q?yX+TrJY9F7xE+pQ2FMV6QWX63EF5AJGO0xCoawArMNKgJRWtso9RmBpqDda3?=
 =?us-ascii?Q?zvDv0NbCjFMWqaapNlU1eZzR9DMTLZy5MGel2U4hf4UIuiTQBbptrj+9WwaJ?=
 =?us-ascii?Q?noHObl1YuQXpAD16l8Q2MlPphhihPGwx5vzFGnAR6pKEUf+uL/6DmxXvYwZD?=
 =?us-ascii?Q?+f23ALY4ECA/x3VpXyepRVuyJQdlg/B8HI5TXRX8uQr6wxgrWR0yMFclmw8W?=
 =?us-ascii?Q?KQj6miJ7lhG/6ZaZqusRX4K0L1DPmzT+AFHKykyool+y3jME1N9qw+/zs68x?=
 =?us-ascii?Q?U5VaxEVnyerzkdbrN0faWqaFjNRNstLEzPTKBSAorAnMsphyJlO6YuHJNvjf?=
 =?us-ascii?Q?iwkG89JXGsZCwpL1CD1fw8WL4GxsSUARjoKRcEfSJS4A3OGc9eSkxRO1GB8s?=
 =?us-ascii?Q?7mNNU73evTr0mhWZqMyWkDeQCAFeL4KpMZetLnS/OQVd2BgnL3v/KR+T+aFd?=
 =?us-ascii?Q?ujJ/f7zLsQfw3xoY8y8PI4JrOxhoVHlSMikGuS/Y6dicoELpwtSZ0PO8MSwd?=
 =?us-ascii?Q?F8MC+jHXQVZqLnWn8iaH8w2dMQaRR3ZDp5w3D2sWW/LMg56MqTvxZvn/839B?=
 =?us-ascii?Q?wWAwTe09wN543CYpicArCR7YitI0uOBlnPaGepHzHBAk4yVHh7+WjpP1Ma2A?=
 =?us-ascii?Q?Jw=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 01c89f25-43a0-4db6-7923-08dc34c196c1
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2743.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2024 22:48:44.3701
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bsAgWbmzXi/MAJitROw2ynIk151hni7k4zeWYbGA/iJypzQKy7JS7saaGnYNpYXsdW9g99KOi86eNuTJOAkaNg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5276

On Fri, 23 Feb, 2024 13:00:10 -0800 Jacob Keller <jacob.e.keller@intel.com> wrote:
> On 2/23/2024 11:24 AM, Rahul Rameshbabu wrote:
>> The goal of this patch series is to introduce a common set of ethtool statistics
>> for hardware timestamping that a driver implementer can hook into. The
>> statistics counters added are based on what I believe are common
>> patterns/behaviors found across various hardware timestamping implementations
>> seen in the kernel tree today. The mlx5 family of devices is used as the PoC for
>> this patch series. Other vendors are more than welcome to chim in on this
>> series.
>> 
>> Statistics can be queried from either the DMA or PHY layers. I think this
>> concept of layer-based statistics selection and the general timestamping layer
>> selection work Kory Maincent is working on can be converged together [1].
>> 
>> [1] https://lore.kernel.org/netdev/20240216-feature_ptp_netnext-v8-0-510f42f444fb@bootlin.com/
>> 
>
> Makes sense! I like this direction, I had meant to work on this for the
> Intel parts, but got sidetracked by other tasks.

I still have a back burner task for a cyclecounter API change you
suggested a while back.... Hoping to get to that after getting some
large features out of the way in the next two months.

--
Thanks,

Rahul Rameshbabu