Received-SPF: pass (google.com: domain of linux-kernel+bounces-79299-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <ede77e93-1bb3-4bd1-9c05-919ad512c2e1@intel.com>
Date: Fri, 23 Feb 2024 15:11:11 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v6 0/5] selftests/resctrl: Add non-contiguous CBMs in
 Intel CAT selftest
Content-Language: en-US
To: Shuah Khan <skhan@linuxfoundation.org>, Maciej Wieczor-Retman
	<maciej.wieczor-retman@intel.com>, <shuah@kernel.org>, <fenghua.yu@intel.com>
CC: <linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<ilpo.jarvinen@linux.intel.com>
References: <cover.1708072203.git.maciej.wieczor-retman@intel.com>
 <f8886683-4f24-47ce-a0c6-ef28466bfec9@intel.com>
 <685828ed-06d2-4a2c-9911-05145e55ea1a@linuxfoundation.org>
 <48dab897-162d-4075-baa9-f5391a23d31d@intel.com>
 <a8f1f104-c5c1-400c-873e-99b01cde1d88@linuxfoundation.org>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <a8f1f104-c5c1-400c-873e-99b01cde1d88@linuxfoundation.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cmFmRURqMWJac1NxbG9sVlNpZkpTbHN1dlpTZ2QwNU9MMk5rd2I3UlV5V3Iz?=
 =?utf-8?B?bnFyZzZQUm90Ry9CWjJqSHpYVmJmVEtaR2lsTVNJK01MRmNLSVpFODk4NWtx?=
 =?utf-8?B?OEJWTE45ZmxEUnpKdHZWSWluZTZ3c3E1bzNDb00zR282bHBYTEVUOVJPMmRI?=
 =?utf-8?B?TXRxelM1Ni9YZXFNaGZhVUZ1RG5WcUZDVjJoMnJFM0t1Nk9aWEJVcSswSGtz?=
 =?utf-8?B?YlFyVEtVa2o1T2VzY05pek5ZZXlwbUlvcE1ObDJFMmVIU2ZMMTNXWk1tOVlP?=
 =?utf-8?B?eXdleVlma0dkWU1mTXRaV2hXMk5BZ1dCeHFxNWtWZWNsM2I0ZWduUUVzY1ZU?=
 =?utf-8?B?ODM1cUZMaEo1KytqQVFVdDNWbmpkaE9BZ3RVL0FLWUtTL213YTRiQ0t4UUNz?=
 =?utf-8?B?OU1nR3FEUkxZcDFUaGYwT1ZUSU91WTJTakZlcW9NTWZVTVdLcHlnYTN5ampY?=
 =?utf-8?B?ZHJRWFdHZUxyc1cyRWR3ZytZWTVYT0NWZk12aDJvU1NRNUtmbGNRMy8wWkVW?=
 =?utf-8?B?YUo3WHNjckxDWDQ2RWtBVU5ucUViZzlnYWVMcktTN0FUNnI5Z3hTMTVoc3hB?=
 =?utf-8?B?TnVqL2d0SDdqTDIvUVgvRlpmYStqNUJxbTg1b2Q2TGJ4bzNjMDkybUZGWE1J?=
 =?utf-8?B?c3J6UWxHNnFIY2paTVlPMUs4MGlZMDJxTGpEajdDWDYxdmlyeVQwVWdQNTYx?=
 =?utf-8?B?cjQ0Tm56K01BYmZqZTU2ZWRmQ09hcml5UVRweHc5R0UzaGg0dzRxTHhVcmRV?=
 =?utf-8?B?cTFYZHMvd0ROQnZQdUJiU3lYZjRKL00rV2t4OGMyMWYvOWsvWTRQTGVzdzBR?=
 =?utf-8?B?anJMWTduMldRMjFHTnFsT3NDV21XZzdobnlmV2pFcFhFTk9WbVRzQ0xmK2Fw?=
 =?utf-8?B?eHdmVVlHTFpWV2d3YzdvbEY0Z09RVVI4dTRFUk9SdTNJNml6WFVFOVNhcnBF?=
 =?utf-8?B?NFI2WVRqM1RSaUhhWmJlODFjUGw0N1BUejFWUStvaUUxRzQzRUhQS2FIa0Ir?=
 =?utf-8?B?ZHIzQTRzZGttdmNoWjlRVmZOS3k2Q1hDSHEzZUpUbU1IVzNRNFRXZDZ2alI3?=
 =?utf-8?B?cE1KMXVRVVBCbFd3SzhWbXFhRnJTdVl4KzFwTXdVeGRuVkR2OWtMRWRBa1o2?=
 =?utf-8?B?SlhaNi9kR01hUXpGQi9kb2E4aWRMNnZMQ2hvc1IyYjZhNzF5TExvaE1ITVY0?=
 =?utf-8?B?TWFJUHV1RzBseUVJYytGWElsM0JhMXV6dVZmTXU2c085dSt6ZjhDekdiOVJs?=
 =?utf-8?B?WHFvNGhnTTB4cFMyZU8vZTIycWs4c2s5L1lGNW5yRnFnYUFpTzNEblJHWU9n?=
 =?utf-8?B?M01NWlgxbWJtWHl3ZTU3MWlLU040VlJaVnY3bGcvNXoxQnVlcXgyK1ZHWURQ?=
 =?utf-8?B?Q3JWQmRueFlpTjVIZFg3b0VGNlI3ZGRPMHVZbmtGWVdwUG54N1hLM05MUUN6?=
 =?utf-8?B?VzlwM3pSUGFYSmkyRnV1eEtuWElHayt0RmZnTWdUTkMvaTVjcTJaTTZVaUZp?=
 =?utf-8?B?eHhveUtIUmZKclVzTkNFWjlPV3cvVnUwOEN0bEF4aUdHNWNwMjF6eW1wemZ1?=
 =?utf-8?B?QWhsVDdzcGpNMXJBY25TNlozRHliZ2VYaWtYUEJwRFBGS3FTZGVHNVlIMTdq?=
 =?utf-8?B?U21XWFVreGVBU0hzaEZnMHB6NVgyNmdMLzh3UzFxMTRnc2FISW5ZOHd2SFBq?=
 =?utf-8?B?eDdSNHpyM3V5bGJxTGdsSmFHWnM4ZU93Y05NYXRvTFFQYlE3ZThxZFdPWjZo?=
 =?utf-8?B?Z1FNM2FEL1ZmeWlpU1JNSzdzVHhLNlRzbU1rYjdUanFzallKaTc5TVpMempX?=
 =?utf-8?B?OUJuaW9uSVUxOVFlTkg5OWp3bEZNa2k4S0hVRkRlUTJ5MDF5MTUvQUYwOVNE?=
 =?utf-8?B?WXdJbzZlZ1huVHZKRHF2SkRsQUxzMnUyMVJDVXJkbnlyNnVhdWVwRGVlR1hW?=
 =?utf-8?B?TzNwR2V6ckRPWUg4Vk9raWZVVTdmalFObFlpV0VUUFN0VFk0S3g4M3R3U3hR?=
 =?utf-8?B?a011N0d0Q3VSK2tUSU5PeDUyQVQrWnBLd3JuczlwTUxjWWtHaUkyWFN6eEh4?=
 =?utf-8?B?TjdscUNaZDkzcVBNVzVjTlQvNERHUVRqN2NsQzNUOWxZNEFoYnoyN2lQSmZt?=
 =?utf-8?B?R2pLVHhqZXUzbjY2WlFsU0RFamxXK2VWRmh2YzBCbzJ4ZXRHc2RZZkVMYU5S?=
 =?utf-8?B?V3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f696903-0827-4ff9-fc82-08dc34c4b9ea
X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7566.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2024 23:11:11.8321
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1ym2mUxHRTTYcXBJ3d95mzJ7zLydph209hwnFEY27XUh90UPbiicJf4Wq/6jwmLDV41vlf9OccWQ3Ixz/bSZfBEc90UgholJzR4f2nLluHs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR11MB8758
X-OriginatorOrg: intel.com

Hi Shuah,

On 2/23/2024 2:37 PM, Shuah Khan wrote:
> Okay ran a quick test. Why does this test leave "/sys/fs/resctrl"
> mounted when it exits. Can we fix this to unmount before the test
> exits?

This is unexpected. The test should unmount resctrl when done and I am
not able to reproduce what you are seeing. I tried with resctrl mounted
as well as unmounted before the test run. Could you please send the output
of your test run to hopefully get some hints about what is going on?

Please do note that resctrl does create the mountpoint upon initialization
so you should always, for example, see /sys/fs/resctrl, but it should
be unmounted and empty after a test run.

Below is what I am seeing when I try latest from kselftest next and mount
resctrl before the test. I see same state after test if I do not mount
resctrl before the test run.

./dev/linux$ mount | grep resctrl #not mounted
./dev/linux$ ls /sys/fs/resctrl/  #empty
./dev/linux$ sudo mount -t resctrl resctrl /sys/fs/resctrl/
./dev/linux$ ls /sys/fs/resctrl/  #has contents after mount
cpus  cpus_list  info  mode  mon_data  mon_groups  schemata  size  tasks
./dev/linux$ mount | grep resctrl #shows as mounted 
resctrl on /sys/fs/resctrl type resctrl (rw,relatime)
./dev/linux$ git show -s --pretty='format:%h (\"%s\")'
ae638551ab64 (\"selftests/resctrl: Add non-contiguous CBMs CAT test\")
./dev/linux$ make -C tools/testing/selftests/resctrl/
make: Entering directory '/home/reinette/dev/linux/tools/testing/selftests/resctrl'
gcc -g -Wall -O2 -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -isystem /home/reinette/dev/linux/tools/testing/selftests/../../../usr/include     resctrl_tests.c cache.c cat_test.c cmt_test.c fill_buf.c mba_test.c mbm_test.c resctrlfs.c resctrl.h resctrl_val.c  -o /home/reinette/dev/linux/tools/testing/selftests/resctrl/resctrl_tests
make: Leaving directory '/home/reinette/dev/linux/tools/testing/selftests/resctrl'
./dev/linux$ sudo ./tools/testing/selftests/resctrl/resctrl_tests
[SNIP]
./dev/linux$ mount | grep resctrl #umounted after test run
./dev/linux$ ls /sys/fs/resctrl/  #empty
./dev/linux$ 

> 
> Please send a patch on top of linux-kselftest next.

Will do, as soon as I can figure out what is going on.

Reinette