Received-SPF: pass (google.com: domain of linux-kernel+bounces-79302-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <95e8cc82-2e7e-bca9-16ab-3148c3183f32@intel.com>
Date: Fri, 23 Feb 2024 15:15:59 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH] igc: fix LEDS_CLASS dependency
To: Arnd Bergmann <arnd@kernel.org>, Jesse Brandeburg
	<jesse.brandeburg@intel.com>
CC: Arnd Bergmann <arnd@arndb.de>, "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, "Paolo
 Abeni" <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
	<intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
References: <20240222100324.453272-1-arnd@kernel.org>
Content-Language: en-US
From: Tony Nguyen <anthony.l.nguyen@intel.com>
In-Reply-To: <20240222100324.453272-1-arnd@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TmhiNEliblNtaklIVi92U2xZNUd0K2htNkY0U2RVOEdIT1hLS1FMNmp5YVBE?=
 =?utf-8?B?N01JYVY4WC9CNzFhZDZFRngzb3orSXNWSkNWOG8xZklRZXUrQ2xFZ3pxVG5K?=
 =?utf-8?B?TGt3bjdWNW9PWHVDY2dRNUN2K081dWJTc1ZubEZibWk1Yzh3cTVza3o0b3Vx?=
 =?utf-8?B?Rm16TDJZZGd5bFJ1OTBkOXdzTTU2a3N3QUd1Y0ZuN2tMQlhkZTFJeVBUUmdH?=
 =?utf-8?B?anZYendLUitMKzNISis4dCtDczI3ZWNBem0xR1NlSHhUWW04VDhjV1MwcHEx?=
 =?utf-8?B?RWxsRjlUTDFjQjZYeE1PeUxRemxaMnV0dXBNN3FxR25rNTd0MkFscnNhNEZs?=
 =?utf-8?B?bTM1YVhwMWNwM3lNczRIMkRVWmc3NWdla3BoK3NkNW13aW5ONlo5THc1Mjc0?=
 =?utf-8?B?b0c0QnRqTFFvMkJkUEpoeklHbDBjcGcwWHNlVkx6a0Q5V2tFc0MwYnJZekUx?=
 =?utf-8?B?TXU1U0k4UzhnVzQzNUhzVHlJQVc2NjYvK0pFSGowdXF5ajg3enVNdyswcGdJ?=
 =?utf-8?B?ZTV5cUQvU0hRVkJuUG8xaHRqbGtESWR2MzFaK3lSbFQvZE9wV09pKzhodVR3?=
 =?utf-8?B?cDhNWCszd0JLQjdSTDA4SktwdDVtRVZRc2tLcEJwbWZrNXM3Yk1KVTh0cUdz?=
 =?utf-8?B?cU9XU3VUV25mMGpmOTNVYlZ0c2Qwb3JpSVEvR0RuWko5S1hla2t0d28rZUNx?=
 =?utf-8?B?VXpHd2Vob3JBN2NPYjV2U1oxTk8rclNaaDJBbmt4WnpKREJWeW9tcEZnSzY1?=
 =?utf-8?B?KzdTYk81Vmg1SzNMSmFlREVodHNrSEJ6bTRWajgycGpHMElET3RVLzlKb0lD?=
 =?utf-8?B?aS80MXdpcU9XRll2UTZLTTZ2MDlnTG9MMU1lT1A0bUUyd2lXU0h1TWpRUHZm?=
 =?utf-8?B?MWYwUEhiemlXVlc1dnI0dk5mMkpVWmJZcXpxMTdXV1BJaE5Dd1lZdXhmbU9o?=
 =?utf-8?B?Nm0zYVlXNUJ0WW5Hb2xLS0prQWtabE0rU1loanFacTZQblNXS1VsZFNZOHRT?=
 =?utf-8?B?cnBKN1Q0ZDBnZkZadk5OVXZ4YVpxK2Y5WTlEKzBUZmM0N05xZENVVjV2VE9k?=
 =?utf-8?B?VFkrSytxbnR1WUpENlVmYzI5YzlrekJtVnQ5cWJacEZ0Rk5yQWlqY0Q4WkxV?=
 =?utf-8?B?d3h1cmtRaW4ydktWOXR3ZGhza2lxNVlaUlhMZTMyR2ZwbElYdDJFc3Z6dURY?=
 =?utf-8?B?elo0RisxZEJGOFFLdjFUK1YzeUN6bDZuNHk1ZXZXVUFtYzNTM3I4Z0ZHNSs0?=
 =?utf-8?B?RmRLL2h5MHFUL1ZKd3FpRTM4YzFQQlRtS1FuL295Nk40NllJejBWZ2c4clVZ?=
 =?utf-8?B?WXAwWlZERWMxUHVubGhmUXFzWlFjTGhHd09vdTNkQjJob2pLbVJ4Q0V0TmpC?=
 =?utf-8?B?b28zU2J4TmxoTDAvWXRUK1FrWGxUVHF0czJtYjJHcmVPSThua2xGOVpJY3hD?=
 =?utf-8?B?a3djTGpkSUxTMHI0cDNIZm45ZGlSN0dCU1R2cTROREV3K0VzWlBBbHBPaVZr?=
 =?utf-8?B?TERsa3ZEcnJEWG0yOERmVis4SXB0QU1rR3JoOGFyc3hGMy92Q1Q5d0FjY09T?=
 =?utf-8?B?WFJVbW5EalZUeVdaL3d5cFhZU1NlWU9taTd1NkloVGkwUU1zMGRiKzcvcWlw?=
 =?utf-8?B?Tmd3bU1NWG0zUitFczNHcGx3V2hrZzdZcDU5WmxVN2h2cXo5bjR2c1Z0UWgw?=
 =?utf-8?B?Yk5DVmlTUzE1MDZidm12M3ZVWE9uM2VXZE9GOEhXMXZrUUJzVGlJaHBNVDNN?=
 =?utf-8?B?eEFTYTZLQUFXa2FtZGRQTWRsOVk3QjROcGxwano2RHVtSmZ3MVgybTljcC9D?=
 =?utf-8?B?TXE1clFYMEhhUGZLb1lIb0RJVTJNVklZUlpjWnRTcEg2WlQ3ZVc3UU1QdXBZ?=
 =?utf-8?B?azFZeFlhc0ZjYXFLZnlPRVpiOHZVRHhJbDRWSUJjMXY3SEQzQWZQbWNLSFcz?=
 =?utf-8?B?TlBjdGlCR0ZQV0lUeEJXbFJiVlM4Rk5mYTMrUUxFQlJzMFhCM1lJQ055RDI0?=
 =?utf-8?B?Y3AzTVZjNVJIUndmVHYxNGhyOW1JNVFGZkQ3dGM2RFpEWnFTUk4vczQyWmQ5?=
 =?utf-8?B?WTVFZCtKSDJwUnc2SVowT3hVYVhnbzZJTlhsNTBiWWc0eEtmNGMzUjBwVmVo?=
 =?utf-8?B?bE1mQ1FhYi9uaGs3WWJqS1BXY1F2ajJaaGtKam1lNzdLTkpSVDVNbHNFTjF0?=
 =?utf-8?B?dHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bc468853-1b26-4492-4362-08dc34c566de
X-MS-Exchange-CrossTenant-AuthSource: BL3PR11MB6435.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2024 23:16:02.0909
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NVKa8bfSkXtkh+12444a+Mp5Vh/8rRYdkWGHFbAxptqIqR18xcWrZMrgoj7AUq/xS1kv4/jCVAX0QWhZojbtviigaRkRAbECAcqDfS3MrKc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR11MB8661
X-OriginatorOrg: intel.com


On 2/22/2024 2:02 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> When IGC is built-in but LEDS_CLASS is a loadable module, there is
> a link failure:
> 
> x86_64-linux-ld: drivers/net/ethernet/intel/igc/igc_leds.o: in function `igc_led_setup':
> igc_leds.c:(.text+0x75c): undefined reference to `devm_led_classdev_register_ext'
> 
> Add another dependency that prevents this combination.
> 
> Fixes: ea578703b03d ("igc: Add support for LEDs on i225/i226")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>   drivers/net/ethernet/intel/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/intel/Kconfig b/drivers/net/ethernet/intel/Kconfig
> index af7fa6856707..6e7901e12699 100644
> --- a/drivers/net/ethernet/intel/Kconfig
> +++ b/drivers/net/ethernet/intel/Kconfig
> @@ -372,6 +372,7 @@ config IGC
>   config IGC_LEDS
>   	def_bool LEDS_TRIGGER_NETDEV
>   	depends on IGC && LEDS_CLASS
> +	depends on LEDS_CLASS=y || IGC=m

I don't know kbuild that well, but would this cover LEDS_CLASS=n with IGC=m?

There are Similar checks in the file [1][2] that would transpose to
  depends on IGC && LEDS_CLASS && !(IGC=y && LEDS_CLASS=m)

which should cover that and keep the checks in the file consistent. IMO 
a little more readable as well.

Thanks,
Tony

[1] 
https://elixir.bootlin.com/linux/latest/source/drivers/net/ethernet/intel/Kconfig#L109
[2] 
https://elixir.bootlin.com/linux/latest/source/drivers/net/ethernet/intel/Kconfig#L161

>   	help
>   	  Optional support for controlling the NIC LED's with the netdev
>   	  LED trigger.