Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp145471rbb; Fri, 23 Feb 2024 15:16:57 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXk6MhNsTc+xiWk/ixqGFRseiKHBwPc0JbtB6hCWMBnv7YSREmgVuaHOP/vCGNo7FyzFJZo5cdKrblT2UOP7pLPC+OhCmitJTh/5ZX80A== X-Google-Smtp-Source: AGHT+IF8XoC5O9UQdBOyvLef2Ijp+7sWxYsO3x27II7102uUnsuxw01IbItoRM31nZp0p2/L9zE+ X-Received: by 2002:a17:906:491b:b0:a3f:9b98:87e7 with SMTP id b27-20020a170906491b00b00a3f9b9887e7mr781828ejq.27.1708730217345; Fri, 23 Feb 2024 15:16:57 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708730217; cv=pass; d=google.com; s=arc-20160816; b=SO0qPSPXR1Efzv/OuDuykFI2cucJgpC1e6rCdynDX+O0YD2ZFIMkYL3YfMMjM7uxGz mtY3r56CRkEcFHrQdNkGPp3gG9gjFt9DCkfvu2Cm8ibtmGE/12SQqehsPrBg75DtCEVb DFae/7ntH1cZG88LE9eVrJNnO0nTZiHhMpC+Ql/R9rHvZ/CyTjPFt+abr2GOUZDgBpCg augsbHgCbnAhPVULnVs7tS6Mxgja7qoPkiL397iaHTPsL6o1WUBWBSjxfdxUgRmB0Z1V no7lLzFFUP6BTIZkIURq7phqNFKlLls/RTU9yBJEWB4Bqf0Z9qw3NbH4g7XrIZ+sCVSP UGcQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ppx1ytb4Z5XMnVomPwe/hSvw18GYGbq/qxUl7v7Ia/g=; fh=vJ40lK6l3ZbCS7HIjKStuxiIKpLJRcyIl3NTd5BU2GM=; b=eIeRlwNIUwP8Yr46fm59lKhq43EMTYXaAE5mZoLj6vpLaILBcmasIy21NpT7BHCFLQ xxVUAaMbR7ygw5PnUfUpxS/Tq7JKZ7Ns96LUurPkxHimxAazsGraWLn9YMYmsxEHPjcI KQYZRDC6CIYYyMLZ1MI+Otps4tokc/NrwCSS8a9kLV7wFs7h35mbMW2DcyvhC1bgNOH+ wPYFYwaNiIyCn7yY9HSGLAjng8WwrIbI+cwgYPYMOLZwbb+ZHYtQYlYLPELeUXP69u12 fXR6h3DcfTA1fv650hfMZ2/VZnzC5JI6eouYb82G3u8X9QU0zzykc4xYtQ0FbXCu3NwP Lk5Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@bewilderbeest.net header.s=thorn header.b=PG+nMijZ; arc=pass (i=1 spf=pass spfdomain=bewilderbeest.net dkim=pass dkdomain=bewilderbeest.net dmarc=pass fromdomain=bewilderbeest.net); spf=pass (google.com: domain of linux-kernel+bounces-79304-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79304-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=bewilderbeest.net Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id h20-20020a170906261400b00a3d00ac3c3fsi29351ejc.1010.2024.02.23.15.16.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 15:16:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-79304-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@bewilderbeest.net header.s=thorn header.b=PG+nMijZ; arc=pass (i=1 spf=pass spfdomain=bewilderbeest.net dkim=pass dkdomain=bewilderbeest.net dmarc=pass fromdomain=bewilderbeest.net); spf=pass (google.com: domain of linux-kernel+bounces-79304-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79304-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=bewilderbeest.net Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 1EB081F2147F for ; Fri, 23 Feb 2024 23:16:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3C0B814DFDC; Fri, 23 Feb 2024 23:16:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=bewilderbeest.net header.i=@bewilderbeest.net header.b="PG+nMijZ" Received: from thorn.bewilderbeest.net (thorn.bewilderbeest.net [71.19.156.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B366514DFD9; Fri, 23 Feb 2024 23:16:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=71.19.156.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708730196; cv=none; b=mZENTp3CPDycEQsFeDVpkCPOxGYwETaERRsZJA1+h3MlIru23c4tN3i3aITufa5sII7iXCOyzLC/HYQkcrvZWqXN9tZkznF4o9KbB91s1a5YczQO8XK8lHct7/nv5l65DXXVYiIsYhLv2oCBYcrZTe4Xsrc0kkoeLvN4G13Wil8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708730196; c=relaxed/simple; bh=sD5o9ytpcDH7D0YW0iwMBjx+SPKuqMrI8GiCcndNMzA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=in25oqUyZXr6yvneiujeRmyQBYilJDMpDorAV88LAufafCkFC5gq6+BBI/64Fw0ZBdr+Rg04kZAQzibi2hMbj9l+mCWMusqFpv4uRlI8X0yBPJefajFg1lxfdDjTOoDaAuJD+rfjS90yyuYKI9I/+Re9UXrhaYxCCQhkDlCovQc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bewilderbeest.net; spf=pass smtp.mailfrom=bewilderbeest.net; dkim=pass (1024-bit key) header.d=bewilderbeest.net header.i=@bewilderbeest.net header.b=PG+nMijZ; arc=none smtp.client-ip=71.19.156.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bewilderbeest.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bewilderbeest.net Received: from hatter.bewilderbeest.net (unknown [IPv6:2602:61:712b:6300::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: zev) by thorn.bewilderbeest.net (Postfix) with ESMTPSA id F1421432C; Fri, 23 Feb 2024 15:16:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bewilderbeest.net; s=thorn; t=1708730188; bh=ppx1ytb4Z5XMnVomPwe/hSvw18GYGbq/qxUl7v7Ia/g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PG+nMijZMei0y1HU+vJalvgYAtcV45FvoFJVUaVP3SYrst6foDMu2IPkKTv1DhJFL TZRy96Psq3i9GHxw1YpnfuG5Q9c+hvzlsEAwkIF8JuXliMVHoNpc4YwnXl/qhFDrcS WMxYPRkJEZsXgleLZm8CHNf0PbYxjFq+ynQoT/fA= Date: Fri, 23 Feb 2024 15:16:26 -0800 From: Zev Weiss To: Conor Dooley Cc: linux@roeck-us.net, Conor Dooley , Jean Delvare , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Liam Girdwood , Mark Brown , Patrick Rudolph , Peter Yin , Alexander Stein , linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Naresh Solanki Subject: Re: [PATCH v2 4/5] hwmon: (pmbus/lm25066) Use PMBUS_REGULATOR_ONE to declare regulator Message-ID: <684ee927-2287-420b-aee5-f323e05ada47@hatter.bewilderbeest.net> References: <20240223-moonrise-feminist-de59b9e1b3ba@spud> <20240223-player-buckskin-01405c5889c4@spud> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20240223-player-buckskin-01405c5889c4@spud> On Fri, Feb 23, 2024 at 08:21:08AM PST, Conor Dooley wrote: >From: Guenter Roeck > >If a chip only provides a single regulator, it should be named 'vout' >and not 'vout0'. Declare regulator using PMBUS_REGULATOR_ONE() to make >that happen. > As mentioned on Guenter's v1, this change necessitates a corresponding update to arch/arm/boot/dts/aspeed/aspeed-bmc-delta-ahe50dc.dts, which has a dependency on the name of the regulator. Given (AFAICT) the lack of any combined dts & driver patches anywhere in the kernel git history I guess maybe doing both atomically in a single commit might not be considered kosher, but could it at least be included in the same patch series? Thanks, Zev