Received-SPF: pass (google.com: domain of linux-kernel+bounces-79310-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 23 Feb 2024 15:26:47 -0800
From: Zev Weiss <zev@bewilderbeest.net>
To: Conor Dooley <conor@kernel.org>
Cc: linux@roeck-us.net, Conor Dooley <conor.dooley@microchip.com>,
	Jean Delvare <jdelvare@suse.com>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Patrick Rudolph <patrick.rudolph@9elements.com>,
	Peter Yin <peteryin.openbmc@gmail.com>,
	Alexander Stein <alexander.stein@ew.tq-group.com>,
	linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Naresh Solanki <naresh.solanki@9elements.com>
Subject: Re: [PATCH v2 4/5] hwmon: (pmbus/lm25066) Use PMBUS_REGULATOR_ONE to
 declare regulator
Message-ID: <2a06f633-9dd2-4ef0-8cb8-901348ef404a@hatter.bewilderbeest.net>
References: <20240223-moonrise-feminist-de59b9e1b3ba@spud>
 <20240223-player-buckskin-01405c5889c4@spud>
 <684ee927-2287-420b-aee5-f323e05ada47@hatter.bewilderbeest.net>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <684ee927-2287-420b-aee5-f323e05ada47@hatter.bewilderbeest.net>

On Fri, Feb 23, 2024 at 03:16:28PM PST, Zev Weiss wrote:
>On Fri, Feb 23, 2024 at 08:21:08AM PST, Conor Dooley wrote:
>>From: Guenter Roeck <linux@roeck-us.net>
>>
>>If a chip only provides a single regulator, it should be named 'vout'
>>and not 'vout0'. Declare regulator using PMBUS_REGULATOR_ONE() to make
>>that happen.
>>


>
>Given (AFAICT) the >lack of any combined dts & driver patches anywhere 
>in the kernel git history I guess maybe doing both atomically in a 
>single commit might not be considered kosher, but could it at least be 
>included in the same patch series?
>

Ah, except I realize now I neglected to pass '--full-diff' to 'git log' 
when checking that, and after fixing that I see there is in fact some 
precedent for commits changing device-trees and driver code together, so 
ideally that would be my preference here too.


Thanks,
Zev