Received-SPF: pass (google.com: domain of linux-kernel+bounces-79443-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 23 Feb 2024 18:31:23 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Cc: stefani@seibold.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] kfifo: add kfifo_out_linear{,_ptr}()
Message-Id: <20240223183123.59efd1d637cf33b9f24d6b2e@linux-foundation.org>
In-Reply-To: <20240223115155.8806-4-jirislaby@kernel.org>
References: <20240223115155.8806-1-jirislaby@kernel.org>
	<20240223115155.8806-4-jirislaby@kernel.org>
Precedence: bulk
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 23 Feb 2024 12:51:54 +0100 "Jiri Slaby (SUSE)" <jirislaby@kernel.org> wrote:

> +	return min(n, __kfifo_peek_n(fifo, recsize);

When things like this happen I wonder "was I sent the correct version"
and "was this tested" and "wtf".

Please confirm that with this patch:

--- a/lib/kfifo.c~a
+++ a/lib/kfifo.c
@@ -497,7 +497,7 @@ unsigned int __kfifo_out_linear_r(struct
 	if (tail)
 		*tail = fifo->out + recsize;
 
-	return min(n, __kfifo_peek_n(fifo, recsize);
+	return min(n, __kfifo_peek_n(fifo, recsize));
 }
 EXPORT_SYMBOL(__kfifo_out_linear_r);
 
@@ -609,4 +609,3 @@ unsigned int __kfifo_dma_out_prepare_r(s
 	return setup_sgl(fifo, sgl, nents, len, fifo->out + recsize);
 }
 EXPORT_SYMBOL(__kfifo_dma_out_prepare_r);

we have a fully tested, production quality kernel change?