Received-SPF: pass (google.com: domain of linux-kernel+bounces-79456-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <8367be41-c4f1-f82d-7490-c83647de7a30@oracle.com>
Date: Fri, 23 Feb 2024 19:19:29 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH 1/1] x86/split_lock: add the source of exception to
 warning logs
Content-Language: en-US
To: Dave Hansen <dave.hansen@intel.com>, x86@kernel.org
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, hpa@zytor.com,
        linux-kernel@vger.kernel.org, joe.jin@oracle.com
References: <20240223094746.11305-1-dongli.zhang@oracle.com>
 <8e4c2001-9fac-48a4-a177-dd6472eb3643@intel.com>
From: Dongli Zhang <dongli.zhang@oracle.com>
In-Reply-To: <8e4c2001-9fac-48a4-a177-dd6472eb3643@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?ZFBaNE03czl0QnlrVzBlZ0ZlZzVaZnNIcnNBTm40bWlzTkdvcW5mWEllNnBK?=
 =?utf-8?B?VlE5TGpPYzhjV3pEbDc1dE44ekNKcUVjRkZlVmJoemdFVnI5R2JOYi9hN3hi?=
 =?utf-8?B?RDBRU2RJRTY0TFZzcVVKTXFoeXNYVXkzK0dXK0svVGthenYvUDI1TlgxZnIx?=
 =?utf-8?B?M0t6TXM4UEJqaU1EWGp0TmdSbE14L2NackVrUXRITWMxR0tyTGUzVG5zQ0xr?=
 =?utf-8?B?OWxGaXlVempWUXc2eTlNdVhoSjRmWS9aZ1NBTkJQN291bWtNQm0ya1BDYi9l?=
 =?utf-8?B?M09YQXkvNUNuUDdvY3Bjb2NGY0V2Vm9wRmp2RkpBcm5FaWtkbit0Nlh6QUEv?=
 =?utf-8?B?ME9hWTIrWEZsMm5YZHovRkhocWpGVzJlQUIrMCtoY25BVmE4Z3k2UHFlZGN1?=
 =?utf-8?B?a0kxSTFYbXczQ0x5bVlxTXo3WWRVdCtQVHEyRGFPQ20zWnExVEhNdzU0RHVO?=
 =?utf-8?B?TkI4M3FtZlAzNVFySVkvK2IyVERyVm5IRGtyZmlrb3BGZ2F3bW1hQnRBUld3?=
 =?utf-8?B?c1NHUTFvK25PZGs4Ynh2bEJ5QTZJYWdZZVU1dXdFUTJrWS82MU9EQTg4OU1l?=
 =?utf-8?B?U3hVT0xZUGdaSmxPQjcvMHA5SEI0VnZyNzh5bW9pMytrQ29Ybm1LNTNvdlJp?=
 =?utf-8?B?Qm1JTkFud3hVY0JuMGg5UUtTRTk0NmJNSXJNME1sZUxyZ2x2U21DcDUwNm5v?=
 =?utf-8?B?ZEgxTlBFaSsrVzNGM2x0MUQwWmRuN3dNVllORVRXTWFEYndrczVWSko3Nmc0?=
 =?utf-8?B?d2xJOG41RzBHaWFIMTdOQ0NQSUZaSGo1TUhBYnFqVUNsZm9zY0tUYjAwTjU2?=
 =?utf-8?B?eStFZmRGbGhhc0p5MXJQN1ZvUk90L1J5YWhRMVpkdHZJTmE4eHNSQ3RaOVNT?=
 =?utf-8?B?TVBCNXpKdDJxSnRQTmI1TjZxSFpYYmV1dVJJbloxS21mTDQvak16NmQ2VlRz?=
 =?utf-8?B?b2FocjdOWkp2ZkZ0ZlNweE5semxXbTAweGpBOGpEdzJNY1dvUkZWeHNOV2hI?=
 =?utf-8?B?QldkTzFLaUlJNXgxT3Uwc3RsbDhwY1c5ZmhHTjlOWmJUUndBYWxQL2dNdUZs?=
 =?utf-8?B?NG43WUtTM2hyOTZTVERqR00zdXV6Ulp1T3pyLzdmMnNDY3RmMGptaGN2VnpO?=
 =?utf-8?B?OHVKYm5OMkNLWVUvQUt3RFQ3MGQyWnU1VkNNQXNVUldSZ2h1ZnZRRHphaThY?=
 =?utf-8?B?MWZzUmVDYnNRWmg5NVJGNkNsdnRnQnlyVlVJc3ZwN2pXOHR6cW5CLzFCVnF6?=
 =?utf-8?B?dUpmamFEeHJ1ZzhnYVF1am9XK05tWjgrZ3VraE1Kd2h0MHNZeFJHNWt0K3VN?=
 =?utf-8?B?OHZCb3hDSGxMdFlybDNydU0zSnlkN1dDRit5YW1SM0JrUzZoNFZzUEtubzY4?=
 =?utf-8?B?Ry8vV20rL0FDWHNLOGx0c2g4cjdOdWFtN1h0MVZIajdld2JMYUo3SmV4R2dN?=
 =?utf-8?B?WWE3UHhNREFxR0ZvdGVNOFBEc2hZdjEvYTcwdVAvKzNhbTlpUEVlTE9ycUJo?=
 =?utf-8?B?K2FIdEYreUFDVGtlWkRZdEo4aEJTcTEyN2FGS1JEdk5vZ3lpMUVaMlNxOXdQ?=
 =?utf-8?B?ZWd4WkVxcHk4ZWJsbGVDbDVRTkJhK0V6STd4MllUR0ZSckRKaVJEUFJZRGhE?=
 =?utf-8?B?MnlOdnBKR0pxVVlSYi8yOFNOYy81RFNoYm0zZmxydUE0L3l0NEJsWEc3OUh1?=
 =?utf-8?B?NXo5cStPL3VvNUFtQ0xkTXpFQ1hYVUJLK1A5WW8yS252NG1qRTBJSWhsZWc5?=
 =?utf-8?B?bVVaWk5RZFdnckRKUElLdHZndjMwandtNFlYbkMwZDZVMTJSaXRrVG13RGlk?=
 =?utf-8?B?TDdyNkpWMUlwdjRtMzdmUVE3WWZFUUM2YVBKMFhXdFJMeXByQ3J4eTh6Rkh1?=
 =?utf-8?B?NVJKdS9JUXBDYVVpY3R5amsrUGxmOHo4VzBLT3M3dUc3Qm5uMXBGdXhqMWdH?=
 =?utf-8?B?S3dFWDcybnFzNGU5Wm9KTDcyZmVuMjhnSThxbGdUaXFvRTJlMEM5TmVWV1ZP?=
 =?utf-8?B?V0pIWkpBZjZBOHg3dTZOMzd1T3FFNSs4RWpTNEc4dFV1VXdzcm0xSHB4NkxV?=
 =?utf-8?B?REF4Wi9taHFYQTk1b2hHK28rdXYyQ05ZczNkbXJFSERxdENzOEEzRWlFL2Ry?=
 =?utf-8?B?Z2lDMWN4MTdGYWlTOFVtY1dVQytOaVJWSlRqRWJ6VmVkM2dnU2pDU3Q3WHRh?=
 =?utf-8?B?Mnc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	ZLKh+oE6RXlarfcthJlcD+hcPTNKnn13zWbrZr9N1z6ZZcz9BerTVEkpyeYnwdjHVmDfvlbm378lh0Ff5uwvNfTFCT9SZgqkCa++pDekrYG1Q/ZlmWkZUpAgbNMy59/ficyzBbBzrtu5AtSbQiNnhQJXOLq0XL0JCvSVWz4YkHIzXHeofqFiV7o0j1QLrAZT/QKwu4woxzhb7pHntOonN86McUNuEcnL6UPNa4A+oEtthBWQDh1JPxlwVpJqEUUM9moQemqu5fKu6auPuxmGbAzwljJwcwQOcJGM1iKNTEMBcwuSszs9uoWl1N9NU5RPGejl7LAD9ldJudnhy7RYFZXSEVv9Iih7FoDEDb45zQeMnH3nCFXDXaZVuF56l85Z17NEDwABFTqPlaUnHSA8ppc9jOjnZwUjJEg/kNf7dO//5KdNqdRiYwfOhSWl7l5yIRejBf0u0269ocvLXQBpDrom58140lOeg6+h6WdOmD4kRZ+NL5tXkk5Ru1m8hvnL2XaukyNbHy9LUjWdYM/RF4gcNse/sODzAfCtQX0kiu25YDPyHpzMoFoZBRI1j2A7MfJaiREhmxjOJm10OEj12KO2S222Lva4EDW6gOcprfk=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 46c7630f-0083-4bb3-00da-08dc34e76aac
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2663.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2024 03:19:31.2465
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rWUd7bbou7pyJgbev6oj9ROSltBd/wiKuzQbJmuXA36d9L/VX/fXPzXuBYzcKtJ6XzrZEu1mKvRHpqz1/S3/Ig==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB6981
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-23_08,2024-02-23_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999
 suspectscore=0 bulkscore=0 phishscore=0 mlxscore=0 malwarescore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2402240025
X-Proofpoint-ORIG-GUID: FUdNe9SlT0P-ex4ZMGUnAD_4e7295zoF
X-Proofpoint-GUID: FUdNe9SlT0P-ex4ZMGUnAD_4e7295zoF

Hi Dave,

On 2/23/24 08:27, Dave Hansen wrote:
> On 2/23/24 01:47, Dongli Zhang wrote:
>> @@ -1194,11 +1195,11 @@ static void split_lock_warn(unsigned long ip)
>>  bool handle_guest_split_lock(unsigned long ip)
>>  {
>>  	if (sld_state == sld_warn) {
>> -		split_lock_warn(ip);
>> +		split_lock_warn(ip, true);
>>  		return true;
>>  	}
> 
> I really despise random true/falses getting passed to functions.
> 
> Wouldn't this be a lot easier to read if you just passed the string in:
> 
> 	split_lock_warn(ip, "guest");
> 
> rather than bools plus the ternary form dance?

Thank you very much!

I will send v2 after waiting if there is no further comment.

Dongli Zhang