Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp314517rbb; Sat, 24 Feb 2024 01:31:24 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWCVsGoLWDXo0smqa8OXlTr4Gwo4+JszciDnpJ8iXTN2qxCWFxP/yepdNOqDLhoYNKSBn63XJX7VfyjnLmsdVUJs1FzvYEkD6bap2TWsA== X-Google-Smtp-Source: AGHT+IHcXBlZ9lrf/xPSpxV1YgWyMuv/ieiDDBAZp17fgVcl4LhesCVe4BgNje8urO1xqsS5WrCm X-Received: by 2002:a05:6214:3f81:b0:68f:a864:4e44 with SMTP id ow1-20020a0562143f8100b0068fa8644e44mr3745448qvb.1.1708767084119; Sat, 24 Feb 2024 01:31:24 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708767084; cv=pass; d=google.com; s=arc-20160816; b=MlxuI0OkOjXwR1EE/fouMndbU0nokZA8U77gMKQfQd/VzLbiXOPlCr8uilU4xBEilA VgS5E8580IJbWZtmVb7tidQl2oHWA0DKG4QX+oUFXln/2xYU2f7L6LEdbBjHAa6VKCSB 6WD8kbF4ao2fw70Tylx/RrXzbHKVcGVVPH5U5wTS6FFPYs2+kssxIAk8QAsHA/pgf8zT grvgFORuYMD9Kw20kcfyFPQ47gnDN7U/VYWGSbXx3Nh4aKE/a0C05vsud7c2oV3Vz/9t IYkTT6yanuf8o8wi/S7ouWmIUc1akYoJGtpY5a8c3Kb4KEWgrP2ja3942i2E4+co9dqc Mk8Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=YmY5NkPyqyDzoEieFjYp7SW5hjVc2+Nb3/NQOzb8Ges=; fh=hK1JfphVmg6G/B+UAEEADPp+z/Pz2AR84iIO0p9jqvM=; b=RcYd8ACyp1vJlr34yQMFQlBOnDRqhYPHcnYnCkZs2D4t0aTeQ03Ga2ukTJaiw4wkrZ 2Lhz9IEvhKVJU0sP4Bz+dthtYcT+DfgUK1L1EupXG1lfp+HJ+xyYJfO2LXN6vi+2nbyG aK5gc/GeGzSEJ9Wz2orpjo6Gp8uUxBKnJ/owyRo0EjHGnNPVrKTedB5zGXvuNZRnsg7x XbsB3JhrJdPu6HW5LyNfbp2JVM4L2g0C4N68lnANOPeFWAwyOXtTfZoEo5F/AoVUkW/l PBa3L3OpMtUPd6QsGj9XCihuHP+SJUMyFAHDq/Rv6+nOs7CV6JQxTAHyPlG/B/IeF8mW dpWA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b="y/e4ofWD"; arc=pass (i=1 spf=pass spfdomain=google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-79544-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79544-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id gc13-20020a056214230d00b0068ccc63d00bsi698274qvb.410.2024.02.24.01.31.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Feb 2024 01:31:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-79544-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b="y/e4ofWD"; arc=pass (i=1 spf=pass spfdomain=google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-79544-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79544-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id DBD591C21E14 for ; Sat, 24 Feb 2024 09:31:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D30DF1B26E; Sat, 24 Feb 2024 09:31:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="y/e4ofWD" Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55C2B199C2 for ; Sat, 24 Feb 2024 09:31:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708767077; cv=none; b=FDII3vObp8mg2Cju3e32XOg+I/axdowdxnCYhikGZVUlgyMbR3i4lmoucUNB6fa/7qLWWJSxuEicjtxbvHgq4G9HMlsB/J4ja8JEm6O02SrhMSEal4NCoFbxiMV4dSzpRijbTWeGLtZiXnu1pwaXynGfYIvwLpadx/z2NGFezRQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708767077; c=relaxed/simple; bh=y2+xsbNA7nJA5AJAIiiYtBIFp5DHt0sr/WcAwRB23LY=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=oGTuyUboF26OXZgvmf/9REO5VOv5qKIFH4hlJDZ6G5GC06E2coA3q59ZHTQW8AFuTUCnY/03CaF8m7PKdZsK0m4jH5shvnp1fyD6UgyLin0OXjGGknbwGD0avywZoGJnJz/vv7qhzM9KhLkt04jTE6FzFh4J7zFHwT7GDiQ5KSs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=y/e4ofWD; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-5650c27e352so6312a12.0 for ; Sat, 24 Feb 2024 01:31:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708767073; x=1709371873; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YmY5NkPyqyDzoEieFjYp7SW5hjVc2+Nb3/NQOzb8Ges=; b=y/e4ofWD20vd3a1URnY4gVNi+xSV3qazdgGof9LdTOzGjqTop0P6aPamki0ZqSqYfB 8jzkcCaMNaIpmJ0G14woHpNmbJvu/21hSAOyxvWzlfcTyg1WSUuQxHDXvDvmN3lpxB02 ej0DLMEvAf8S1YVFIb61w0mDWMR793YdZ3YIHn9a7t7ZxU/4A0DVieYSU4KYgccZtO8C W0d5MnLT7+WrmnZ9cJ135R76IUHgL2rqZSQ/h4LASdB8h2e0+uax9yjGIw31p4tuTRf1 OxfMDNLFpY3POZ0yl9X2ouDzGJLcC0KIZ1CnYoVGT2/hTwVoeF9ZgNt8JRMldLkqinZc LK5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708767073; x=1709371873; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YmY5NkPyqyDzoEieFjYp7SW5hjVc2+Nb3/NQOzb8Ges=; b=lrmBvkzzJxqXKgMA0hud8nEjPUQuUM4NroxRwhwC8G8pNGNiB2lyRcScZkPmFzTF+d y3kTPBqkTZiaJoikUrkvL1eUoVkh6GZdvrtAv3Mjt90fjZFS02ZcmD/Nkc3+/Vij02L9 1b07JZuarKv58e3e04evlQ6MctV752H6ZYJPXcy+zTiXag/lzpEHIMUOS7fpWEt9ltyK R+mPzKQK8lATkTyxcGxi9/j80Z7nx4clAO3era0FipYZptLtti8UtCjSufHPtu8EsIhs Gv6EB5jdR1VlEjTcw2iD/Wyfu1hNnBLu7E+Kk/q/cMsodsJceCZ7081EzV+stcSJTuvt T+Rg== X-Forwarded-Encrypted: i=1; AJvYcCUAHMyfsVtot4lIaF3t0qn300kssdNsQic+/ttWw58DGPoaFrelv2frUlPhivIu1wlemwv1q/D2NXEOXZGCQITVTCmv45FPhIKDiAEa X-Gm-Message-State: AOJu0YwyAYYeNwk+NiJcL8ebz8PN5A1h88eKCcqeiBklJEt9ebhdRi4G Y7rZJM8nK89mftpFO2tyWWQofcq0IUTYGhwS3PWjXNXLaCHfy54iwRcSDyR8GN/pyoGn/VRHN77 oxWYw9+CfWtYg/nfexwqSlhn6l8wtSkFreAqS X-Received: by 2002:a50:a6d7:0:b0:565:733d:2b30 with SMTP id f23-20020a50a6d7000000b00565733d2b30mr114515edc.4.1708767073364; Sat, 24 Feb 2024 01:31:13 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240224-tcp-ao-tracepoints-v1-0-15f31b7f30a7@arista.com> <20240224-tcp-ao-tracepoints-v1-3-15f31b7f30a7@arista.com> In-Reply-To: <20240224-tcp-ao-tracepoints-v1-3-15f31b7f30a7@arista.com> From: Eric Dumazet Date: Sat, 24 Feb 2024 10:30:59 +0100 Message-ID: Subject: Re: [PATCH net-next 03/10] net/tcp: Move tcp_inbound_hash() from headers To: Dmitry Safonov Cc: "David S. Miller" , Jakub Kicinski , Paolo Abeni , David Ahern , Shuah Khan , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Dmitry Safonov <0x7f454c46@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Feb 24, 2024 at 10:04=E2=80=AFAM Dmitry Safonov w= rote: > > Two reasons: > 1. It's grown up enough > 2. In order to not do header spaghetti by including > , which is necessary for TCP tracepoints. > > Signed-off-by: Dmitry Safonov Okay, but what about CONFIG_IPV6=3Dm ? I do not see any EXPORT_SYMBOL() in this patch.