Received-SPF: pass (google.com: domain of linux-kernel+bounces-79582-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Sat, 24 Feb 2024 11:16:33 +0000
From: Jonathan Cameron <jic23@kernel.org>
To: =?UTF-8?B?T25kxZllag==?= Jirman <megi@xff.cz>
Cc: Lars-Peter Clausen <lars@metafoo.de>, Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley
 <conor+dt@kernel.org>, Andrey Skvortsov <andrej.skvortzov@gmail.com>,
 Icenowy Zheng <icenowy@aosc.io>, Dalton Durst <dalton@ubports.com>, Shoji
 Keita <awaittrot@shjk.jp>, linux-iio@vger.kernel.org,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/4] iio: magnetometer: add a driver for Voltafield
 AF8133J magnetometer
Message-ID: <20240224111633.1485c165@jic23-huawei>
In-Reply-To: <bul6syabdw353oqomcbdz75b56q5yjgslczbw7d6yxfkxvy3hn@3yz3yusfzrlo>
References: <20240216185008.1370618-1-megi@xff.cz>
	<20240216185008.1370618-4-megi@xff.cz>
	<bul6syabdw353oqomcbdz75b56q5yjgslczbw7d6yxfkxvy3hn@3yz3yusfzrlo>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Ond=C5=99ej,

Quick process comment.=20

Please crop replies to avoid never ending scrolling and more importantly
a high chance of what you actually want to say being missed!


> > +static int af8133j_probe(struct i2c_client *client)
> > +{

..

> > +	ret =3D devm_iio_triggered_buffer_setup(dev, indio_dev, NULL,
> > +					      &af8133j_trigger_handler, NULL);
> > +	if (ret)
> > +		return dev_err_probe(&client->dev, ret,
> > +				     "Failed to setup iio triggered buffer\n");
> > +
> > +	ret =3D devm_iio_device_register(dev, indio_dev);
> > +	if (ret)
> > +		return dev_err_probe(dev, ret, "Failed to register iio device");
> > +
> > +	pm_runtime_get_noresume(dev);
> > +	pm_runtime_use_autosuspend(dev);
> > +	pm_runtime_set_autosuspend_delay(dev, 500);
> > +	ret =3D devm_pm_runtime_enable(dev);
> > +	if (ret)
> > +		return ret; =20
>=20
> Ah, forgot to move this up. Oh, well. I'll send v4.
>=20
> kind regards,
> 	o.
>=20
> > +	pm_runtime_put_autosuspend(dev);
> > +
> > +	return 0;
> > +}
> > +