Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp395786rbb; Sat, 24 Feb 2024 05:23:48 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXO7a0ajCPbaQRt5fTpVTq8G4b2nrVw8b/tP9G+iYt1cEJI+mo7dvbBlgLEjG/KS6N5B9xqaltbvPBCyLPsgNyszVuzZN2ddM6I6deqEQ== X-Google-Smtp-Source: AGHT+IHoAMP+OnhCcvBU865UmkblppbHxjJBIfkKjdklUQpAc2O/Jv5C1wsxqosHeSVDN5WLMrGe X-Received: by 2002:a05:6e02:b4c:b0:365:2390:9313 with SMTP id f12-20020a056e020b4c00b0036523909313mr3577951ilu.12.1708781027821; Sat, 24 Feb 2024 05:23:47 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708781027; cv=pass; d=google.com; s=arc-20160816; b=tBfO2ObhZSovAStHxB9xMcOW1TomXEjmeuA/HFDUvkoOYFLBI29w5ZF8xcpki/7aqt 2r+DIKOqsL4wlxxHOBnaIix/yIShuAQ00CB7ihwyfnq5WHeI2JwPeQsyG9SczYY5wvNx 7Rd4H6COIXeYKXjWpxb47vkqKZXZUVp7Z46zbBrSSr3TriK/t6rEzimey2OeDaXODJ0R zsNZ7XM1Cji3XbL2v609aynUy/VWIUQ6cwKgbibA+icsCutvunVLy7rXf7bQhkSBZUgo p3TL1JR/iKNvzQSuJAXBgChcrDLKVmvK7vc+GWld6nOltiGKy0yOMck736yGDQVJSRo9 TTrA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date; bh=YCkMdQzvQl2TciPI87yz9CZeJYHpdufl1x97rdqe7ko=; fh=oWWoYijzsF087U9LTL1moCwb887YNwolLIe4uYYwfQg=; b=EQ59mpKSdfL1oEhcs7etZvoUeCHsjDM04YAfo1wmwrgN37uTRfOUPBfhyEaSBUJek5 Db0hWBoYf4Z+1HRb+6ZqQR6dIpnswPiVflAiV+OFjv89AKi6/j+1x+uTg/Kr6+5ef+Vs StVUa3xESQDuWgr2bSzpVGi5pMVztpHKvMHA+RSOwAENJRJkRTY5ENcFiPWnJoWGY6AL NFRlhLeAejeLM4af4Lpdp54qf8PKNx5XPMM+p2EOCURczkWLT5ZKcsVU4EwdmnbuFJP9 SD49hEHU2ecvGBgBS9cHH+jH30/IgE3fg/InFtGdDKm9tEoRtnIGir8mIiOTijuiKWmH 4ezw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=strlen.de); spf=pass (google.com: domain of linux-kernel+bounces-79641-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79641-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id c2-20020a633502000000b005dc7e96d5e7si892059pga.532.2024.02.24.05.23.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Feb 2024 05:23:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-79641-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=strlen.de); spf=pass (google.com: domain of linux-kernel+bounces-79641-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79641-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 54610B2186F for ; Sat, 24 Feb 2024 13:23:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 278F03FB06; Sat, 24 Feb 2024 13:23:31 +0000 (UTC) Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [91.216.245.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2FD8125C3; Sat, 24 Feb 2024 13:23:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.216.245.30 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708781010; cv=none; b=ttqWrZ6fFE8seEUh3Apc3DgG5HKSG7K7nEbypxmiTLUfWVylxvrzpxgaZqUjvSuxYontaT12xK4t1QDX9Y1Yhx5KhKt5nozJ9/UEdmqBT66iirpRGfI+LBLfJCOmaid1HBXKpkCaOUSXIy2rioBLDUXoFThxUMG/MXuwGhLyj80= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708781010; c=relaxed/simple; bh=sOeZ7VjdJLtUTLoc52UIxXOs60Oaaq74itnIyOLQ3xs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=M9akinK1YbolN0tLgyZ5iGYP2JP32x9YOkMhe/hWPO0AtTiUhO/mV4fAbLNVkKWNeYjZn7WtOEo0SYlX6Fi3BYumWLZ6wUZcJsxRFpzw+Jq+XVpP2AmeHaZjuzrq7wsmbVYU8/YdBgRyUUCbsf/RScG9PBUWFUHQiwY1IMPXgHY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=strlen.de; spf=pass smtp.mailfrom=strlen.de; arc=none smtp.client-ip=91.216.245.30 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=strlen.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=strlen.de Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1rdrzh-0004nb-7z; Sat, 24 Feb 2024 14:23:09 +0100 Date: Sat, 24 Feb 2024 14:23:09 +0100 From: Florian Westphal To: Arnd Bergmann Cc: Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , Arnd Bergmann , "David S. Miller" , David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter: xtables: fix IP6_NF_IPTABLES_LEGACY typo Message-ID: <20240224132309.GA27709@breakpoint.cc> References: <20240224121330.1924338-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240224121330.1924338-1-arnd@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Arnd Bergmann wrote: > From: Arnd Bergmann > > CONFIG_IP_NF_NAT accidentally selects the wrong NF_IPTABLES_LEGACY > symbol, which ends up causing a link failure in some configurations: > > WARNING: unmet direct dependencies detected for IP6_NF_IPTABLES_LEGACY > Depends on [n]: NET [=y] && INET [=y] && IPV6 [=n] && NETFILTER [=y] > Selected by [m]: > > Select IP_NF_IPTABLES_LEGACY instead of IP6_NF_IPTABLES_LEGACY. Patch is correct but this is already fixed via 749d4ef0868c ("netfilter: xtables: fix up kconfig dependencies")