Received-SPF: pass (google.com: domain of linux-kernel+bounces-79642-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <1bb797ef-573b-4bda-98bf-1eb63f6f4ffe@linux.ibm.com>
Date: Sat, 24 Feb 2024 19:13:24 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 0/2] sched: blk: Handle HMP systems when completing IO
Content-Language: en-US
To: Qais Yousef <qyousef@layalina.io>
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
        Sudeep Holla <sudeep.holla@arm.com>, Wei Wang <wvw@google.com>,
        Jaegeuk Kim <jaegeuk@kernel.org>, Bart Van Assche <bvanassche@acm.org>,
        Christoph Hellwig <hch@infradead.org>, Jens Axboe <axboe@kernel.dk>,
        Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>
References: <20240223155749.2958009-1-qyousef@layalina.io>
From: Shrikanth Hegde <sshegde@linux.ibm.com>
In-Reply-To: <20240223155749.2958009-1-qyousef@layalina.io>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 2/23/24 9:27 PM, Qais Yousef wrote:
> Due to recent changes in how topology is represented on asymmetric multi
> processing systems like big.LITTLE where all cpus share the last LLC, there is
> a performance regression as cpus with different compute capacities appear under
> the same LLC and we no longer send an IPI when the requester is running on
> a different cluster with different compute capacity.
> 
> Restore the old behavior by adding a new cpus_equal_capacity() function to help
> check for the new condition for these systems.
> 
> Changes since v1:
> 
> 	* Split the patch per subsystem.
> 	* Convert cpus_gte_capacity() to cpus_equal_capacity()
> 	* Make cpus_equal_capacity() return immediately for SMP systems.
> 

nit: Did you mean !SMP systems here? 
Because in changes i see its returning true directly if its in !CONFIG_SMP path. 

> Qais Yousef (2):
>   sched: Add a new function to compare if two cpus have the same
>     capacity
>   block/blk-mq: Don't complete locally if capacities are different
> 
>  block/blk-mq.c                 |  5 +++--
>  include/linux/sched/topology.h |  6 ++++++
>  kernel/sched/core.c            | 11 +++++++++++
>  3 files changed, 20 insertions(+), 2 deletions(-)
>