Received-SPF: pass (google.com: domain of linux-kernel+bounces-79752-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Sat, 24 Feb 2024 09:03:06 -0800
From: "Darrick J. Wong" <djwong@kernel.org>
To: chengming.zhou@linux.dev
Cc: chandan.babu@oracle.com, linux-xfs@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org, vbabka@suse.cz,
	roman.gushchin@linux.dev, Xiongwei.Song@windriver.com,
	Chengming Zhou <zhouchengming@bytedance.com>
Subject: Re: [PATCH] xfs: remove SLAB_MEM_SPREAD flag usage
Message-ID: <20240224170306.GI616564@frogsfrogsfrogs>
References: <20240224135323.830509-1-chengming.zhou@linux.dev>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240224135323.830509-1-chengming.zhou@linux.dev>

On Sat, Feb 24, 2024 at 01:53:23PM +0000, chengming.zhou@linux.dev wrote:
> From: Chengming Zhou <zhouchengming@bytedance.com>
> 
> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> its usage so we can delete it from slab. No functional change.
> 
> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>

Acked-by: Darrick J. Wong <djwong@kernel.org>

(acked, as in "this looks right, i don't know why it wasn't removed when
slab went away, and from the -mm list traffic this seems to be in line
with [1] but i still had to dig for details)

[1] https://lore.kernel.org/linux-mm/20240131172027.10f64405@gandalf.local.home/T/#u

--D

> ---
>  fs/xfs/xfs_super.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index 56006b877a5d..171a1287b296 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -2042,8 +2042,7 @@ xfs_init_caches(void)
>  
>  	xfs_buf_cache = kmem_cache_create("xfs_buf", sizeof(struct xfs_buf), 0,
>  					 SLAB_HWCACHE_ALIGN |
> -					 SLAB_RECLAIM_ACCOUNT |
> -					 SLAB_MEM_SPREAD,
> +					 SLAB_RECLAIM_ACCOUNT,
>  					 NULL);
>  	if (!xfs_buf_cache)
>  		goto out;
> @@ -2108,14 +2107,14 @@ xfs_init_caches(void)
>  					   sizeof(struct xfs_inode), 0,
>  					   (SLAB_HWCACHE_ALIGN |
>  					    SLAB_RECLAIM_ACCOUNT |
> -					    SLAB_MEM_SPREAD | SLAB_ACCOUNT),
> +					    SLAB_ACCOUNT),
>  					   xfs_fs_inode_init_once);
>  	if (!xfs_inode_cache)
>  		goto out_destroy_efi_cache;
>  
>  	xfs_ili_cache = kmem_cache_create("xfs_ili",
>  					 sizeof(struct xfs_inode_log_item), 0,
> -					 SLAB_RECLAIM_ACCOUNT | SLAB_MEM_SPREAD,
> +					 SLAB_RECLAIM_ACCOUNT,
>  					 NULL);
>  	if (!xfs_ili_cache)
>  		goto out_destroy_inode_cache;
> -- 
> 2.40.1
> 
>