Received-SPF: pass (google.com: domain of linux-kernel+bounces-79753-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Sat, 24 Feb 2024 17:07:07 +0000
From: Jonathan Cameron <jic23@kernel.org>
To: Ceclan Dumitru <mitrutzceclan@gmail.com>
Cc: David Lechner <dlechner@baylibre.com>, linus.walleij@linaro.org,
 brgl@bgdev.pl, andy@kernel.org, linux-gpio@vger.kernel.org, Lars-Peter
 Clausen <lars@metafoo.de>, Rob Herring <robh+dt@kernel.org>, Krzysztof
 Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley
 <conor+dt@kernel.org>, Michael Walle <michael@walle.cc>, Andy Shevchenko
 <andy.shevchenko@gmail.com>, Arnd Bergmann <arnd@arndb.de>, ChiaEn Wu
 <chiaen_wu@richtek.com>, Niklas Schnelle <schnelle@linux.ibm.com>, Leonard
 =?UTF-8?B?R8O2aHJz?= <l.goehrs@pengutronix.de>, Mike Looijmans
 <mike.looijmans@topic.nl>, Haibo Chen <haibo.chen@nxp.com>, Hugo Villeneuve
 <hvilleneuve@dimonoff.com>, Ceclan Dumitru <dumitru.ceclan@analog.com>,
 linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH v13 1/3] dt-bindings: adc: add AD7173
Message-ID: <20240224170707.4ffcec19@jic23-huawei>
In-Reply-To: <0fa819d1-2a0f-4243-8e5f-a098528278c3@gmail.com>
References: <20240220094344.17556-1-mitrutzceclan@gmail.com>
	<CAMknhBEZ7Y1Yx=wJGnfvYWGKPLas3pbCyY+sN8vrBzdkYO-A4w@mail.gmail.com>
	<0fa819d1-2a0f-4243-8e5f-a098528278c3@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Wed, 21 Feb 2024 10:29:30 +0200
Ceclan Dumitru <mitrutzceclan@gmail.com> wrote:

> On 2/20/24 22:54, David Lechner wrote:
> > On Tue, Feb 20, 2024 at 3:43=E2=80=AFAM Dumitru Ceclan <mitrutzceclan@g=
mail.com> wrote: =20
>=20
> ...
>=20
> >> +  clocks:
> >> +    maxItems: 1
> >> +    description: | =20
> >=20
> > Don't need `|` here.
> >  =20
> The description contains ": ". Without '|' yaml syntax considers the
> whole string before ':' as another attribute
>=20
> >> +      Optional external clock source. Can include one clock source: e=
xternal
> >> +      clock or external crystal.
> >> + =20
>=20
> ...
>=20
> >> +
> >> +      diff-channels:
> >> +        items:
> >> +          minimum: 0
> >> +          maximum: 31
> >> + =20
> >=20
> > Are we missing `bipolar: true` here? (since we have
> > unevaluatedProperties: false)
> >  =20
>=20
> No, since we are referencing the adc schema "$ref: adc.yaml"
> Which contains:
> """
>   bipolar:
>=20
>     $ref: /schemas/types.yaml#/definitions/flag
>=20
>     description: If provided, the channel is to be used in bipolar mode.
> """
>=20
>=20
> ...
>=20
> >> +
> >> +required:
> >> +  - compatible
> >> +  - reg =20
> >=20
> > Aren't the various power supplies supposed to be required?
> >=20
> > - avdd-supply
> > - avdd2-supply
> > - iovdd-supply =20
>=20
> From my point of view, if someone uses a single supply (avdd =3D=3D avdd2=
 =3D=3D
> iovdd), and uses only the internal reference then the supplies should
> not necessarily be required.

Convention is that anything that represent a voltage on a pin that
is needed for operation should be required.  Key here is the difference
from optional supplies where the driver does something different.
vref is a good example of this. The ones above are always needed I
think.

Obviously they may all say the same thing if they are connected
externally.