Received-SPF: pass (google.com: domain of linux-kernel+bounces-79758-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Sender: Guenter Roeck <groeck7@gmail.com>
Date: Sat, 24 Feb 2024 09:25:54 -0800
From: Guenter Roeck <linux@roeck-us.net>
To: David Ober <dober@lenovo.com>
Cc: Mark Pearson <mpearson-lenovo@squebb.ca>,
	David Ober <dober6023@gmail.com>,
	"wim@linux-watchdog.org" <wim@linux-watchdog.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>
Subject: Re: [External] Re: [PATCH v2] watchdog: add in watchdog for nct6686
Message-ID: <9d670c24-4897-4a02-87c1-98e366075e83@roeck-us.net>
References: <20230912112747.285393-1-dober6023@gmail.com>
 <78da7ad0-cc11-4e6f-bf25-12bd5ec247a0@app.fastmail.com>
 <8458d626-8862-44ed-8966-2f60852c92bb@app.fastmail.com>
 <e6d0fda7-09db-4955-92dd-def2df768da6@roeck-us.net>
 <SEYPR03MB7192ED993D9A15244EF22D9FDA542@SEYPR03MB7192.apcprd03.prod.outlook.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <SEYPR03MB7192ED993D9A15244EF22D9FDA542@SEYPR03MB7192.apcprd03.prod.outlook.com>

On Sat, Feb 24, 2024 at 05:00:04PM +0000, David Ober wrote:
> Hi
> 
>    I understand the issue of the first come first grab but when I attempted to add this to the hwmon you insisted that that was not the correct place and to create a watchdog module so if both can not be loaded then would it have not been better to add it to the hwmon like some of the other chips.
> 

Two options:

- Add it to the hwmon driver. Not a preferred solution.
- Implement a mfd driver which controls access to the chip
  (preferrably through regmap) and instantiates both the hwmon
  driver and the watchdog driver.

Guenter