Received-SPF: pass (google.com: domain of linux-kernel+bounces-79772-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Sat, 24 Feb 2024 17:44:46 +0000
From: Jonathan Cameron <jic23@kernel.org>
To: Nuno =?UTF-8?B?U8Oh?= <noname.nuno@gmail.com>
Cc: Dumitru Ceclan <mitrutzceclan@gmail.com>, Lars-Peter Clausen
 <lars@metafoo.de>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>,
 linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, Ceclan Dumitru <dumitru.ceclan@analog.com>
Subject: Re: [PATCH v5 4/5] iio: amplifiers: hmc425a: use pointers in match
 table
Message-ID: <20240224174446.1565bfb9@jic23-huawei>
In-Reply-To: <94f7e7f2568d0d70055954f628b2bd56cbe78d9b.camel@gmail.com>
References: <20240220153553.2432-1-mitrutzceclan@gmail.com>
	<20240220153553.2432-4-mitrutzceclan@gmail.com>
	<94f7e7f2568d0d70055954f628b2bd56cbe78d9b.camel@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Wed, 21 Feb 2024 14:17:22 +0100
Nuno S=C3=A1 <noname.nuno@gmail.com> wrote:

> On Tue, 2024-02-20 at 17:34 +0200, Dumitru Ceclan wrote:
> > Change the match table to use pointers instead of device ids.
> > Remove type from state as it is not used anymore.
> >=20
> > Signed-off-by: Dumitru Ceclan <mitrutzceclan@gmail.com>
> > --- =20
>=20
> One comment (Jonathan might be able to address that while applying)... Wi=
th that:
>=20
> Reviewed-by: Nuno Sa <nuno.sa@analog.com>
>=20
> > =C2=A0drivers/iio/amplifiers/hmc425a.c | 29 +++++++++++++++------------=
--
> > =C2=A01 file changed, 15 insertions(+), 14 deletions(-)
> >=20
> > diff --git a/drivers/iio/amplifiers/hmc425a.c b/drivers/iio/amplifiers/=
hmc425a.c
> > index 13e018a59637..77872e2dfdfe 100644
> > --- a/drivers/iio/amplifiers/hmc425a.c
> > +++ b/drivers/iio/amplifiers/hmc425a.c
> > @@ -41,15 +41,14 @@ struct hmc425a_chip_info {
> > =C2=A0
> > =C2=A0struct hmc425a_state {
> > =C2=A0	struct	mutex lock; /* protect sensor state */
> > -	struct	hmc425a_chip_info *chip_info;
> > +	const struct	hmc425a_chip_info *chip_info; =20
>=20
> Since you're doing this, I believe you should also constify hmc425a_chip_=
info_tbl[]
> and mention it in the commit message.
>=20
Absolutely.  I've made that change and added a note on it to commit message.

> - Nuno S=C3=A1
>=20