Received-SPF: pass (google.com: domain of linux-kernel+bounces-79792-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: chengming.zhou@linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        vbabka@suse.cz, roman.gushchin@linux.dev, Xiongwei.Song@windriver.com,
        Chengming Zhou
 <zhouchengming@bytedance.com>
Subject: Re: [PATCH] fat: remove SLAB_MEM_SPREAD flag usage
In-Reply-To: <20240224134828.829481-1-chengming.zhou@linux.dev> (chengming
	zhou's message of "Sat, 24 Feb 2024 13:48:28 +0000")
References: <20240224134828.829481-1-chengming.zhou@linux.dev>
Date: Sun, 25 Feb 2024 03:27:54 +0900
Message-ID: <87msrpaf9x.fsf@mail.parknet.co.jp>
User-Agent: Gnus/5.13 (Gnus v5.13)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

chengming.zhou@linux.dev writes:

> From: Chengming Zhou <zhouchengming@bytedance.com>
>
> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> its usage so we can delete it from slab. No functional change.
>
> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>

Looks good.

Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

Thanks.

> ---
>  fs/fat/cache.c | 2 +-
>  fs/fat/inode.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/fat/cache.c b/fs/fat/cache.c
> index 738e427e2d21..2af424e200b3 100644
> --- a/fs/fat/cache.c
> +++ b/fs/fat/cache.c
> @@ -47,7 +47,7 @@ int __init fat_cache_init(void)
>  {
>  	fat_cache_cachep = kmem_cache_create("fat_cache",
>  				sizeof(struct fat_cache),
> -				0, SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD,
> +				0, SLAB_RECLAIM_ACCOUNT,
>  				init_once);
>  	if (fat_cache_cachep == NULL)
>  		return -ENOMEM;
> diff --git a/fs/fat/inode.c b/fs/fat/inode.c
> index 5c813696d1ff..d9e6fbb6f246 100644
> --- a/fs/fat/inode.c
> +++ b/fs/fat/inode.c
> @@ -787,7 +787,7 @@ static int __init fat_init_inodecache(void)
>  	fat_inode_cachep = kmem_cache_create("fat_inode_cache",
>  					     sizeof(struct msdos_inode_info),
>  					     0, (SLAB_RECLAIM_ACCOUNT|
> -						SLAB_MEM_SPREAD|SLAB_ACCOUNT),
> +						SLAB_ACCOUNT),
>  					     init_once);
>  	if (fat_inode_cachep == NULL)
>  		return -ENOMEM;

-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>