Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp521439rbb; Sat, 24 Feb 2024 10:30:26 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVoB2u0UvE6wQFLXlB4oLeSrJ8TfxYA9YHoGY4XjocM/QKcBoNKNaBVcTvqqJDHY7k5SCx2GHgCVpM+MGbDX+cdi45AKzyFdPqLumfv/A== X-Google-Smtp-Source: AGHT+IGMSROfv0bY55mYtnXFyBMrHyjEXceHFlL7pGt0rniWnl/MYJ2BWItysGhImf9x2jj66vk5 X-Received: by 2002:a05:620a:89a:b0:787:9863:eb7b with SMTP id b26-20020a05620a089a00b007879863eb7bmr3270463qka.74.1708799425867; Sat, 24 Feb 2024 10:30:25 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708799425; cv=pass; d=google.com; s=arc-20160816; b=QPsaAjK/h9cLwegNEZbXjs1naOlCOJZFpvjOkqwzqeFpgP0FVWQI+QAfcxxg1wKcX3 AJCyl80Up4gZSeKLIi+6fIGHeESU98ATJPzr4cd6vcfi9gken43JQrvi1GshFhGBCwaO cIDkBGLVKofC9dLm9vqIVxe5Zw6TKt6I6dHrJjfai4vwMuLpqNLM3t65RWqXHv/JZcny tpVO1Hqz+JEhIRu/8Dpxn2Fq1dewbWoyENsjSispcwtXJS6tjm/wIuZG7S7Xev5Km7n3 0Oyf8FxQD1VXExPPJkoyUFh00UFk3v2cxKX6BCYKUtQMF0AKL1ubl2GQamx83EGpOZZW AhgQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=uBiUbIB2fZdCrY+qe73GiT1rJ6KQ3ECGY3DHydZFi3A=; fh=FqPCnKPxu0mS1oN049kUpV1FExHMV83t4vMdfSfXxAg=; b=QSccl+EynSrd2VT8aeR6IWmxveEE/1iPYRd2sD7StA/dCMEsrwMJSKh0KRgg3PGK+g OO32xcg5gk6J8cepPD7jdn7T/B2CL0pU1MgiHS0+CkTqGSNKks/4nu4qFW/chNRV4LSu emF0tpMVy6uW9znvoHwxymcNUhJW3T94sdRnl+ENdOwmZA456W6Hvzb5XLX2xdBfF2Eo VG3kCskuDo+OO5Zcq9sTT2FZhIpTtRZ/1c4MdIJIBP5lgvL5Ue2S21/Oj+5Z/fV4MhaQ MA45IlU0GJIWiHsNqQ3F3lPOZHBc9yUlgV8esQVesLaeqq5DwC/Ih8rT5rIP1R8m5/EH VmSQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jLdR1wZ2; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-79793-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79793-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id bj25-20020a05620a191900b00787c17ee7c4si1699233qkb.271.2024.02.24.10.30.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Feb 2024 10:30:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-79793-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jLdR1wZ2; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-79793-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79793-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id DF2C11C2125B for ; Sat, 24 Feb 2024 18:30:18 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2BA1C47F6C; Sat, 24 Feb 2024 18:30:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jLdR1wZ2" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28CEE11184; Sat, 24 Feb 2024 18:30:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708799410; cv=none; b=YxLamSwr5p3DFydJkLgnxNRGZtkjmsF+F+gt+76IsFsrV5WmbP0YDTeOZHwuS5/mbb6u6JoumJIklgQmPkFJ2I7dup0vPqjUqGjFiL3XRgjoAVEZksXymjMXfgViQY8grGd4WnxwLmA4SCjB0jF7tSLHre02VxDuKH3Bs+i672Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708799410; c=relaxed/simple; bh=seEQb8OOmd5tvbOXouHrGJxGXsGVZAJiN369Eyry94k=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=k4OjHcOTPVRTYGM/MFcECx15g/0RXIdHXBnReqf0wTpsPWMMG7uhANA1vXgX5vk+usO7asbnyhIILQYpDC1vPFIUdd/UKzpoM1rc4hGNQazauQl+vgUdiYPMRD+QHaX8vmkhiXRHqWSSPJqdwvKbVT8rUHHo6+4+r3x293iGicY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jLdR1wZ2; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3655C433C7; Sat, 24 Feb 2024 18:30:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708799409; bh=seEQb8OOmd5tvbOXouHrGJxGXsGVZAJiN369Eyry94k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jLdR1wZ2bZgadL0a9YDlZDmw7YoKy39uS2gYESYkwxWdeqcqdgYSvBHt0CxVk6HCD WYu6xiiUp4+zLZHC2xjemHrveQu3tiBMnLgDnoXNNc6I4ZJFIC8D3hFtaGKGhiyzSm vTQAlFe6p6TrfxgOrRonb8RUzXPfQObyiP+xriOEiyOoAKV7cG9kXh2e0B4JWmJKIo c20zWWVSd2FMlRWyQeNjq/G1WP1Wu7TXdWU98yKsPkZAy1X4lcF6MOKDv5LCa7E+hm AzindeDKu3Mi4PXidtNWZQJ1w2NaDSb7BP0Vp46S1FYWK4vCjqgiDdSoO54Jn/gUpu Ad2erpMPCOcHw== Date: Sat, 24 Feb 2024 18:29:50 +0000 From: Jonathan Cameron To: Conor Dooley Cc: Dumitru Ceclan , linus.walleij@linaro.org, brgl@bgdev.pl, andy@kernel.org, linux-gpio@vger.kernel.org, Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Walle , Andy Shevchenko , Arnd Bergmann , ChiaEn Wu , Niklas Schnelle , Leonard =?UTF-8?B?R8O2aHJz?= , Mike Looijmans , Haibo Chen , Hugo Villeneuve , David Lechner , Ceclan Dumitru , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v13 1/3] dt-bindings: adc: add AD7173 Message-ID: <20240224182950.1d00dab7@jic23-huawei> In-Reply-To: <20240220-outmost-flavoring-b2593160de91@spud> References: <20240220094344.17556-1-mitrutzceclan@gmail.com> <20240220-outmost-flavoring-b2593160de91@spud> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 20 Feb 2024 18:52:37 +0000 Conor Dooley wrote: > On Tue, Feb 20, 2024 at 11:43:38AM +0200, Dumitru Ceclan wrote: > > > + interrupts: > > + minItems: 1 > > + description: | > > > + > > + interrupt-names: > > + minItems: 1 > > + items: > > + - const: rdy > > + - const: err > > I noticed that for minItems == 1, the rdy interrupt is required and err > is the optional one. > > With that in mind, you can simplify the interrupts description so that > it describes the interrupts separately: > > interrupts: > minItems: > items: > - description: > Ready: multiplexed with SPI data out. While SPI CS is low, > can be used to indicate the completion of a conversion. > > - description: > Error: The three error bits in the status register (ADC_ERROR, CRC_ERROR, > and REG_ERROR) are OR'ed, inverted, and mapped to the ERROR pin. Therefore, > the ERROR pin indicates that an error has occurred. > > Otherwise, I think everything has been sorted out? > > Reviewed-by: Conor Dooley This ordering may bite us in the future. Someone will build a board with err as only one wired. But meh, it will be a binding relaxation needed so I'm not that bothered by that. > > Cheers, > Conor.