Received-SPF: pass (google.com: domain of linux-kernel+bounces-79889-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <2cf0b77f51b907969ae83993854773961b4e159c.camel@perches.com>
Subject: sibyte: pointless if tests
From: Joe Perches <joe@perches.com>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-mips@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Date: Sat, 24 Feb 2024 14:28:32 -0800
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
Precedence: bulk
MIME-Version: 1.0

A checkpatch modification was suggested privately about
braces around an if test like

	if (foo)
		;

so I thought I'd see how many of these possibly pointless
if tests exist.  There aren't many.

Here are a couple in sibyte:

Maybe this should be documented as:

	"well, don't know what to do here"

$ cat if_semi.cocci
@@
expression e;
@@

*	if (e) ;

$ spatch --very-quiet -sp-file if_semi.cocci .
diff -u -p ./arch/mips/sibyte/common/cfe_console.c /tmp/nothing/arch/mips/s=
ibyte/common/cfe_console.c
--- ./arch/mips/sibyte/common/cfe_console.c
+++ /tmp/nothing/arch/mips/sibyte/common/cfe_console.c
@@ -22,8 +22,6 @@ static void cfe_console_write(struct con
 		if (str[i] =3D=3D '\n') {
 			do {
 				written =3D cfe_write(cfe_cons_handle, &str[last], i-last);
-				if (written < 0)
-					;
 				last +=3D written;
 			} while (last < i);
 			while (cfe_write(cfe_cons_handle, "\r", 1) <=3D 0)
@@ -33,8 +31,6 @@ static void cfe_console_write(struct con
 	if (last !=3D count) {
 		do {
 			written =3D cfe_write(cfe_cons_handle, &str[last], count-last);
-			if (written < 0)
-				;
 			last +=3D written;
 		} while (last < count);
 	}