Received-SPF: pass (google.com: domain of linux-kernel+bounces-79918-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240224213240.1854709-1-sre@kernel.org> <20240224213240.1854709-17-sre@kernel.org>
In-Reply-To: <20240224213240.1854709-17-sre@kernel.org>
From: Fabio Estevam <festevam@gmail.com>
Date: Sat, 24 Feb 2024 22:11:03 -0300
Message-ID: <CAOMZO5CWQk8__qwHF8ysXnY4zAfd_FvW+Znd1sdoPc_uPJJE4A@mail.gmail.com>
Subject: Re: [PATCH v4 16/16] ARM: dts: imx6ull-uti260b: Add board
To: Sebastian Reichel <sre@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, 
	Pengutronix Kernel Team <kernel@pengutronix.de>, NXP Linux Team <linux-imx@nxp.com>, 
	Dong Aisheng <aisheng.dong@nxp.com>, Linus Walleij <linus.walleij@linaro.org>, 
	Dmitry Torokhov <dmitry.torokhov@gmail.com>, Mark Brown <broonie@kernel.org>, 
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org, Stefan Wahren <wahrenst@gmx.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, Feb 24, 2024 at 6:33=E2=80=AFPM Sebastian Reichel <sre@kernel.org> =
wrote:

> +&gpio2 {
> +       /* configuring this to output-high results in poweroff */
> +       power-en-hog {
> +               gpio-hog;
> +               gpios =3D <6 GPIO_ACTIVE_HIGH>;
> +               line-name =3D "power-en-gpio";
> +               output-low;
> +               pinctrl-names =3D "default";
> +               pinctrl-0 =3D <&mux_poweroff2>;
> +       };
> +};
> +
> +&ecspi3 {

It is recommended to put the nodes in alphabetical order (except
iomuxc, which is the last one).

> +       mux_gc0308: gc0308grp {
> +               fsl,pins =3D <
> +                       MX6UL_PAD_CSI_MCLK__CSI_MCLK                    0=
x1e038
> +                       MX6UL_PAD_GPIO1_IO05__GPIO1_IO05                0=
x1b088
> +                       MX6UL_PAD_GPIO1_IO06__GPIO1_IO06                0=
x1b088
> +               >;
> +       };
> +
> +

There is an extra blank line here.

Reviewed-by: Fabio Estevam <festevam@gmail.com>