Received-SPF: pass (google.com: domain of linux-kernel+bounces-80024-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240222133500.16991-1-petr.pavlu@suse.com>
In-Reply-To: <20240222133500.16991-1-petr.pavlu@suse.com>
From: Masahiro Yamada <masahiroy@kernel.org>
Date: Sun, 25 Feb 2024 18:06:49 +0900
Message-ID: <CAK7LNAS+p-4X-ns6XnsjA+UMhUOv7sZzd3oTVfZwPe1t_sSeFA@mail.gmail.com>
Subject: Re: [PATCH v3] kbuild: Use -fmin-function-alignment when available
To: Petr Pavlu <petr.pavlu@suse.com>
Cc: nathan@kernel.org, nicolas@fjasle.eu, mark.rutland@arm.com, 
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 22, 2024 at 10:35=E2=80=AFPM Petr Pavlu <petr.pavlu@suse.com> w=
rote:
>
> GCC recently added option -fmin-function-alignment, which should appear
> in GCC 14. Unlike -falign-functions, this option causes all functions to
> be aligned at the specified value, including the cold ones.
>
> In particular, when an arm64 kernel is built with
> DYNAMIC_FTRACE_WITH_CALL_OPS=3Dy, the 8-byte function alignment is
> required for correct functionality. This was done by -falign-functions=3D=
8
> and having workarounds in the kernel to force the compiler to follow
> this alignment. The new -fmin-function-alignment option directly
> guarantees it.
>
> Detect availability of -fmin-function-alignment and use it instead of
> -falign-functions when present. Introduce CC_HAS_SANE_FUNCTION_ALIGNMENT
> and enable __cold to work as expected when it is set.
>
> Signed-off-by: Petr Pavlu <petr.pavlu@suse.com>
> Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
> ---


Applied to linux-kbuild.
Thanks.


--=20
Best Regards
Masahiro Yamada