Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp875983rbb; Sun, 25 Feb 2024 07:58:19 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWFGq9NXKgppjbf0Iz7IbOv85gXka+n/DmLzo0Vhgz+2+6jglPaOCSkDDA4bUu0RiX5vcL02Kf6ClLSf3oik1PQ9Unnf62JwOlBNfZ5zA== X-Google-Smtp-Source: AGHT+IFnj1Stjli94nGIH0q6rGdXcMIiS9t50YMunWkN5CljnQhx4uN8Ze1s+eOeWUv/jOicVHfH X-Received: by 2002:a9d:7981:0:b0:6e4:37c6:66bf with SMTP id h1-20020a9d7981000000b006e437c666bfmr5575885otm.17.1708876699703; Sun, 25 Feb 2024 07:58:19 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708876699; cv=pass; d=google.com; s=arc-20160816; b=f1ZMthucJLhmyV4Zl2kPfAiCID4GnlKVivK35la3BbS0aO7SI7MQ2krRC+XgHNdHRg rFr/94CWsB5OIOpRd403Sfi5sB9ZTiIsY7wxNiUZqlMltIbAPaqF+lWRFazGTILwOTGw 7dPoZydik5fx2qev7Q2nbi4mGRuJXGC+ALgO4m6Jdg0YkhsB86NAqqLHBCUNmvFzjhnN uRzKIgMQ2MBJFIbKriBT9tEThivlgPRrMY/+heUPnCkXwF/c7NuaqB0mOILnpDFPv8il C7a5d5iMCFCBj8VDmFdwQsn++xiWOdNVQF8oXWMqakyrCA3uYtTtFWtGJREPu6kf2mxM CLRw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :sender:dkim-signature; bh=kF6rP2xfdv/6N4QkVaNiBDdDiZRDh2pGQVheDyIMBTM=; fh=uyC7YmjGSeCikOQisEhiO1G8xjfi4cocmNjY6pok/ZE=; b=VawZdvAH1rDmkhzRTkkN65YkI3lUamJXDDcSiKeU+TUY+dNgmmDzY4mTxlGpoZhOba JO1Kj+oiLCONh6ASs266kO81fFoKQ+cEXgPpbVpEhsuyv6CnzPVzBtCMkPbedd2CAuHM KadXIeMkLh6l4EXx6MwNSSMtnw+xUvkSVjfwUf7cmHBNICj+sy6avyGCXr9a7gG9jnfY shcOTCXCtUEpQe3gTv+2bKuo9DMnKqmUtAXcsnXNm+NZ/3i2FbjsnKqIipV4vzvB5B2Y jhKqi1TeZMDQiy5QHbe+hqu4jSAOYlqG1kKsFk8lkpFBP+duwqf4z76tFJOZCAjVV6AH 4Zwg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=kEGNttgS; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-80178-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-80178-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id y22-20020a05620a25d600b00785d6d13172si3104557qko.164.2024.02.25.07.58.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Feb 2024 07:58:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-80178-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=kEGNttgS; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-80178-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-80178-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 640EA1C20926 for ; Sun, 25 Feb 2024 15:58:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8625D1758F; Sun, 25 Feb 2024 15:58:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kEGNttgS" Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0126716427; Sun, 25 Feb 2024 15:58:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708876692; cv=none; b=NpcwEXvnB+jMDiWzhQkIaPf+KLrglkQDojbA5Cmc6qxtJUsGwHynKxU39IM77Lv1v8CdIswiKl619SpSn8G9L1KpxKBLr5eneJYqQVSJqZsgyXj9Zg6JTchSKtbYBSFGOL7bhY+fGZoN7fjqs55x11JaC205C6SdP2I1x8fXC2k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708876692; c=relaxed/simple; bh=fxntaAlaNoORGg4Yti1Rnj8spJy2frmT6XkMpzimGD8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RLtxHBWahub+vG+F33iV2aisY0Bkr8Qr98dkX52wfBCqqZv43w1Y+SsxWVbjnAZGbYJxiEehPLQ6Dxyf6+HX09oGom3MDTeG4M8mUGPVhrd0VaulD6HF9wMTK3ZaldpWPkPHw9C6iSFWJXPUO9jCNlZgokMMaGrGSAxaO6LnLHA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kEGNttgS; arc=none smtp.client-ip=209.85.215.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-5d42e7ab8a9so1442406a12.3; Sun, 25 Feb 2024 07:58:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708876690; x=1709481490; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=kF6rP2xfdv/6N4QkVaNiBDdDiZRDh2pGQVheDyIMBTM=; b=kEGNttgSTp/mZUm+T73GSH6KdsR/BirEVT/3ddf/RMmGDQmxD2mUkurinyOagbQAsW zkx4OtlbwTMJ/DxNF1GBXKeM/iJj0MqoZ22C40cdLXQqM8gWnIC0diRjiWwmCbaoKKCE oRXjZhZA6iDtRhHBzLlLritFswkCldCUfMQm0PkvQ8TfTYcGbvwh/wGNHMeOnSIEFngX hPROJIq+CBjEmLgl+6NUJQvYU9E8i35yb6+gM0f42ylmbssI5n8l3DVSl8ugAatdwX6R BFAHBM5qAIMannVKhWKX5zWnhOpT2ExrqMrS2xk9MdRXb7ODD9Bla6v7EY78H7+duNKV yqtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708876690; x=1709481490; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kF6rP2xfdv/6N4QkVaNiBDdDiZRDh2pGQVheDyIMBTM=; b=SenwULutjJ4jsrX+1iFhXIzXcTdWLkoTeMYe1oKTJoeBi/o4Oo3RtDfi5pV2GDYHMf BuSk0aUcSDGeDbYyg+xFKsdF5pqbQ9Qh2rd2r2+R0YZuLeJMlSBmKhCkjDSfpKG0kX3q W6gFtmrWoW326wSXcQBhMXaKry7vGyt1+vUrPjDWZvVCSkwaJ05nzOlgCT1e5nLUsPxL bxsl/FirXl37K2B1/sMwl1wBPReNAahpdR5I+GBJoAT85eXYWa7NGep2UR7HU3wBWvID XnR7Zi0tB8RXPkbbwIqB1sjhVVSTqhwIHpUeXa1xiBXXQ9H/DVP4iSAsnZbvzLsbj156 iA+Q== X-Forwarded-Encrypted: i=1; AJvYcCXV0Li8+TfrM46ov23k7XskZVd1W5jiffX7W9ahMKd+V9yUAyV+tA1nPet30g7xM7N2MBzjtdT3sOt+gE4LVTqzv3YguhNk8+ewZnPG X-Gm-Message-State: AOJu0YwZEGRSz5AEdNaNrSgCZGsFpi26W66gJBKEUFYR9Br/UwtU1dIJ EPWqp/1bTE1sqEgCstwdya/er/oJgJJd/VYbGxVbj+hdzXqm5gENldMoN33i X-Received: by 2002:a05:6a00:3d10:b0:6e4:e0d1:2c6a with SMTP id lo16-20020a056a003d1000b006e4e0d12c6amr4913248pfb.31.1708876690195; Sun, 25 Feb 2024 07:58:10 -0800 (PST) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id y7-20020a62ce07000000b006e45c823660sm2603089pfg.122.2024.02.25.07.58.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 25 Feb 2024 07:58:09 -0800 (PST) Sender: Guenter Roeck Message-ID: Date: Sun, 25 Feb 2024 07:58:07 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10] lib: checksum: Use aligned accesses for ip_fast_csum and csum_ipv6_magic tests Content-Language: en-US To: Charlie Jenkins , David Laight , Palmer Dabbelt , Andrew Morton , Helge Deller , "James E.J. Bottomley" , Parisc List , Christophe Leroy , Arnd Bergmann Cc: linux-kernel@vger.kernel.org, Palmer Dabbelt References: <20240223-fix_sparse_errors_checksum_tests-v10-1-b6a45914b7d8@rivosinc.com> From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: <20240223-fix_sparse_errors_checksum_tests-v10-1-b6a45914b7d8@rivosinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/23/24 14:11, Charlie Jenkins wrote: > The test cases for ip_fast_csum and csum_ipv6_magic were not properly > aligning the IP header, which were causing failures on architectures > that do not support misaligned accesses like some ARM platforms. To > solve this, align the data along (14 + NET_IP_ALIGN) bytes which is the > standard alignment of an IP header and must be supported by the > architecture. > > Furthermore, all architectures except the m68k pad "struct > csum_ipv6_magic_data" to 44 bits. To make compatible with the m68k, > manually pad this structure to 44 bits. > > Fixes: 6f4c45cbcb00 ("kunit: Add tests for csum_ipv6_magic and ip_fast_csum") > Signed-off-by: Charlie Jenkins > Reviewed-by: Guenter Roeck > Acked-by: Palmer Dabbelt Tested-by: Guenter Roeck