Received-SPF: pass (google.com: domain of linux-kernel+bounces-80214-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240224135809.830610-1-chengming.zhou@linux.dev>
In-Reply-To: <20240224135809.830610-1-chengming.zhou@linux.dev>
From: Steve French <smfrench@gmail.com>
Date: Sun, 25 Feb 2024 10:51:50 -0600
Message-ID: <CAH2r5mvoS1+52SvT3XCPiBtOWAFyoVy3LajfQSFGOAa2h8Wy3w@mail.gmail.com>
Subject: Re: [PATCH] smb: remove SLAB_MEM_SPREAD flag usage
To: chengming.zhou@linux.dev
Cc: sfrench@samba.org, pc@manguebit.com, ronniesahlberg@gmail.com, 
	sprasad@microsoft.com, tom@talpey.com, samba-technical@lists.samba.org, 
	linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, 
	vbabka@suse.cz, roman.gushchin@linux.dev, Xiongwei.Song@windriver.com, 
	Chengming Zhou <zhouchengming@bytedance.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

added to cifs-2.6.git for-next (minor update to put "Link: ...") line
in the description

On Sat, Feb 24, 2024 at 7:58=E2=80=AFAM <chengming.zhou@linux.dev> wrote:
>
> From: Chengming Zhou <zhouchengming@bytedance.com>
>
> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> its usage so we can delete it from slab. No functional change.
>
> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
> ---
>  fs/smb/client/cifsfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/smb/client/cifsfs.c b/fs/smb/client/cifsfs.c
> index 9cd3bb48bd3b..45e57c852f33 100644
> --- a/fs/smb/client/cifsfs.c
> +++ b/fs/smb/client/cifsfs.c
> @@ -1661,7 +1661,7 @@ cifs_init_inodecache(void)
>         cifs_inode_cachep =3D kmem_cache_create("cifs_inode_cache",
>                                               sizeof(struct cifsInodeInfo=
),
>                                               0, (SLAB_RECLAIM_ACCOUNT|
> -                                               SLAB_MEM_SPREAD|SLAB_ACCO=
UNT),
> +                                               SLAB_ACCOUNT),
>                                               cifs_init_once);
>         if (cifs_inode_cachep =3D=3D NULL)
>                 return -ENOMEM;
> --
> 2.40.1
>
>


--=20
Thanks,

Steve