Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp915601rbb; Sun, 25 Feb 2024 09:40:53 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVp7EARfwQZmN7qs5K4f07yCYRrbrNigMwRcDvFkULH2KoQOW3l5cRBQEbBl5dOZQskDfbxxm30zUGCNKm1RHVeaHARgUkFUYa4n6zN2w== X-Google-Smtp-Source: AGHT+IGEO7Zre45pwxTHvWAbcN0FbwkKcnqiheNK6UEI07CLSRNnYf/g0M8Kpsd6yaK0iO8drzIY X-Received: by 2002:ad4:5bc3:0:b0:68f:daf8:f97d with SMTP id t3-20020ad45bc3000000b0068fdaf8f97dmr4025597qvt.5.1708882852894; Sun, 25 Feb 2024 09:40:52 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708882852; cv=pass; d=google.com; s=arc-20160816; b=S3GJRUf+NxyGUC6oMyD65uQ5RCmLH4O1bzrMIqHDDFi61Ey8FVYDNEi8ST3teuH5tM mLUjKDp2zQF0vfHCJLoCOjJbjNrO6Zz2JDpue0aOfEpSDVRf86PWbXkGkcSDPloZnskZ M7nWdSvg5o6pI9eBI2IbgBPoZoNGlir6Ccwxrh6CTuuEAFfQPBMlfn4BWA0vtK/ZZ9yj 6LuU2373f1bLxRm65In/Txwt7/KGLHNsjho2v719eh345uwxQlTJFRxjlvbKJFnH7M/r vAtNyA1oPHPB+jEujZPlSHePS69IrYHIuhjQTnoLFfrju8VisneFKXsqs8pdAXQ0DCan wMcQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=im7JPg/kdSuHr65BMEB/5JgpND5OUK4g3Oon83ZAQbE=; fh=G1kWJ1m5lCtrWzLvgcW1WqjbG5ns0GWz6rfQOGbbefE=; b=gy4hN+r5OMBUxUF24EreVmq15nm6AgoBe3Lzc1EGg5/Z4dzG4gZGJoxi+i/Djsyy/p 37sA/xKogaGwiEn1wLoAlLfhxYEBX/kI0sBuSvNB3kak9xQrxVqRUlHOb/hGa/45VYWb 8FaHZ2+NWQ67Li6REDsBazNRKrlJoEXDkL04PTJwkhKEFG1eKu0k53wrNQWU1zAlCgD0 Nqzm4Kd08+5czVZdBOL29kJbzzf6Efp0apcs5xXPeOjNaI8VgZb5sIGJyTL+10wtWJwF 41npC22gXRXHFpoihP7ytPPRBOy8xAekThzKl5dagwxtKhh65ss4PXFZwpB1nSBe8Il0 Oa9A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="j/WsUxsI"; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-80236-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-80236-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id r4-20020ad45764000000b0068fe8212b87si3492796qvx.563.2024.02.25.09.40.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Feb 2024 09:40:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-80236-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="j/WsUxsI"; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-80236-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-80236-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id A4A761C209BD for ; Sun, 25 Feb 2024 17:40:52 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A0D8F18B1B; Sun, 25 Feb 2024 17:40:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="j/WsUxsI" Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com [209.85.210.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A07B1862E for ; Sun, 25 Feb 2024 17:40:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708882845; cv=none; b=LIy23qTPGJTpuU98g9Au0mC1uYW/VeyvGLks7DdSWz+BzJ0L0mBSxfi6a0YmALJ+Ls42KxO4IDyjwhJ0NhvRlMvOzLkHvy1icoiiOBCAw444tOUf/Wx2kS7D3HlyfXGHIcBnat2p0PeVwTsl7K2qMfKqCG4SR1rsIwCMErPlW+M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708882845; c=relaxed/simple; bh=M5ueI4rE4FkA0cMsA2V/WQsiAfStdcGMf7luW6cgZjM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eQ3Ol+G+7k0z4uPnZJvNmokWvzMWNAWguF7HGvkEaSCjRFsi22QK5t8bcd6Gh4vIzRibKWehmW0SbKe6jWJ1av06hwcgJkO9/vr0D4lftQqDxQwx37nO5a9r33Szwfwomr5OC3fd1hzHz3CYzciFETCNyRw/eOdptiD8s4PO1to= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=j/WsUxsI; arc=none smtp.client-ip=209.85.210.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-ot1-f44.google.com with SMTP id 46e09a7af769-6e2d83d2568so2062875a34.3 for ; Sun, 25 Feb 2024 09:40:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1708882843; x=1709487643; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=im7JPg/kdSuHr65BMEB/5JgpND5OUK4g3Oon83ZAQbE=; b=j/WsUxsIHnSGXSNX9juM07N/s6+qZ2lFzvRCsuK4yzy5v6BqGlN6adGBRUVC6aQvkH q+kbNL/Cjhf69HcINJ1UlsoWM4zkfbE/hCHJR7MNHfIQWKa9C019QpDT1K+ru2Ti9+xJ IiRQzk/F9MshO5kOVd24JPn9wgrxWea9kGDPM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708882843; x=1709487643; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=im7JPg/kdSuHr65BMEB/5JgpND5OUK4g3Oon83ZAQbE=; b=mOtladzVNhi5zByIgVxeeHssPMjQMYchlY2OvymNC66miv+9Qwa6FZMLf+8YfbDT95 xSv3L67A5GX6PQxWVDnNrXMPp1BFbWsbEd0qEv+eNiqGFktvOXAzRZlJeyoOSdGTwwyf WWoF37GVSjzue1v3XapPzr7G89K1JOba2ouu8gBSUCc9FduuIHUFQh3e2g/b77fHzbNa Z88zfOgInfr1bGklCUIQbQIFZKScLBzpGCzGAIzymQLbMzQvKLob2ELhKHRxuQ+ihJs/ V9Jzt/FTMoyMRmH76uGa2QjG3cw12zvuaU62Pl3sEjB9NHx6Crm4lezWAYNeuB53LUGu bR4g== X-Forwarded-Encrypted: i=1; AJvYcCU/abqGVnylQHT+xNaVWbO8IdZ8NRs3ru6kXzXbffQk+S8ybRcHzPUY1r5UNLekUOotAjw56g8i718W3LNZTkve3oLqS1gFy8i2ti2J X-Gm-Message-State: AOJu0YzSAOZVTcEjkX+QchDZN1bW8E3JbgTDuovjDDI90uO6Sn5PNIer UBTsNxGqvAyQpMGbBup7rdTAj1s5CtD6IGG72xbOHG+XjBEbZTCHTagJipZrbGxG0raagD1LfhA = X-Received: by 2002:a05:6358:190a:b0:17b:2bc6:e843 with SMTP id w10-20020a056358190a00b0017b2bc6e843mr7852953rwm.18.1708882843251; Sun, 25 Feb 2024 09:40:43 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id e1-20020a635001000000b0059b2316be86sm2556856pgb.46.2024.02.25.09.40.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Feb 2024 09:40:42 -0800 (PST) Date: Sun, 25 Feb 2024 09:40:41 -0800 From: Kees Cook To: Allen Cc: Tejun Heo , Lai Jiangshan , torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCHSET wq/for-6.9,6.10] workqueue: Implement disable/enable_work() Message-ID: <202402250940.15C634D27@keescook> References: <20240216180559.208276-1-tj@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Feb 21, 2024 at 09:03:47AM -0800, Allen wrote: > Tejun, > > > > For 0001-00010: > > > > > > Reviewed-by: Lai Jiangshan > > > > Applied 0001-0010 to wq/for-6.9. > > > > Thanks. > > I have rebased the conversion work based on > > git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git disable_work-v1 > > 0001-dma-Convert-from-tasklet-to-BH-workqueue.patch > 0002-IB-Convert-from-tasklet-to-BH-workqueue.patch > 0003-USB-Convert-from-tasklet-to-BH-workqueue.patch > 0004-mailbox-Convert-from-tasklet-to-BH-workqueue.patch > 0005-ipmi-Convert-from-tasklet-to-BH-workqueue.patch > 0006-s390-Convert-from-tasklet-to-BH-workqueue.patch > 0007-drivers-media-Convert-from-tasklet-to-BH-workqueue.patch > 0008-mmc-Convert-from-tasklet-to-BH-workqueue.patch > > Patches: https://github.com/allenpais/for-6.9-bh-conversions > KSPP Issue: refactor all tasklet users into other APIs ? Issue #94 ? > https://github.com/KSPP/linux/issues/94 > > I am working on drivers/crypto/* and drivers/net/*. This might a > day or two more. Please provide guidance on the types of testing I > should perform. Great! What's the plan for these? Will they go to subsystem maintainers after the next merge window, or is Tejun carrying them? -Kees -- Kees Cook