Received-SPF: pass (google.com: domain of linux-kernel+bounces-80252-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <ad071ad2-693f-4689-a324-37e80495635a@oracle.com>
Date: Mon, 26 Feb 2024 00:21:40 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: CVE-2023-52471: ice: Fix some null pointer dereference issues in
 ice_ptp.c
To: cve@kernel.org, linux-kernel@vger.kernel.org,
        linux-cve-announce@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Darren Kenny <darren.kenny@oracle.com>
References: <2024022546-CVE-2023-52471-ab29@gregkh>
Content-Language: en-US
From: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
In-Reply-To: <2024022546-CVE-2023-52471-ab29@gregkh>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?M0lhVDZOb0dUTDlIaGtPNDFDbTZsTHN1bS9uVHhTT1lGMTZvY1kzaFZCVTJn?=
 =?utf-8?B?eG1iRWw4am1DczZtRGpNa3FoVU1ObWZlMGhGODdOZXdPU21XelNvVnU5L0FV?=
 =?utf-8?B?OEwydTMwYTJWTGh0Mi9tWTFGeHp6UHhMQ200VUZtV1BjMy9CSUw4aTRwODlX?=
 =?utf-8?B?Z3NSMHIxdldPN3VKak9PSWFUd2IxOU5oRDQ1UnpCUkZ5bFBtZG4xSUxKNEl6?=
 =?utf-8?B?aXpaS1dMQU5WRjZ6TkhPK2ZCWVlqUzhRMU5hLzI4Z3FOWjIrYVg0ZFpZMzFW?=
 =?utf-8?B?SVVkZ0VMbnFTbFRkMy8wTU1TamYyL1FkM2NEbXVkNWYwZzBPbkRRZ2RuNmhl?=
 =?utf-8?B?Ukc5cW5SVlVXLysxcFhpSlVaaGZWK0JMMlVEOFJLK3NsTk1aUjRjTFE0VE1X?=
 =?utf-8?B?SW1rT1Yvc2wwVkgwWUN2TStQVHZuMDI5Y1ZoRWRIS0tNK3Z3Wmx2a3NCcFJn?=
 =?utf-8?B?bUQyYzljU3p1cjZ4TllUNVV3Ymxva2V6TC9HSm4wSkFqNWpEc2FSdHlqMDQ4?=
 =?utf-8?B?bXpvT2RhVkE5aGpSUVdYTE9jSmxONU50OFA1UFFuUHRnL2RDNWV5aEJ3R2Iv?=
 =?utf-8?B?WUp2RzlITmVIdVZmd1p3L2d3UnduR09xa1RoV3dkQjVUeUNvWGRtV0xCUk1k?=
 =?utf-8?B?SFREaUM3eE5uNWhtMjAvajI2VFNzWG5BdnY4WEplMTBVSnFwbjh6bXJ3Mjc2?=
 =?utf-8?B?VzZySTN5dVZraXFhWUdyVUJESFBnSE8vTzV6ZWx6bEliaGtzMnFVV0pIK0xV?=
 =?utf-8?B?MGE4K2lTcGpoV0QwMWFCZFhySWlnVnRDU0JSdHJ3d1lJY1MrM1IyUURFM1Rs?=
 =?utf-8?B?TXdxeVd6SmIxTjIyRzhJb1BGVU0zREMybTEwcWhRbVp6RjlWMFF6RFBEMnp1?=
 =?utf-8?B?RWtoK2tvZndYekRHUUNUT09ES0tBeGY0NHJxUFNWUlhVak5Jdm1QdEMyNmtr?=
 =?utf-8?B?aWxPOG1wbGpibXhuQW5vaDNtaE5FMGJrWWk0UGxCZkp5bHJVTWVSa2NrUlJX?=
 =?utf-8?B?eGlWaEJ6R1d1ZjNxK1V4MUJDTkdWZjE5WmRmRWtBcVFBT25jNnV4YlZ2K3pE?=
 =?utf-8?B?NS9ybFB5Q1NNWW50YXhBMW8zVmQ5czB0cER3V3VsTDV6WXRQNnFDN0RzYitY?=
 =?utf-8?B?ZFhyNytrU2lRa3psa2RFMmRZVUxqek5hVmo0YjlpUys0UVZkQ1BScldiMTlp?=
 =?utf-8?B?NStMSGhhM2NpWmFIc1ZSc09oZ2ovLzJMaUp3U2Z4OWZvRmVDdXRQSTFOOTBB?=
 =?utf-8?B?SThucEQzbFY5QzZVVjdKeERNbGNVdXdvSDgvazFHQ3o3MnVaNlYzUFNKQnBZ?=
 =?utf-8?B?ZFRmMzJKZlRITHd5cFl1ajdFVXZKb1FsdjJld1NyU1pIN0ZGQWFNblY4Z2lr?=
 =?utf-8?B?dnN3YnlzMEo4RlZFNmwwNmVZWE1EOURyVGxNVzRRVGVvazNMcWdwSnZ6YmpM?=
 =?utf-8?B?bUEwT09ZTkd1eEM3Y0txT1FhWmZIMmVoVzdlQUt4Y3U3c3djOERDT1lwN1oz?=
 =?utf-8?B?aFdmQmVoN1ZXS2xMLzhJOE1ER0ErdXBTcU9wbU5CcUQvOXg0SE5wQUJsZmFs?=
 =?utf-8?B?QTZIWEhldi90Vityb1BXbU9YeDVzbTdldnUzdkRyZmdnR2NlQUY1cGZLTTNY?=
 =?utf-8?B?WFlndWZrMGNYOEJhM0w0bVZRUDdVc0IrdE9iRVBRUTJvVGtDbGtBczVrWkJD?=
 =?utf-8?B?eHRiVTJHY2VUZ2tBMEFHaU0vUUVpTSt3THNLbm95UEgzclR0V1czRlI0c1Js?=
 =?utf-8?B?bzhkWU1CdXZlY3UvU0llYkFaY0VaUnNiRWV5Z0QremJXdVdEQmhNK29wbGh2?=
 =?utf-8?B?Z0lXMVZyWWNKWDhtM24wVzlHUXhZTkxtWU9NekhKTEZsdWsxYnJtVTJEb1V6?=
 =?utf-8?B?ZEgzK1Myb0tJdWVUWDBBWGxhaElad1BVNVRETGw4bFVMdXZaeFoveW9vOExo?=
 =?utf-8?B?cDVVYmZUandsQmtWdHAwOHU2THNvZklYdkhKVFMxY3dUQm1BSzQwR2ZWY29C?=
 =?utf-8?B?c29mb2tUL2h6R3pJYk5JYzZGdkJHZmxCTEtmZjRWcTdBQUJUdXdJRVZiV0RS?=
 =?utf-8?B?WHRFbkJvaDdoeGU3MGFRYzlIVnV6N3A1ZFVGclJHUmtCc3RqbjNJek5kdGZw?=
 =?utf-8?B?cWc5NzVXT3VhWG5zYnY5bzF2TEFjeFZPRVlIZnA2Q0VnMTQ0SHVVTG5CSHg0?=
 =?utf-8?Q?EZDsMH3OGOPuEKr+2RIcl24=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	Bv8VYkhn/z/FbgYzzPSb5CsQSRNupJ6TCuMASchoQ2gcIHao5J6Wjy19Wgtwwjq+GwFRhtFWThnvDOQAaVz2BNBv5j1WwUGV4lgdApa2YE8C3KKCGmiT08nWu8aGIHi3N6ez2n4ZxRtb8ZcC5gXZ00V85NzwcDEMLKowYPsmGT27+f5f882tITMk+p+VM611fdWbc3bt0HDWfmHKZzCWTkTrByP1iPv/uUYI42S1Oa8PcCkSQA+roewrObLixjZKPg8Ti9BUJoUI65pUcQgGRwnuLEMAszJMwf120gzOfQs8deytYzGSZKzatdaSlvSCLP7ouUOwbg22S5E3yuYiC7oyZXjcub3DU9Ly0tobBk7TLDF3ZTlrq6mhF0cfOcip+N4VQzAYP/vo/xmw8MstYl/tWWgwZq5gp3eDPaDHca2EIN6DEyZrcYl1+YFctl+sC2D0kbZIu3n8GwPY1rqJ7jZcdO/QPCsb5Dh+1WukE1yBYrr4k96ot7bCpcUCPzC/enMT0ZeOOriepKgvmCFdBUhcHo55N/l0rT12uyHsybLsOXMLJNyNhlKzPwAfqccRzqvFNk9mhdBNSlp2sqvLARcdfFNGz5JQCTkDeehlHtM=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a7cc271-e4fb-4feb-0d6a-08dc3632d220
X-MS-Exchange-CrossTenant-AuthSource: PH8PR10MB6290.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2024 18:51:48.4039
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8pi2Fo/yFYuXcSUu5JG5RVdZLIhedDAQ8EPb7UgsnMm/1QqbECcI1D9HQ3AcV4BQp2cjoIBi0leJO9gEkD5mD3bFH8KTyordL2fNZLiXKmy0kwAt0ZVVVZdaT0NDE3nX
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR10MB6006
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-25_21,2024-02-23_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0
 adultscore=0 mlxlogscore=999 malwarescore=0 spamscore=0 bulkscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2402250150
X-Proofpoint-GUID: _UGiy6EC91UBCDzS8LGWIVlvm-gqLiR3
X-Proofpoint-ORIG-GUID: _UGiy6EC91UBCDzS8LGWIVlvm-gqLiR3

Hi Greg,

On 25/02/24 13:46, Greg Kroah-Hartman wrote:
> Description
> ===========
> 
> In the Linux kernel, the following vulnerability has been resolved:
> 
> ice: Fix some null pointer dereference issues in ice_ptp.c
> 
> devm_kasprintf() returns a pointer to dynamically allocated memory
> which can be NULL upon failure.
> 

I have a question about this and couple of other CVEs:

CVE-2023-52465: -- devm_kzalloc() and devm_kasprintf() failures
CVE-2023-52467: -- kasprintf() failure
CVE-2023-52471: -- devm_kasprintf() failure
CVE-2023-52472: -- allocation failure

As it's widely believed that small kmallocs cannot fail, is it worth 
having CVEs for the above bug fixes ?

Thanks,
Harshit

> The Linux kernel CVE team has assigned CVE-2023-52471 to this issue.
> 
> 
> Affected and fixed versions
> ===========================
> 
> 	Issue introduced in 6.7 with commit d938a8cca88a and fixed in 6.7.2 with commit 3cd9b9bee33f
> 	Issue introduced in 6.7 with commit d938a8cca88a and fixed in 6.8-rc1 with commit 3027e7b15b02
> 
> Please see https://www.kernel.org or a full list of currently supported
> kernel versions by the kernel community.
> 
> Unaffected versions might change over time as fixes are backported to
> older supported kernel versions.  The official CVE entry at
> 	https://cve.org/CVERecord/?id=CVE-2023-52471
> will be updated if fixes are backported, please check that for the most
> up to date information about this issue.
> 
> 
> Affected files
> ==============
> 
> The file(s) affected by this issue are:
> 	drivers/net/ethernet/intel/ice/ice_ptp.c
> 
> 
> Mitigation
> ==========
> 
> The Linux kernel CVE team recommends that you update to the latest
> stable kernel version for this, and many other bugfixes.  Individual
> changes are never tested alone, but rather are part of a larger kernel
> release.  Cherry-picking individual commits is not recommended or
> supported by the Linux kernel community at all.  If however, updating to
> the latest release is impossible, the individual changes to resolve this
> issue can be found at these commits:
> 	https://git.kernel.org/stable/c/3cd9b9bee33f39f6c6d52360fe381b89a7b12695
> 	https://git.kernel.org/stable/c/3027e7b15b02d2d37e3f82d6b8404f6d37e3b8cf
>