Received-SPF: pass (google.com: domain of linux-kernel+bounces-80313-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Mon, 26 Feb 2024 08:41:16 +1100
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Christian =?UTF-8?B?S8O2bmln?=
 <christian.koenig@amd.com>, Somalapuram Amaranath
 <Amaranath.Somalapuram@amd.com>, Intel Graphics
 <intel-gfx@lists.freedesktop.org>, DRI <dri-devel@lists.freedesktop.org>,
 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Linux Next
 Mailing List <linux-next@vger.kernel.org>, zack.rusin@broadcom.com,
 tzimmermann@suse.de, thomas.hellstrom@linux.intel.com, Joonas Lahtinen
 <joonas.lahtinen@linux.intel.com>, Tvrtko Ursulin
 <tvrtko.ursulin@linux.intel.com>
Subject: Re: linux-next: build failure after merge of the drm-misc tree
Message-ID: <20240226084116.4a41527d@canb.auug.org.au>
In-Reply-To: <20240220084821.1c852736@canb.auug.org.au>
References: <20240206152850.333f620d@canb.auug.org.au>
	<87y1bp962d.fsf@intel.com>
	<20240220084821.1c852736@canb.auug.org.au>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/.dDX5vFifkGrhZOnmdXK3G+";
 protocol="application/pgp-signature"; micalg=pgp-sha256

--Sig_/.dDX5vFifkGrhZOnmdXK3G+
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi all,

On Tue, 20 Feb 2024 08:48:21 +1100 Stephen Rothwell <sfr@canb.auug.org.au> =
wrote:
>=20
> On Mon, 12 Feb 2024 15:15:54 +0200 Jani Nikula <jani.nikula@linux.intel.c=
om> wrote:
> >
> > On Tue, 06 Feb 2024, Stephen Rothwell <sfr@canb.auug.org.au> wrote: =20
> > >
> > > After merging the drm-misc tree, today's linux-next build (i386 defco=
nfig)
> > > failed like this:
> > >
> > > In function 'i915_ttm_placement_from_obj',
> > >     inlined from 'i915_ttm_get_pages' at drivers/gpu/drm/i915/gem/i91=
5_gem_ttm.c:847:2:
> > > drivers/gpu/drm/i915/gem/i915_gem_ttm.c:165:18: error: 'places[0].fla=
gs' is used uninitialized [-Werror=3Duninitialized]
> > >   165 |         places[0].flags |=3D TTM_PL_FLAG_DESIRED;
> > >       |         ~~~~~~~~~^~~~~~
> > > drivers/gpu/drm/i915/gem/i915_gem_ttm.c: In function 'i915_ttm_get_pa=
ges':
> > > drivers/gpu/drm/i915/gem/i915_gem_ttm.c:837:26: note: 'places' declar=
ed here
> > >   837 |         struct ttm_place places[I915_TTM_MAX_PLACEMENTS + 1];
> > >       |                          ^~~~~~
> > >
> > > Caused by commit
> > >
> > >   a78a8da51b36 ("drm/ttm: replace busy placement with flags v6")   =20
> >=20
> > Cc: more people.
> >  =20
> > >
> > > I applied the following hack for today:
> > >
> > > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > > Date: Tue, 6 Feb 2024 15:17:54 +1100
> > > Subject: [PATCH] drm/ttm: initialise places
> > >
> > > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > > ---
> > >  drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/dr=
m/i915/gem/i915_gem_ttm.c
> > > index 80c6cafc8887..34e699e67c25 100644
> > > --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> > > +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> > > @@ -834,7 +834,7 @@ static int __i915_ttm_get_pages(struct drm_i915_g=
em_object *obj,
> > > =20
> > >  static int i915_ttm_get_pages(struct drm_i915_gem_object *obj)
> > >  {
> > > -	struct ttm_place places[I915_TTM_MAX_PLACEMENTS + 1];
> > > +	struct ttm_place places[I915_TTM_MAX_PLACEMENTS + 1] =3D {};
> > >  	struct ttm_placement placement;
> > > =20
> > >  	/* restricted by sg_alloc_table */
> > > --=20
> > > 2.43.0   =20
>=20
> I am still applying the above patch ...

Any progress?

--=20
Cheers,
Stephen Rothwell

--Sig_/.dDX5vFifkGrhZOnmdXK3G+
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmXbs/wACgkQAVBC80lX
0GzVNAf+NA5dVgLq87RWtvqT6p13nZ1XBU+lhzY1TyrQ6HnAk4MxDUyrgsuG1x9S
isf4VzgO4JJ82ryYBxBOeEpWqZjCRJm0rFJ/Bopbc+9nO9oaxMF/2QuXM7fheOQU
FkmZjf9k3fqrkhzO7EpnERgPYPaEODOwLHq0tbl9sqagNW3xN0vwq7QgSJ/quN43
z3xEJ/2sGJz3F73adPCnYUhWMUHH477OjWB8Mqgjguov5scDu77zS0gEr/PTnOYA
pNDGC/sh0jJAeVh5Yt6w+mbGSCjWRKKy25Yszh/yKGsaeZE5sP7gy9cH/QrfL8Ig
GYpWdXwnhA7Hk0DlVVNaDvWnibdhjQ==
=FX83
-----END PGP SIGNATURE-----

--Sig_/.dDX5vFifkGrhZOnmdXK3G+--