Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp1006067rbb; Sun, 25 Feb 2024 14:56:34 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUunl9YQnUsT1zJxXgvsjN8k6PD4sVaJH4425N+V4OLFcLXAgraIU+MlGTT6EUY68QIy53Fi2K/F76Eev5E64ETuCfvkmApdwryNfIRgw== X-Google-Smtp-Source: AGHT+IGEsS8UKVJc57gXUkbD4+a/DGNnZk5dVK0fylprEbFaXtc8ACM1/NQV+JS6GJkQTHZSYRBx X-Received: by 2002:a05:6871:4d3:b0:21e:9b56:737f with SMTP id n19-20020a05687104d300b0021e9b56737fmr5576171oai.19.1708901794262; Sun, 25 Feb 2024 14:56:34 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708901794; cv=pass; d=google.com; s=arc-20160816; b=x9bsvZCvZWj2Wp7awmT4f72bJJ0n/FunRE02khdt14TeJ5u40yo31J5T8f7DjI/vl+ L2XzzDB3g9bqZgQ8IjikfTFYILZCmI5sMfGRsiXBbwPk9RUozb2MPDjZzcGPDxSAc5Ka YvBTYyCYTgORrwt8xF+GFZacOzQpvLKbnkL69mjffQPY6CF5nPY2SCB+ojq+ZzpT1Q7t IJvCLDLHO0QAk0Y4VIv6hD7BkPDdzc7Mlhr2mG8o5uyU8qlYEqgy57SH3nZ59I9e17h0 oNjiZ025/gMMEQRhApVvtHfFsrqhn/xAbEWliuhlTWAvYaxtE+sPp7orgnzUw6Sub9rM UwLg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=JqHHLOQqUv5xfwT+lJsi/MnTliEWNbGbU+FDZ5U1DJ4=; fh=9AYDxpIF3ws21qQDvjghHSFUuXpDdpq2Zh/SbnasVRo=; b=OIOz0Im2zofINHm9Vjn/tdWZPbKINrpWFZZLvevk/pRBjihhj3Stv52D7REA/3VI1T uTCSPfcsWxjXYXvpPY+vGKsI+6uLjX8MVfLCuPWVsfDKTJHVd0lxELeA82QqdqqQl3eA piORSbf7+XWZQNRz7QIN4IU+qHAb3hUwiKFZbR7VQahz5GQwFZzE+RDNEuX/jbNXwpJ5 xRq7wlJ+5k3wcQ+Omi2vT8hJWudhlnEf6f/wYmP4CMDKdbqpJY3mmp1FP/kg+NjT0gOw I0SkxIhZI9PTtuHyIQfHzodjHD0FhmkqHHTPtWipXI/a6tfKW/VEcRQaatoD5ppCKtcA iytw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oDxXy8zs; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-80333-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-80333-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id wa17-20020a05620a4d1100b00787bd7195a1si3850535qkn.424.2024.02.25.14.56.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Feb 2024 14:56:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-80333-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oDxXy8zs; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-80333-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-80333-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 06B4C1C21232 for ; Sun, 25 Feb 2024 22:56:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B67EA1F959; Sun, 25 Feb 2024 22:55:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oDxXy8zs" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7ADC1F608 for ; Sun, 25 Feb 2024 22:55:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708901727; cv=none; b=VyfMoNwM05CLJRd/qE4Z1nTUM3RIaTtENO8I/Q3izXRthztrzbLkwvynad7iTV99RNmQJtACxHgdOzsU9ZB9YviuNAH5L7rAhSyBbfgp6WLY94oIsMI5bDq3M3ihum1SeCazJT+4aL6gzFS26qRuO87wy5s5phRIY1sBXBmXiWs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708901727; c=relaxed/simple; bh=elCK0+UoX/y8indul9dlqt/x3/BB/vOLFTEHdirzUYU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=owVZCcIXh4uUoX/AVS9qizvkH0wesUzxPc0VtChgKFLUUK+9nhFcU2ivmT4iZv0bsv/Ab+MPuw5e/rg5zP9eHtb2HP+H6Lmc1zIxRS5m1xQshl47WIsRvC1mq/gYv4QpHYfIT8K38nbDS5AmQu3WsDuRKgmNl3sg023e+oHRb5s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oDxXy8zs; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35B06C433C7; Sun, 25 Feb 2024 22:55:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708901726; bh=elCK0+UoX/y8indul9dlqt/x3/BB/vOLFTEHdirzUYU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oDxXy8zs+PD/0lFXaeh+O7GkIW/2o2BmLXGid5juParGagr6D/1nuC1RpV/4D/KRV Jv7qk9e13MvoUXQUvt4gnxtdZx0xh2/gt59C+ZxP71ylsVMpSTThjcIT/jTic64+jO S21gfq2BPBG1Yj3HWuHVKqM8rGgZZ32yssOa9BfVRDrQrytFI9oXNIfsno5DHxceUD sVv6Sp9TWvIctBEeZMuaZXpDn4INZE0tDFVuK023M43zPseubxNB6w3uwWk4LjmUaT HxNa9xd+WRRmJDx263Ie4UN4ajiGbplFKA3GTzyqsLlXmzKpK5JA+QQ1Okb2aBJOtO JXEMQmz38YtFg== From: Frederic Weisbecker To: LKML Cc: Frederic Weisbecker , Thomas Gleixner , Ingo Molnar , Anna-Maria Behnsen , Peng Liu , Joel Fernandes Subject: [PATCH 06/16] tick: No need to clear ts->next_tick again Date: Sun, 25 Feb 2024 23:54:58 +0100 Message-ID: <20240225225508.11587-7-frederic@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240225225508.11587-1-frederic@kernel.org> References: <20240225225508.11587-1-frederic@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The tick sched structure is already cleared from tick_cancel_sched_timer(), so there is no need to clear that field again. Reviewed-by: Thomas Gleixner Signed-off-by: Frederic Weisbecker --- kernel/time/tick-sched.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c index 9f75f5621965..b17895de26b9 100644 --- a/kernel/time/tick-sched.c +++ b/kernel/time/tick-sched.c @@ -1143,11 +1143,6 @@ static bool can_stop_idle_tick(int cpu, struct tick_sched *ts) if (unlikely(!cpu_online(cpu))) { if (cpu == tick_do_timer_cpu) tick_do_timer_cpu = TICK_DO_TIMER_NONE; - /* - * Make sure the CPU doesn't get fooled by obsolete tick - * deadline if it comes back online later. - */ - ts->next_tick = 0; return false; } -- 2.43.0