Received-SPF: pass (google.com: domain of linux-kernel+bounces-80370-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <d34ba82f-cde8-4bf9-ab97-a1c4c06c2972@linux.alibaba.com>
Date: Mon, 26 Feb 2024 09:11:09 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] ocfs2: remove SLAB_MEM_SPREAD flag usage
Content-Language: en-US
To: Chengming Zhou <chengming.zhou@linux.dev>, mark@fasheh.com,
 jlbec@evilplan.org, brauner@kernel.org, jlayton@kernel.org,
 keescook@chromium.org, akpm <akpm@linux-foundation.org>
Cc: jack@suse.cz, zhouchengming@bytedance.com, azeemshaikh38@gmail.com,
 ocfs2-devel@lists.linux.dev, linux-kernel@vger.kernel.org,
 linux-mm@kvack.org, vbabka@suse.cz, roman.gushchin@linux.dev,
 Xiongwei.Song@windriver.com
References: <20240224135008.829878-1-chengming.zhou@linux.dev>
 <aee616f4-40fc-4d24-9010-d0589d59f664@linux.alibaba.com>
 <34678776-859a-42f2-802b-0c7bc90bdfdc@linux.dev>
From: Joseph Qi <joseph.qi@linux.alibaba.com>
In-Reply-To: <34678776-859a-42f2-802b-0c7bc90bdfdc@linux.dev>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 2/25/24 9:02 PM, Chengming Zhou wrote:
> On 2024/2/25 20:20, Joseph Qi wrote:
>>
>>
>> On 2/24/24 9:50 PM, chengming.zhou@linux.dev wrote:
>>> From: Chengming Zhou <zhouchengming@bytedance.com>
>>>
>>> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
>>> its usage so we can delete it from slab. No functional change.
>>>
>> If I understand correctly, you are referring the following patch:
>> https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/
>>
>> But it seems that the above patch is not included in mainline yet.
>> Or am I missing something?
> 
> I realize my commit message should explain more why it's a no-op, my bad.
> 
> The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was
> removed so it became a dead flag as of v6.8-rc1. That series[1]
> mark it obsolete to avoid confusion for users. So here we can just
> remove all its users, which has no functional changes.
> 
> [1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/
> 
Take more look at v6.8-rc1, I've found the following commit:
16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h")
It seems that after this commit, there is no user of 'SLAB_MEM_SPREAD'. So,
Acked-by: Joseph Qi <joseph.qi@linux.alibaba.com>