Received-SPF: pass (google.com: domain of linux-kernel+bounces-80402-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Subject: Re: [PATCH] ubifs: remove SLAB_MEM_SPREAD flag usage
To: <chengming.zhou@linux.dev>, <richard@nod.at>
CC: <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
	<linux-mm@kvack.org>, <vbabka@suse.cz>, <roman.gushchin@linux.dev>,
	<Xiongwei.Song@windriver.com>, Chengming Zhou <zhouchengming@bytedance.com>
References: <20240224135217.830331-1-chengming.zhou@linux.dev>
From: Zhihao Cheng <chengzhihao1@huawei.com>
Message-ID: <3384a81a-e6c9-6f2e-e66e-c9b9a9433c0f@huawei.com>
Date: Mon, 26 Feb 2024 10:12:46 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <20240224135217.830331-1-chengming.zhou@linux.dev>
Content-Type: text/plain; charset="gbk"; format=flowed
Content-Transfer-Encoding: 8bit

?? 2024/2/24 21:52, chengming.zhou@linux.dev д??:
> From: Chengming Zhou <zhouchengming@bytedance.com>
> 
> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> its usage so we can delete it from slab. No functional change.
> 
> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
> ---
>   fs/ubifs/super.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 

Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
> diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
> index f780729eec06..8ae7648021a8 100644
> --- a/fs/ubifs/super.c
> +++ b/fs/ubifs/super.c
> @@ -2433,8 +2433,8 @@ static int __init ubifs_init(void)
>   
>   	ubifs_inode_slab = kmem_cache_create("ubifs_inode_slab",
>   				sizeof(struct ubifs_inode), 0,
> -				SLAB_MEM_SPREAD | SLAB_RECLAIM_ACCOUNT |
> -				SLAB_ACCOUNT, &inode_slab_ctor);
> +				SLAB_RECLAIM_ACCOUNT | SLAB_ACCOUNT,
> +				&inode_slab_ctor);
>   	if (!ubifs_inode_slab)
>   		return -ENOMEM;
>   
>