Received-SPF: pass (google.com: domain of linux-kernel+bounces-80416-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <df416acb-d913-4e67-b810-cd991003242e@intel.com>
Date: Mon, 26 Feb 2024 10:38:31 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/1] mm/madvise: enhance lazyfreeing with mTHP in
 madvise_free
Content-Language: en-US
To: Lance Yang <ioworker0@gmail.com>, <akpm@linux-foundation.org>
CC: <zokeefe@google.com>, <shy828301@gmail.com>, <david@redhat.com>,
	<mhocko@suse.com>, <ryan.roberts@arm.com>, <wangkefeng.wang@huawei.com>,
	<songmuchun@bytedance.com>, <peterx@redhat.com>, <minchan@kernel.org>,
	<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
References: <20240225123215.86503-1-ioworker0@gmail.com>
From: Yin Fengwei <fengwei.yin@intel.com>
In-Reply-To: <20240225123215.86503-1-ioworker0@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OGRvRG5SbU5Pb1VGMWVXZzc2MlhkTStuQ2sySTNKK2grVGtQM3hXdHA0cmhE?=
 =?utf-8?B?NDEwb0dMYlV0cFZHK25ubXBHRnN4OWFocWczSnY1RGFTdlFhbHlleFQ3OTRn?=
 =?utf-8?B?d3hoOXo4RkFTU0lucEtCSCt5ajNUM0dTcS9kNkJxS0R6cFJibU5iZ0l4MzY5?=
 =?utf-8?B?OUNGUXA2ZGh4NGxIa0ZZbnhGZXczZUtvdk8rZXFsSnZML3FQSm8xV1BvSTZH?=
 =?utf-8?B?NFBudHhrRDU1UXZSQ2dndmxkenJOYzBkdExDQitacC9HaHJDMlJFZjllQUFw?=
 =?utf-8?B?Nkl0ek51OWYrdVpJNkZkdU9BQ1kxQkl0M0IwN2VaSjFBSktiYW43MDQxRlFX?=
 =?utf-8?B?VGxJaC9ya3VlWXdGSGhneUdBQmMwSVJNRDR0VkJUK3pKdDlmMGtuMThmb1Bm?=
 =?utf-8?B?Z1lmcGJIdmZXeXAvSFFueFo2U0NKNmt2YzRjbmxhcXArT2dRd3FpZmVodHVI?=
 =?utf-8?B?UjFnM1pwSWF0dXlVZDh5cUV1OW4yODFVcGtGV0hwbzVVWHNVaDRzendENEVS?=
 =?utf-8?B?azk4SEtWcGFoUmhYbG94bkwyVUJ5V2lRN2tVbVF0OHlBZDFVL3UyQUlrcE5v?=
 =?utf-8?B?Z2IzUEE0S1Z4RndmTmN0cXVuQTgyRm5Xb3ZVbXpkcCtJQVo0R1NaRUlxUnpM?=
 =?utf-8?B?Ny9JYmpjU2Ird1VJNHZVc3NkV2I1VS8yQVlXb0JsODJ6ZzBFK1VGSkVvTFdO?=
 =?utf-8?B?aUdTNWp5U3d0R0tkeUdMTGlDa2hYNlZWVVRXVzNzcFJlWm9WbFRBcHhkMmxk?=
 =?utf-8?B?U0MxTWkwNVBhQUJmcXVpd3A1a3o3MmZGNWtISFlmSTA2YXVOUkgxQnAwSEhG?=
 =?utf-8?B?UUdyTmh5Z010Z3I2MW5BcTduOTlLWFBJNEhrMWdIVXJKYWVNZlpFOEhwa21y?=
 =?utf-8?B?M2dlU1lFdEYyNG5rS0VBZXk0RUJxdmZ1cHFjK1ljZDh0TE52RDZSZ2JrM2Jy?=
 =?utf-8?B?Z09ZSTc3c3ppdFNoZ0VPVjE5aWZKcU01SE9tdW5ZbjNlVGt2bzBLN09HYVNx?=
 =?utf-8?B?VExqaW8wTzhjSEtkNGc1Tlp6YSs1ZTFBTUQyMzZtUzR6YzlkVThFN2ZMV0t6?=
 =?utf-8?B?SERCRmZiUXV3STB2M3NiNTYzekhsbUpZSkc0R1hLQVFuNFpsUXQyYkFldmds?=
 =?utf-8?B?SUxIYmNHdmR2bnMyZFdzQk9sT2tacWRncTFZeFd5RHFQOHd5OW4zTStiazg4?=
 =?utf-8?B?Yjd3UHR6RWFQY0UxcWVhbm1mTXdhMzE3NXJrbDdlMG1LODJBWDRkYmJCaDNa?=
 =?utf-8?B?Ykd0V3lnT2F5dTNZWktVQkI1K09leklOQndKVHcrZ1RvMTlOOUVYVWx4T1lB?=
 =?utf-8?B?SjFMNkw2OFZPNXExZFFQK2grdTMwRTd0bm5KNnBtZE9MQ0tTRjZZTTlSVUJ1?=
 =?utf-8?B?K3F0NnhRYmxQR0V3NWxSQllkTnpjcjhZUEcwZFgxb3hMd3c0d00rWTdzOE9F?=
 =?utf-8?B?V00zdGcwRHdSVmJVTXg2UnBlS0R2QzhxRG0vcUNDL2V4MzUzWlBvbmxaalUx?=
 =?utf-8?B?YTRPTHZGeHJFamtjekdubUhlWkk2MEhqTklYclpKZ00zNVpPL2FoenpvTDBU?=
 =?utf-8?B?RmhLaElvTUdMeE9hWWhDQWk4TFBabmdqRWNPZ1RwS1h2eDh5UW02WUgvRFN6?=
 =?utf-8?B?WWh6MzN3cnFZQ0s4dWZzYWc3aHBzZUV1eHpVdHhTZXlNRnkyaTJXZkJEYmFu?=
 =?utf-8?B?VGhDQTB0L0FhZWdQTVZtVFVkc2ZPcE9JQkJwSDNubjFlQ3hCSFpUZkJEdUpU?=
 =?utf-8?B?Wnc2QnZISTB1cFBlalJJZkg1T1VHNGNydUhDc0w4dVc5enQ1a0M1NlEwUXRB?=
 =?utf-8?B?Rysrd1l3ZCtCaVNTSGZpOFZ6NE53TERvMjljbW80K1N1encwcDV3SUVLcDkv?=
 =?utf-8?B?b3JIM3pPL1B2STlOQkIxMXZVczNidlJVTEZXNTJHZGhGN0g1TFdtVEFiVCsw?=
 =?utf-8?B?NVNoT3Ezcm9FcmxodW9oOUJlSEE0TFRPemlzQkJ4dEVmdzkvV2dNODd6SjJq?=
 =?utf-8?B?ZSt0aVNzMWdFMzJheVVObDFwaDNiK3A5czlzUUJFdkFOR25UYTQxYmJuSUs5?=
 =?utf-8?B?ZWFmQS9LOGFYTWludEhZM3A2aUZwUFV0ZEo0dVBoWkJqMWhjVFlLYUR3Rmdw?=
 =?utf-8?B?ZVUxNXloWWI2WlhZRXQ4bHBESVNoVndiNlFvUmVSTHM3RkQ0RDFhWGs1d3Bs?=
 =?utf-8?B?MkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 94a13e8e-57e1-469a-228a-08dc36740231
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2024 02:38:26.3396
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9wRKsgOVMak6KMANWBmZ6WiWC9AWZkVpNiZHHIrNZWyQJTvz6n9puk9YwDkpyKBfWpxkGQ6AXclix6DZoXcHbw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6402
X-OriginatorOrg: intel.com


On 1/1/70 08:00,  wrote:
> diff --git a/mm/madvise.c b/mm/madvise.c
> index cfa5e7288261..bcbf56595a2e 100644
> --- a/mm/madvise.c
> +++ b/mm/madvise.c
> @@ -676,11 +676,43 @@ static int madvise_free_pte_range(pmd_t *pmd, unsigned long addr,
>  		 */
>  		if (folio_test_large(folio)) {
>  			int err;
> +			unsigned long next_addr, align;
>  
> -			if (folio_estimated_sharers(folio) != 1)
> -				break;
> -			if (!folio_trylock(folio))
> -				break;
> +			if (folio_estimated_sharers(folio) != 1 ||
> +			    !folio_trylock(folio))
> +				goto skip_large_folio;
> +
> +			align = folio_nr_pages(folio) * PAGE_SIZE;
> +			next_addr = ALIGN_DOWN(addr + align, align);
There is a possible corner case:
If there is a cow folio associated with this folio and the cow folio
has smaller size than this folio for whatever reason, this change can't
handle it correctly.


Regards
Yin, Fengwei