Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp1081500rbb; Sun, 25 Feb 2024 19:19:28 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWMn8nSyKdchvobNs5UmQ/WefTgYqRfjLC1YO1bcSMUUqLPM4Q4eoRBUX2I81gyMDN12OHrSnQfaOxxA5NF6PMLym0JrPcoQWWzvPvtkQ== X-Google-Smtp-Source: AGHT+IHXfLWMLx3Q5IQSXNSu2g2AZADWEr6k3auLeayR5fZvh4LLp2LzkbepqJMS9W6OnvV99teQ X-Received: by 2002:a9d:7cc4:0:b0:6e4:80c3:af76 with SMTP id r4-20020a9d7cc4000000b006e480c3af76mr5532013otn.17.1708917568672; Sun, 25 Feb 2024 19:19:28 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708917568; cv=pass; d=google.com; s=arc-20160816; b=gQkGfMvfSuzNGgwXryUm8MKbBAWt4moE8fO6OVAyBVU4KLkoH7eY3T/XQbORp2bokp c+NfYp3pcEUEqpCjw8lqk8Occ4YaIiF58qyosP5YIeB/4vdjtDDDAvIobfLyYJxDSFCm 5AyrEfrrbDr1Njv5LCaqDzwah+IZUcLCTitXoBn1KTuzzAZU3NJkJlxEnpTyiulaEN4u AHi/xN19DJC6tq50lbc2L1qbATUulkBG2hAIsB9/3bt/S3HoBdUtA/9RYpnvp0fNPfmO hI1kuAHYVQFVj+K0iZZTdKR+8YaIl11G6S46GxB+D7TzgjPT5/SDzBeXcRWrl2pDHSLz QDGA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=GmO6fwtPPRc5uVcx4Jw3SiECTlbLWxfjY4BXirgPdhg=; fh=X1/oBJvTGJUQ0YtRp03u+3tPfRw/dXXALWynfOSlfQQ=; b=xE9vBcbqPlVZhFkdVE6FRW1/b7X0WASTAYyBswZb0dA/15A/yT2emIbpNXYc3ATif3 SIuCaApTbp7wVRi3JxN8M8flh2RqWYOAH2ulJBe8ulGCuJG5hDFjqC5F9hadJDgfrKpy U6A/nRwIYAwb0ncRONcyFeI9hDyM51hiFxvNRJOm2gxaLmIzcE6bkC9DhXzJfWegsFNJ lbaDMb824Fzln6V+bV8b91mv6Gv/13kKr5YTxd64zgoXb0+tgfeNS5A5hPN1ipM5oNbY bnAiEntmH1zKoXQOTo9VhhOqroH/MxYdDJiwdr2sE27Oo/OqNlP/j27IYSEC8QLCjEl6 siRA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nkdIayy8; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-80454-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-80454-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id w18-20020a63af12000000b005dc891520f0si2958156pge.272.2024.02.25.19.19.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Feb 2024 19:19:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-80454-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nkdIayy8; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-80454-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-80454-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 5A8DB281AB2 for ; Mon, 26 Feb 2024 03:19:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9D25314F68; Mon, 26 Feb 2024 03:19:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nkdIayy8" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA7BA14263 for ; Mon, 26 Feb 2024 03:19:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708917562; cv=none; b=d3jX2Tipey6aVmBCkqhfARa+kcndWw984x5m3ixhfxn0gfQAQDa/ABLb++DWqvTNbchzfOotOq0LFisGOYCJG4/bKVqltgPGkLyFozaofxC609IbpsDdK5ihXdqv5LDG2ZKydgFPqhMQMAdRtQk6QCsEC4IuPQMFeQCngkhB9VA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708917562; c=relaxed/simple; bh=Sz0jqU0v0tnHzoX+q1gyX1BWNEr6Uw1vZ878UbaRw+A=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=OdDDH8DOpZFSqiuQXlV1q7YdRInld3W6fz4bD5gAOyagnYsKTqy5tpkGgKK6LEF/ww3Mj4fdW5MsklJ+RZ+ufpi31nRvgvqYnZWTbjsw/q1OUKc3wNwk59cBikekxiVPPxjy6L5zxxh64ggE2JnsVimBQHjAqMiNbripqMb96mw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nkdIayy8; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0F7B5C433F1; Mon, 26 Feb 2024 03:19:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708917562; bh=Sz0jqU0v0tnHzoX+q1gyX1BWNEr6Uw1vZ878UbaRw+A=; h=From:To:Cc:Subject:Date:From; b=nkdIayy8WuuXHCfivhW41LDvhKRAvve89Ehr0XoCveRNsV4v4Kelo/ZpsOlV/Eg+r PxoMAuAfgTgOaNX2ibsqQyn0Qz6pgcjNxO3ScsvOQzXVFcUhTMpVV31pG2GelcA8RO wANUevdAV3n5yqwv0PiSMc7qA90+P265iqNOWlxyXIqonAGCoCcF96MIjgzndLcZ4d IO5+xAcdzr7BWd+M0c91iM7LAh0HMaYWwpN2q5g1VFBYc9D8l1KyDHXlmOB+0EMI60 pBGfV+D0Bt4GZiqpJbXHeKqgh//InS4JpPxDQusj6OaMacfBQgVYkasLDzpXiHq8nF Zv8nuxqfAbijg== From: Chao Yu To: jaegeuk@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Chao Yu Subject: [PATCH] f2fs: fix to check return value in f2fs_insert_range() Date: Mon, 26 Feb 2024 11:19:16 +0800 Message-Id: <20240226031916.2420870-1-chao@kernel.org> X-Mailer: git-send-email 2.40.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In f2fs_insert_range(), it missed to check return value of filemap_write_and_wait_range(), fix it. Meanwhile, just return error number once __exchange_data_block() fails. Signed-off-by: Chao Yu --- fs/f2fs/file.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 6ddc2092842b..0a80fdf0cdb8 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -1679,10 +1679,12 @@ static int f2fs_insert_range(struct inode *inode, loff_t offset, loff_t len) } filemap_invalidate_unlock(mapping); f2fs_up_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]); + if (ret) + return ret; /* write out all moved pages, if possible */ filemap_invalidate_lock(mapping); - filemap_write_and_wait_range(mapping, offset, LLONG_MAX); + ret = filemap_write_and_wait_range(mapping, offset, LLONG_MAX); truncate_pagecache(inode, offset); filemap_invalidate_unlock(mapping); -- 2.40.1