Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755505AbYAARx4 (ORCPT ); Tue, 1 Jan 2008 12:53:56 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752966AbYAARxt (ORCPT ); Tue, 1 Jan 2008 12:53:49 -0500 Received: from smtp5.pp.htv.fi ([213.243.153.39]:33515 "EHLO smtp5.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752038AbYAARxs (ORCPT ); Tue, 1 Jan 2008 12:53:48 -0500 Date: Tue, 1 Jan 2008 19:53:34 +0200 From: Adrian Bunk To: Bartlomiej Zolnierkiewicz Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] ide: use MODULE_VERSION() Message-ID: <20080101175333.GA27566@does.not.exist> References: <200801011840.38757.bzolnier@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <200801011840.38757.bzolnier@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1999 Lines: 62 On Tue, Jan 01, 2008 at 06:40:38PM +0100, Bartlomiej Zolnierkiewicz wrote: > > * Replace driver versions in comments by DRV_VERSION define. > > * Add MODULE_VERSION(DRV_VERSION) to drivers defining DRV_VERSION. >... Could you limit this to actively maintained version numbers and also remove the others from .version, printk's,...? An example: > --- a/drivers/ide/legacy/umc8672.c > +++ b/drivers/ide/legacy/umc8672.c > @@ -1,5 +1,5 @@ > /* > - * linux/drivers/ide/legacy/umc8672.c Version 0.05 Jul 31, 1996 > + * linux/drivers/ide/legacy/umc8672.c > * > * Copyright (C) 1995-1996 Linus Torvalds & author (see below) > */ > @@ -53,6 +53,8 @@ > > #include > > +#define DRV_VERSION "0.05" > + > /* > * Default speeds. These can be changed with "auto-tune" and/or hdparm. > */ > @@ -185,3 +187,4 @@ module_init(umc8672_init); > MODULE_AUTHOR("Wolfram Podien"); > MODULE_DESCRIPTION("Support for UMC 8672 IDE chipset"); > MODULE_LICENSE("GPL"); > +MODULE_VERSION(DRV_VERSION); >... I do not see any value in printing a version number from 1996 (sic), and the driver has for sure changed without any update of the version number. For actively maintained version numbers (and even more when distributions backport more recent versions of a driver) printing a (maintained) driver version number makes sense, but otherwise the kernel version contains more information and a stale version number only gives the false impression the driver hadn't changed. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/