Received-SPF: pass (google.com: domain of linux-kernel+bounces-80476-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Feedback-ID: iad51458e:Fastmail
Date: Sun, 25 Feb 2024 19:42:27 -0800
From: Boqun Feng <boqun.feng@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: jiangshanlai@gmail.com, torvalds@linux-foundation.org,
	linux-kernel@vger.kernel.org, allen.lkml@gmail.com,
	kernel-team@meta.com
Subject: Re: [PATCH 12/17] workqueue: Implement disable/enable for (delayed)
 work items
Message-ID: <ZdwIoyRllkjnSTAH@boqun-archlinux>
References: <20240216180559.208276-1-tj@kernel.org>
 <20240216180559.208276-13-tj@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240216180559.208276-13-tj@kernel.org>

On Fri, Feb 16, 2024 at 08:04:53AM -1000, Tejun Heo wrote:
[...]
> +/**
> + * enable_work - Enable a work item
> + * @work: work item to enable
> + *
> + * Undo disable_work[_sync]() by decrementing @work's disable count. @work can
> + * only be queued if its disable count is 0.
> + *
> + * Must be called from a sleepable context. Returns %true if the disable count
> + * reached 0. Otherwise, %false.
> + */
> +bool enable_work(struct work_struct *work)
> +{
> +	struct work_offq_data offqd;
> +	unsigned long irq_flags;
> +
> +	work_grab_pending(work, 0, &irq_flags);
> +
> +	work_offqd_unpack(&offqd, *work_data_bits(work));
> +	work_offqd_enable(&offqd);
> +	set_work_pool_and_clear_pending(work, offqd.pool_id,
> +					work_offqd_pack_flags(&offqd));
> +	local_irq_enable();

Maybe
	local_irq_restore(irq_flags);

?

Because in a later patch, you make this funciton callable in any
context, so it may be called with irq disabled.

Regards,
Boqun

> +
> +	return !offqd.disable;
> +}
> +EXPORT_SYMBOL_GPL(enable_work);
[..]