Received-SPF: pass (google.com: domain of linux-kernel+bounces-80478-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Sun, 25 Feb 2024 21:44:59 -0600
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: Arnd Bergmann <arnd@kernel.org>
CC: Oded Gabbay <ogabbay@kernel.org>, Thomas =?utf-8?Q?Hellstr=C3=B6m?=
	<thomas.hellstrom@linux.intel.com>, Arnd Bergmann <arnd@arndb.de>, "Maarten
 Lankhorst" <maarten.lankhorst@linux.intel.com>, Maxime Ripard
	<mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, David Airlie
	<airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Nathan Chancellor
	<nathan@kernel.org>, Nick Desaulniers <ndesaulniers@google.com>, "Bill
 Wendling" <morbo@google.com>, Justin Stitt <justinstitt@google.com>, "Rodrigo
 Vivi" <rodrigo.vivi@intel.com>, Matt Roper <matthew.d.roper@intel.com>,
	Matthew Auld <matthew.auld@intel.com>, Matthew Brost
	<matthew.brost@intel.com>, Koby Elbaz <kelbaz@habana.ai>, "Michael J. Ruhl"
	<michael.j.ruhl@intel.com>, Francois Dugast <francois.dugast@intel.com>, Dave
 Airlie <airlied@redhat.com>, <intel-xe@lists.freedesktop.org>,
	<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
	<llvm@lists.linux.dev>
Subject: Re: [PATCH 2/3] drm/xe/mmio: fix build warning for BAR resize on
 32-bit
Message-ID: <qybrvc6fwxjnnt4lwuf2xmdbhznvwzz2bhmlm6m57bze65f6xf@rxbkx74kv6k7>
References: <20240224121528.1972719-1-arnd@kernel.org>
 <20240224121528.1972719-2-arnd@kernel.org>
Content-Type: text/plain; charset="us-ascii"; format=flowed
Content-Disposition: inline
In-Reply-To: <20240224121528.1972719-2-arnd@kernel.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?B5JNGb5lAGSyOqgn5mY+wEAdt6qHwuWFzsHQ3stvjt6i2XDmiWUL71m3c1Oq?=
 =?us-ascii?Q?OqAPOvDtlRRyElVfFKOw6JPZ40CSMozBW+e7LSl3dSK0YrIvSIJ9INj8I1zB?=
 =?us-ascii?Q?+q27SCkwi93hdsyTBfjDPihFBNg4E3O5oQVpD4OQ4Oo3LdoAQwUK1zIPO6I3?=
 =?us-ascii?Q?Yz1bw7H1ki3tsdIcaUdektRC8lv8Y6UyOdIbBaO+eNqmeJaE+hqJmqp23sUf?=
 =?us-ascii?Q?IkbhwJ9Pk0YRBOIJ40HhgkBLNAykZjPUZTC6IpOSYY6Fw08Nzo0k7btL/ZJN?=
 =?us-ascii?Q?lePDtp8USY3QtODTAl7bmvJ29IUpW25sDOjqUzuio1/XVW59p8aIW3COvfxn?=
 =?us-ascii?Q?111ljeLuJxTVnYjtcowXmAiEWMum+NGmBttX9YSm8NPzfgsZpaYE9rGj+55C?=
 =?us-ascii?Q?pih5xucX2GSzB/9Ceee8XHS602TOQoNSqOpL3rbOGh0l25OiGFhVZyVVaQJ8?=
 =?us-ascii?Q?giFJGr6LGA6jpwroOT5jkv/RUu6QBXK/qDdomFZLLdZood3Q4JBg3Rs4xKlF?=
 =?us-ascii?Q?WHMDQftpL0HA0o1NBE+OYrEMzzssBOdZBIUJASMgxGIRmZeiw59VJj8qhvAY?=
 =?us-ascii?Q?hq3c/9OBItmpowx/nFb0UdWRg85fHOXRyZ16xAfVpNEPrJdwTdwHNqADFj4q?=
 =?us-ascii?Q?vJ7NI7OsYWv19gUR7JoMLIgH03bT2GALetGApAM0x77cilr5DWYe/QkM4X8t?=
 =?us-ascii?Q?9+ClrR1s1osPrfY0v3rq2L+eUxoxAtV4sWOZJsnSD9bcKSqDMlv5JAVD7VRV?=
 =?us-ascii?Q?TwOzoeBLKJZJhmrVgwHKun7IZPNaycZCL7eawmci2vODGIJIbTums5t5wF2l?=
 =?us-ascii?Q?d04+jJEttvb6dAcJlgbarR8yMQLY/zsHoqJMRCBI10CUqAns/94BlcRx93tE?=
 =?us-ascii?Q?PyNLuT/jQLJB5CWEawxO9D4DTseRBnmijwhZnDM8nqoRJs46TgogIRj+Hmtp?=
 =?us-ascii?Q?sLzvxn2aqKgAqgdTogIbvy9EJwAm9Tqx0JNvleqU3oYWt0whYgthhAJ3fX+t?=
 =?us-ascii?Q?ViO+la43uB8maxNQmYKO2B720Equ33Hyk6XsLhoOsAb5Xma1kRaEr7DvuXEc?=
 =?us-ascii?Q?AbYmMZQ/h6WURdwRXwArEyXk6cS5OnZTJRcc3fr4tgpV2nx75/LkRfU3Gj0F?=
 =?us-ascii?Q?viFETng7+DvGpF1jP4NK3mliROc27/rP9+b8PAn+Uc7OFbRuvGuu+7/hNOLF?=
 =?us-ascii?Q?FCdbnRFwiuz3eL20XEEmRFBWXlChI0ea4eOknJXekXz60Nnj/+QAXX22Rg8v?=
 =?us-ascii?Q?qLhzaACYaJui2mwMByuC0gu3osLYA4QPs5PuReeb4mpyW1yz+HpC8KNZWlcT?=
 =?us-ascii?Q?Mf4220tnUC5SpGtmo81hA4Rwa4CxCCJ9za4XlHS2yZNUt5eN7c9aFtdSqO2e?=
 =?us-ascii?Q?50HTJ2+aiWGNZeViq6L0WzN62jB6nlCrMx21uveTyNTd99YI16WV5JVhqjs8?=
 =?us-ascii?Q?AfojNyn+qb62fhqVlRUu2+nLjhzw4d4nGeBx/47uyXZu0Bixey8qzaVZPLgi?=
 =?us-ascii?Q?nk6m7RNzhOLQMGfK1ARKdZfhGoxpeNlWmz2dA8nqd6lWpvMqSY6DZD4Xbhlr?=
 =?us-ascii?Q?HCpoU0P37hXjcEVUECYsS//AlUwl6ZeutHIK6SbKtWL8bc5S9hhSlo4fTzQZ?=
 =?us-ascii?Q?tQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c2b4d36-322a-466e-2d74-08dc367d5419
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6139.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2024 03:45:09.0851
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 88MxFlvvAW63UUtljVdYhVkpgrXprd8nQiZhQIV9ZXLiPF0D/6iKyWNWxF1xHudTjUX55rnWirfBC1+fl0/F4RPdcY8yU4sdBIJGgn/Hl5w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7333
X-OriginatorOrg: intel.com

On Sat, Feb 24, 2024 at 01:15:00PM +0100, Arnd Bergmann wrote:
>From: Arnd Bergmann <arnd@arndb.de>
>
>clang complains about a nonsensical test on builds with a 32-bit phys_addr_t,
>which means resizing will always fail:
>
>drivers/gpu/drm/xe/xe_mmio.c:109:23: error: result of comparison of constant 4294967296 with expression of type 'resource_size_t' (aka 'unsigned int') is always false [-Werror,-Wtautological-constant-out-of-range-compare]
>  109 |                     root_res->start > 0x100000000ull)
>      |                     ~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~
>
>Previously, BAR resize was always disallowed on 32-bit kernels, but
>this apparently changed recently. Since 32-bit machines can in theory
>support PAE/LPAE for large address spaces, this may end up useful,
>so change the driver to shut up the warning but still work when
>phys_addr_t/resource_size_t is 64 bit wide.
>
>Fixes: 9a6e6c14bfde ("drm/xe/mmio: Use non-atomic writeq/readq variant for 32b")
>Fixes: ea97a66a2218 ("drm/xe: Disable 32bits build")

this second Fixes should not be here? How would "disabling 32bits build"
break 32bits build? I think just the first one is enough, otherwise
237412e45390 ("drm/xe: Enable 32bits build") is your next good
candidate.


Acked-by: Lucas De Marchi <lucas.demarchi@intel.com>

Lucas De Marchi

>Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>---
> drivers/gpu/drm/xe/xe_mmio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_mmio.c b/drivers/gpu/drm/xe/xe_mmio.c
>index e3db3a178760..7ba2477452d7 100644
>--- a/drivers/gpu/drm/xe/xe_mmio.c
>+++ b/drivers/gpu/drm/xe/xe_mmio.c
>@@ -106,7 +106,7 @@ static void xe_resize_vram_bar(struct xe_device *xe)
>
> 	pci_bus_for_each_resource(root, root_res, i) {
> 		if (root_res && root_res->flags & (IORESOURCE_MEM | IORESOURCE_MEM_64) &&
>-		    root_res->start > 0x100000000ull)
>+		    (u64)root_res->start > 0x100000000ul)
> 			break;
> 	}
>
>-- 
>2.39.2
>